Re: [Spice-devel] [win32/vd_agent 1/4] construct WDDMMonitorConfigEscape also with NULL DisplayMode

2019-03-07 Thread Frediano Ziglio
> > Adding possibility to construct WDDMMonitorConfigEscape object > with NULL parameter of DisplayMode. In this case all the fields > depending on DisplayMode are set to zero. > > Signed-off-by: Yuri Benditovich Acked-by: Frediano Ziglio > --- > vdagent/display_configuration.cpp | 8

Re: [Spice-devel] [win32/vd_agent 2/4] add to CCD object reference to parent WDDM object

2019-03-07 Thread Frediano Ziglio
> > Adding to CCD object reference to WDDM interface that includes it. > This allows to use WDDM methods from CCD methods. > This is just spaghetti code. CCD was added to deal with a specific Windows API, if now it calls WDDMInterface it does not make any sense. Would be better to just send the

Re: [Spice-devel] [PATCH spice-gtk 3/3] clipboard: invalidate targets request when needed

2019-03-07 Thread Jakub Janku
Hi, On Wed, Mar 6, 2019 at 7:11 PM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > Targets request is no longer relevant when > > clipboard owner changes since the retrieved targets > > will be outdated. > > > > When the request is no longer

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

2019-03-07 Thread Jakub Janku
Hi, thanks for having a look! On Wed, Mar 6, 2019 at 6:42 PM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > If two grab messages in opposite directions "meet" on their way > > to their destinations, we end up in a state when both spice-gtk > >

Re: [Spice-devel] [PATCH spice-common 9/9] codegen: Rename --prefix parameter to --suffix

2019-03-07 Thread Frediano Ziglio
> > On Sun, Mar 03, 2019 at 07:10:30PM +, Frediano Ziglio wrote: > > The option is used to add a suffix to public functions, not a > > prefix. > > Sometimes it's a suffix to a prefix, sometimes it's indeed just a > suffix. So your change makes sense. > I cannot find any place where is used

Re: [Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-07 Thread Frediano Ziglio
> > Acked-by: Christophe Fergeau > Thanks, looking at reply to 9/9 however I think one thing is not clear from what I wrote in the commit message. The reason is not only that was used in protocol 1 only and now is not used but also that it was wrong from the beginning and useless. I would keep

Re: [Spice-devel] [PATCH spice-common 9/9] codegen: Rename --prefix parameter to --suffix

2019-03-07 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 07:10:30PM +, Frediano Ziglio wrote: > The option is used to add a suffix to public functions, not a > prefix. Sometimes it's a suffix to a prefix, sometimes it's indeed just a suffix. So your change makes sense. > Currently the option is not used (it was used to

Re: [Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-07 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Sun, Mar 03, 2019 at 07:10:28PM +, Frediano Ziglio wrote: > This option was used in protocol 1 to generate 64 bit pointers. > A pointer in the protocol is an offset in the current message. > This allows the possibility to have messages with pointers with >

Re: [Spice-devel] [PATCH spice-common 6/9] Generate automatically most C message declarations

2019-03-07 Thread Christophe Fergeau
Acked-by: Christophe Fergeau only one caveat is that some of the structs are getting renamed to equivalent ones (SpiceMsgDisplayDrawBlend/SpiceMsgDisplayDrawCopy, SpiceMsgcMainAgentStart/SpiceMsgcMainAgentTokens and a few more), which is fine because they are typedef'ed to the other type

Re: [Spice-devel] [PATCH spice-common 5/9] Allow to generate C declarations for spice.proto

2019-03-07 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 07:10:26PM +, Frediano Ziglio wrote: > Generate and include C declarations. > Next patch will use this facility. Since none of the spice.proto types are decorated with @declare, adding the #include in messages.h won't have any bad consequences > > Signed-off-by:

Re: [Spice-devel] [PATCH spice-common 4/9] codegen: Allows to generate C declarations automatically

2019-03-07 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 07:10:25PM +, Frediano Ziglio wrote: > Allows to specify a @declare attribute for messages and structure > that can generate the needed C structures. > > Signed-off-by: Frediano Ziglio > --- > python_modules/ptypes.py | 64 >

Re: [Spice-devel] [PATCH spice-common 3/9] codegen: Generate headers while generating code

2019-03-07 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 07:10:24PM +, Frediano Ziglio wrote: > Python script generates code and header together however allowed > to save only one of them. > Allows to save both of them together to reduce number of time > we call Python script. > > Signed-off-by: Frediano Ziglio > --- >

Re: [Spice-devel] [PATCH spice-common 1/9] messages: Remove fields not used by the protocol

2019-03-07 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 07:10:22PM +, Frediano Ziglio wrote: > These fields are not used by the protocol. Maybe make it explicit that 'not used by the protocol' means they are not in spice.proto, nor will be used in the generated (de)marshallers. Apart from this, Acked-by: Christophe Fergeau

Re: [Spice-devel] [PATCH spice-common 2/9] codegen: Factor out a function to write output file

2019-03-07 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Sun, Mar 03, 2019 at 07:10:23PM +, Frediano Ziglio wrote: > This will be reused to generate C declaration automatically. > > Signed-off-by: Frediano Ziglio > --- > spice_codegen.py | 46 +- > 1 file changed, 25

Re: [Spice-devel] [spice-gtk v2 1/2] Deprecate “color-depth” properties

2019-03-07 Thread Christophe Fergeau
Hey, On Wed, Mar 06, 2019 at 02:24:24PM +, Victor Toso wrote: > Hi, > > On Tue, Jan 08, 2019 at 04:22:55PM +0100, Victor Toso wrote: > > Hi, > > > > On Tue, Jan 08, 2019 at 04:09:54PM +0100, Christophe Fergeau wrote: > > > On Fri, Dec 14, 2018 at 04:29:46PM +0100, Victor Toso wrote: > > > >