On Sun, Mar 10, 2019 at 04:46:05PM +0200, Yuri Benditovich wrote:
> Remove unused g_udev_device_get_sysfs_attr.
>
Indeed, last user was apparently removed in 45cfbe8f86c in July 2013.
Acked-by: Christophe Fergeau
> Signed-off-by: Yuri Benditovich
> ---
> src/win-usb-dev.c | 18
On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote:
> In initial device enumeration hotplug notification can be
> called twice with the same libusb device. For details, see
> http://libusb.sourceforge.net/api-1.0/group__libusb__hotplug.html#ga00e0c69ddf1fb1b6774dc918192e8dc7
> Filter
On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote:
> In initial device enumeration hotplug notification can be
"In initial device enumeration, hotplug notification..."
> called twice with the same libusb device. For details, see
>
On Sun, Mar 10, 2019 at 04:46:02PM +0200, Yuri Benditovich wrote:
> Do not create own libusb context in usb-device-manager.
> Reuse existing context created by win-usb-dev instead.
I'd rephrase this slightly
« On Windows, do not create a new libusb context in
usb-device-manager.c, but reuse the
On Sun, Mar 10, 2019 at 04:46:01PM +0200, Yuri Benditovich wrote:
> Removing unused parameter for GUdevClient constructor.
I'd explicitly mention that it's possible because we no longer use the
external libgudev, and at this point g_udev_client_new() is just
internal API used by the windows code.
Acked-by: Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:00PM +0200, Yuri Benditovich wrote:
> Replacing USE_GUDEV with G_OS_WIN32 anywhere. GUDEV simulation
> is used only in Windows build.
>
> Signed-off-by: Yuri Benditovich
> ---
> src/usb-device-manager.c | 26 +++---
>
> Series looks good to me,
>
> Reviewed-by: Christophe Fergeau
>
Why not ack? Not good enough? Not tested? Missing something?
> On Mon, Mar 11, 2019 at 01:59:09PM +, Frediano Ziglio wrote:
> > Allows to declare C declarations (that were in common/messages.h)
> > automatically.
> > I
Series looks good to me,
Reviewed-by: Christophe Fergeau
On Mon, Mar 11, 2019 at 01:59:09PM +, Frediano Ziglio wrote:
> Allows to declare C declarations (that were in common/messages.h)
> automatically.
> I added an attribute to:
> - be compatible;
> - allows to declare structure in
Signed-off-by: Frediano Ziglio
---
docs/spice_threading_model.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt
index df4922168..9351141c8 100644
--- a/docs/spice_threading_model.txt
+++
Signed-off-by: Frediano Ziglio
---
docs/spice_threading_model.txt | 8
1 file changed, 8 insertions(+)
diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt
index 9351141c8..25a3a030c 100644
--- a/docs/spice_threading_model.txt
+++
Signed-off-by: Frediano Ziglio
---
common/messages.h | 495 +-
spice.proto | 192 +-
2 files changed, 102 insertions(+), 585 deletions(-)
diff --git a/common/messages.h b/common/messages.h
index 36ee59d..5cda1d1 100644
---
Python script generates code and header together however allowed
to save only one of them.
Allows to save both of them together to reduce number of time
we call Python script.
Signed-off-by: Frediano Ziglio
---
common/Makefile.am | 16 ++--
common/client_marshallers.h | 2
Allows to declare C declarations (that were in common/messages.h)
automatically.
I added an attribute to:
- be compatible;
- allows to declare structure in different way than automatic
ones;
- allows to use different headers (as draw.h).
Changes since v2:
- use a --generate-header option
This will be reused to generate C declaration automatically.
Signed-off-by: Frediano Ziglio
Acked-by: Christophe Fergeau
---
spice_codegen.py | 46 +-
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git a/spice_codegen.py b/spice_codegen.py
Generate and include C declarations.
Next patch will use this facility.
Since none of the spice.proto types are decorated with @declare,
adding the #include in messages.h won't have any bad consequences.
Signed-off-by: Frediano Ziglio
---
common/Makefile.am | 6 --
common/meson.build | 10
Allows to specify a @declare attribute for messages and structure
that can generate the needed C structures.
Signed-off-by: Frediano Ziglio
---
python_modules/ptypes.py | 64
spice_codegen.py | 47 +
2 files changed,
On Fri, Mar 08, 2019 at 04:47:35PM -0500, Frediano Ziglio wrote:
> >
> > On Sun, Mar 03, 2019 at 07:10:25PM +, Frediano Ziglio wrote:
> > > Allows to specify a @declare attribute for messages and structure
> > > that can generate the needed C structures.
> > >
> > > Signed-off-by: Frediano
On Fri, Mar 08, 2019 at 04:42:24PM -0500, Frediano Ziglio wrote:
> >
> >
> > Bit unsure about the option name. --header-name maybe? Or just infer it
> > from the .c file name?
> >
>
> It's similar to --generate-enums and similars. Yes, on the other end this
> option is an additional generation
On Fri, Mar 08, 2019 at 04:51:20PM -0500, Frediano Ziglio wrote:
> >
> > On Sun, Mar 03, 2019 at 07:10:26PM +, Frediano Ziglio wrote:
> > > Generate and include C declarations.
> > > Next patch will use this facility.
> >
> > Since none of the spice.proto types are decorated with @declare,
On Mon, Mar 11, 2019 at 12:12:45PM +, Victor Toso wrote:
> Hi,
>
> On Mon, Mar 11, 2019 at 12:33:20PM +0100, Christophe Fergeau wrote:
> > Hey,
> >
> > One comment, even if the commit log mentions a bug #, it does not seem
> > to be describing what the bug is/how it's fixed (maybe this can
- Original Message -
> From: "Yuri Benditovich"
> To: spice-devel@lists.freedesktop.org
> Cc: y...@daynix.com
> Sent: Thursday, February 28, 2019 9:42:17 AM
> Subject: [Spice-devel] [PATCH] qxl-wddm-dod: prevent failure of power on
> transition
>
> On return from S3 the driver may
Hi,
On Mon, Mar 11, 2019 at 07:34:19AM -0400, Frediano Ziglio wrote:
> > Changes v1->v2
> > * Using reds_core_timer_* api, which calls the timeout function from the
> > right context (Frediano);
>
> Sorry, these functions suffers the same problem, you have to
> use the core interface of the
Hi,
On Mon, Mar 11, 2019 at 12:33:20PM +0100, Christophe Fergeau wrote:
> Hey,
>
> One comment, even if the commit log mentions a bug #, it does not seem
> to be describing what the bug is/how it's fixed (maybe this can be
> inferred from the traces, but I did not read them closely as the log
>
>
> From: Victor Toso
>
> The device driver might take a few interactions to reconfigure all
> displays but in each change it can send it down to spice-server. The
> client is not interested in temporary states, only the final monitor
> config can be helpful.
>
> This patch adds a 200ms delay
Hey,
One comment, even if the commit log mentions a bug #, it does not seem
to be describing what the bug is/how it's fixed (maybe this can be
inferred from the traces, but I did not read them closely as the log
does not hint that a bug can be seen by looking at them).
Christophe
On Mon, Mar
From: Victor Toso
The device driver might take a few interactions to reconfigure all
displays but in each change it can send it down to spice-server. The
client is not interested in temporary states, only the final monitor
config can be helpful.
This patch adds a 200ms delay to wait for more
On Fri, Mar 08, 2019 at 04:32:04PM -0500, Frediano Ziglio wrote:
hi,
> >
> > From: Victor Toso
> >
> > The device driver might take a few interactions to reconfigure all
> > displays but in each change it can send it down to spice-server. The
> > client is not interested in temporary states,
27 matches
Mail list logo
