Ack
On 3/19/19 4:11 PM, Frediano Ziglio wrote:
To avoid potential regressions, check it only if extra checks are
enabled.
This allows to check previous "Move channel registration to constructed
vfunc" commit.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 8
1 file changed, 8 i
>
> Rather than having an API to register client callbacks for each channel
> type, make them vfuncs.
>
> Since the client callbacks are registered identically for each channel
> of the same type, it doesn't make sense for to require these to be
> registered separately for each object. It's clea
Signed-off-by: Frediano Ziglio
---
server/main-dispatcher.c | 38 --
1 file changed, 8 insertions(+), 30 deletions(-)
diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c
index 839e7242..904579a8 100644
--- a/server/main-dispatcher.c
+++ b/server/m
Yesterday evening me and Jonathon discussed about his patches
for RedChannel vfuncs.
We agreed that the function should be vfuncs however the
patches didn't seem really great to me so we discussed
different reasons.
Came out with this series which is working pretty well.
Probably I should add so
Signed-off-by: Frediano Ziglio
---
server/main-dispatcher.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c
index 82b25e6e..0dcfb2d4 100644
--- a/server/main-dispatcher.c
+++ b/server/main-dispatcher.c
@@ -149,
No reason to pass through MainDispatcher, the purpose of
MainDispatcher is to call reds functions from the right thread.
Signed-off-by: Frediano Ziglio
---
server/main-dispatcher.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/server/main-dispatcher.c b/s
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 71 ++---
server/dispatcher.h | 15 ++
2 files changed, 62 insertions(+), 24 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 5f839ec4..0b18b32d 100644
--- a/server/d
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 104 +++
server/display-channel.h | 5 ++
server/red-worker.c | 113 ++-
3 files changed, 112 insertions(+), 110 deletions(-)
diff --git a/server/display-chann
Currently channel threading/handling is spread between RedQxl,
RedWorker and RedChannel.
Move more to RedChannel simplify RedQxl and RedWorker.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c| 4 +-
server/cursor-channel.h| 4 +-
server/display-channel.c | 2 +
server/
handler is a pointer, check for NULL, not 0.
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index ce487f63..5f839ec4 100644
--- a/server/dispatcher.c
+++ b/server/dispatcher.c
@@
This is a preparatory patch to allows DisplayChannel to check
if device is running.
Signed-off-by: Frediano Ziglio
---
server/display-channel-private.h | 1 +
server/display-channel.c | 8
server/display-channel.h | 2 ++
server/red-worker.c | 2 ++
4 files
From: Jonathon Jongsma
Rather than having an API to register client callbacks for each channel
type, make them vfuncs.
Since the client callbacks are registered identically for each channel
of the same type, it doesn't make sense for to require these to be
registered separately for each object.
Now that stuff are a bit more on their correct place some
function can be static.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 11 ---
server/cursor-channel.h | 10 --
server/display-channel.c | 12 +---
server/display-channel.h | 5 -
4 files chang
Although id is not supposed to be big prevent possible
warning/overflow.
Signed-off-by: Frediano Ziglio
---
server/red-worker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This was signaled by Christophe Fergeau
diff --git a/server/red-worker.c b/server/red-worker.c
index 8051d1e4..a
Signed-off-by: Frediano Ziglio
---
I was wondering where that "20" came.
---
server/red-worker.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/red-worker.c b/server/red-worker.c
index 3cb12b9c..8051d1e4 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -
On Wed, Mar 20, 2019 at 02:51:29PM +, Frediano Ziglio wrote:
> Although id is not supposed to be big prevent possible
> warning/overflow.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This was signaled by Christoph
>
> On Wed, Mar 20, 2019 at 02:51:29PM +, Frediano Ziglio wrote:
> > Although id is not supposed to be big prevent possible
> > warning/overflow.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/red-worker.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This wa
On Wed, Mar 20, 2019 at 11:20:20AM -0400, Frediano Ziglio wrote:
> >
> > On Wed, Mar 20, 2019 at 02:51:29PM +, Frediano Ziglio wrote:
> > > Although id is not supposed to be big prevent possible
> > > warning/overflow.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > server/red-wo
Acked-by: Jonathon Jongsma
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> handler is a pointer, check for NULL, not 0.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dispatcher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/dispatcher.c b/se
Signed-off-by: Frediano Ziglio
---
I was wondering where that "20" came.
---
server/red-worker.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/red-worker.c b/server/red-worker.c
index 3cb12b9c..8051d1e4 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -
From: Christophe Fergeau
If worker->qxl->id is bigger than 0x7ff (in other words, it's a
negative signed int) then
printf(worker_str, "display[%d]", worker->qxl->id);
will need:
"display[]" -> 9 bytes
%d -> 11 bytes
The trailing \0 will thus overflow our 20 bytes destination.
As QXLInstance
Allows the plugins to add information to the log.
Signed-off-by: Frediano Ziglio
---
Not entirely happy to export a kind of C function, any suggestion
welcome
---
include/spice-streaming-agent/plugin.hpp | 5 +
src/concrete-agent.cpp | 16 ++--
src/concrete-age
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dispatcher.c | 71 ++-
> --
> server/dispatcher.h | 15 ++
> 2 files changed, 62 insertions(+), 24 deletions(-)
>
> diff --git a/server/dispat
That's a weird function, but seems rather unrelated to the current
series.
Acked-by: Jonathon Jongsma
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/main-dispatcher.c | 13 ++---
> 1 file changed, 2 insertions(+), 11 deletions
Acked-by: Jonathon Jongsma
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> No reason to pass through MainDispatcher, the purpose of
> MainDispatcher is to call reds functions from the right thread.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/main-dispatcher.c | 18 +-
>
> On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/dispatcher.c | 71 ++-
> > --
> > server/dispatcher.h | 15 ++
> > 2 files changed, 62 insertions(+), 24 deletions(-)
> >
> > diff
There should be some justification in the commit log about why this is
an improvement.
Jonathon
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/main-dispatcher.c | 38 --
> 1 file changed, 8 insertion
>
> That's a weird function, but seems rather unrelated to the current
> series.
>
Agreed, was on the "dispatcher" line of change. Maybe the title should be
"main-dispatcher: Inline main_dispatcher_self_handle_channel_event"
(Inline instead of Remove) ?
> Acked-by: Jonathon Jongsma
>
>
> O
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> Currently channel threading/handling is spread between RedQxl,
> RedWorker and RedChannel.
> Move more to RedChannel simplify RedQxl and RedWorker.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c| 4 +-
> server
Somehow this information doesn't really seem to belong to
DisplayChannel, but I can't put my finger on exactly why it feels out
of place...
On Wed, 2019-03-20 at 09:59 +, Frediano Ziglio wrote:
> This is a preparatory patch to allows DisplayChannel to check
> if device is running.
>
> Signe
30 matches
Mail list logo
