[Spice-devel] [PATCH spice-protocol] Bump minor version to mark cleanup change

2019-04-04 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- configure.ac | 4 ++-- meson.build | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index eb1b314..22c6008 100644 --- a/configure.ac +++ b/configure.ac @@ -1,8 +1,8 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJO

Re: [Spice-devel] [PATCH spice-protocol] Bump minor version to mark cleanup change

2019-04-04 Thread Victor Toso
Hi, On Thu, Apr 04, 2019 at 08:33:27AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > configure.ac | 4 ++-- > meson.build | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index eb1b314..22c6008 100644 > --- a/con

Re: [Spice-devel] [PATCH spice-common v2 1/2] meson: Fix dependency of generated files

2019-04-04 Thread Victor Toso
Hi, On Wed, Apr 03, 2019 at 05:20:35PM +0100, Frediano Ziglio wrote: > All generated file depends on generated_messages.h which is > generated too. > So add an explicit dependency from all generated file > (except generated_messages.h generator) to generated_messages.h > generator. > This fixes co

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Victor Toso
Hi, On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: > spice-gtk and spice-server will use spice_common_client_dep > and spice_common_server_dep as dependencies. > However they will depend on both spice-common client/server > libraries and their sources causing the sources to be co

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Frediano Ziglio
> > Hi, > > On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: > > spice-gtk and spice-server will use spice_common_client_dep > > and spice_common_server_dep as dependencies. > > However they will depend on both spice-common client/server > > libraries and their sources causing the

Re: [Spice-devel] [PATCH spice-common v2 1/2] meson: Fix dependency of generated files

2019-04-04 Thread Frediano Ziglio
> > Hi, > > On Wed, Apr 03, 2019 at 05:20:35PM +0100, Frediano Ziglio wrote: > > All generated file depends on generated_messages.h which is > > generated too. > > So add an explicit dependency from all generated file > > (except generated_messages.h generator) to generated_messages.h > > generat

Re: [Spice-devel] [PATCH spice-protocol] Bump minor version to mark cleanup change

2019-04-04 Thread Frediano Ziglio
> > Hi, > > On Thu, Apr 04, 2019 at 08:33:27AM +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > > configure.ac | 4 ++-- > > meson.build | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index eb1b314..2

Re: [Spice-devel] [PATCH spice-protocol] Bump minor version to mark cleanup change

2019-04-04 Thread Victor Toso
Hi, On Thu, Apr 04, 2019 at 04:25:55AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Thu, Apr 04, 2019 at 08:33:27AM +0100, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > configure.ac | 4 ++-- > > > meson.build | 2 +- > > > 2 files changed, 3 insertions(+

Re: [Spice-devel] Blank screen on SPICE when using vGPU

2019-04-04 Thread Uri Lublin
On 4/3/19 7:33 PM, James Freeman wrote: Hi all, Conscious this might not be a SPICE issue but trying to debug where the issue is right now. I'm working with someone who is using RHV 4.2 with a vGPU configuration. At present we are stuck on a problem whereby the vGPU can be successfully assign

Re: [Spice-devel] [PATCH spice-protocol] Bump minor version to mark cleanup change

2019-04-04 Thread Frediano Ziglio
> > Hi, > > On Thu, Apr 04, 2019 at 04:25:55AM -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > On Thu, Apr 04, 2019 at 08:33:27AM +0100, Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > > > --- > > > > configure.ac | 4 ++-- > > > > meson.build | 2 +- > > > > 2 fi

Re: [Spice-devel] [PATCH spice-common v2 1/2] meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 5:08 AM, Victor Toso wrote: > Hi, > > On Wed, Apr 03, 2019 at 05:20:35PM +0100, Frediano Ziglio wrote: >> All generated file depends on generated_messages.h which is >> generated too. >> So add an explicit dependency from all generated file >> (except generated_messages.h generator) to g

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 5:19 AM, Frediano Ziglio wrote: >> >> Hi, >> >> On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: >>> spice-gtk and spice-server will use spice_common_client_dep >>> and spice_common_server_dep as dependencies. >>> However they will depend on both spice-common client/server

[Spice-devel] [PATCH spice-common] fixup! meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 78 +++--- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/common/meson.build b/common/meson.build index 2b7bef00..e5629af4 100644 --- a/common/meson.build +++ b/common/meson.bui

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Frediano Ziglio
> > On 4/4/19 5:19 AM, Frediano Ziglio wrote: > >> > >> Hi, > >> > >> On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: > >>> spice-gtk and spice-server will use spice_common_client_dep > >>> and spice_common_server_dep as dependencies. > >>> However they will depend on both spice-c

Re: [Spice-devel] [PATCH spice-common] fixup! meson: Fix dependency of generated files

2019-04-04 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > common/meson.build | 78 +++--- > 1 file changed, 39 insertions(+), 39 deletions(-) > > diff --git a/common/meson.build b/common/meson.build > index 2b7bef00..e5629af4 100644 > --- a/common/meson.build > +

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 11:50 AM, Frediano Ziglio wrote: >> >> On 4/4/19 5:19 AM, Frediano Ziglio wrote: Hi, On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: > spice-gtk and spice-server will use spice_common_client_dep > and spice_common_server_dep as dependencies. >>

[Spice-devel] [PATCH spice-common v3 1/3] meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
From: Frediano Ziglio All generated file depends on generated_messages.h which is generated too. So add an explicit dependency from all generated file (except generated_messages.h generator) to generated_messages.h generator. This fixes compiling SPICE server where generated_messages.h was not ge

[Spice-devel] [PATCH spice-common v3 0/3] Meson build fixes.

2019-04-04 Thread Eduardo Lima (Etrunko)
Following up on Frediano's patches for meson, I added another one to avoid using nested lists, by changing the list items to dictionaries. This is less error prone but adds the complexity of checking for the contents of output list. Regards, Eduardo. Eduardo Lima (Etrunko) (1): meson: Make tar

[Spice-devel] [PATCH spice-common v3 2/3] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
From: Frediano Ziglio spice-gtk and spice-server will use spice_common_client_dep and spice_common_server_dep as dependencies. However they will depend on both spice-common client/server libraries and their sources causing the sources to be compiled multiple times and causes linker errors on spic

[Spice-devel] [PATCH spice-common v3 3/3] meson: Make targets list store dictionaries instead of lists

2019-04-04 Thread Eduardo Lima (Etrunko)
Access the items by names instead of indexes. Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/common/meson.build b/common/meson.build index 980a32af..9a2725ff 100644 ---

Re: [Spice-devel] [PATCH spice-common v3 0/3] Meson build fixes.

2019-04-04 Thread Frediano Ziglio
> > Following up on Frediano's patches for meson, I added another one to > avoid using nested lists, by changing the list items to dictionaries. > This is less error prone but adds the complexity of checking for the > contents of output list. > > Regards, Eduardo. > > Eduardo Lima (Etrunko) (1)

[Spice-devel] [PATCH spice-gtk] spice-common: update submodule

2019-04-04 Thread Frediano Ziglio
This brings in the following changes: Christophe Fergeau (8): canvas_base: Fix variable shadowing warning backtrace: Add missing include lz: Don't try to print uninitialized variable build: Add missing G_GNUC_PRINTF annotations build: Update verify.h to latest version

Re: [Spice-devel] [PATCH spice-gtk] spice-common: update submodule

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 2:25 PM, Frediano Ziglio wrote: > This brings in the following changes: > > Christophe Fergeau (8): > canvas_base: Fix variable shadowing warning > backtrace: Add missing include > lz: Don't try to print uninitialized variable > build: Add missing G_GNUC_PRINTF an