Some typos/improves (just commit message)
> Subject: [PATCH spice-server 1/2] Fix compile warnings on Linux 32bit system
>
Better "Remove compile warnings ..."
> Based on a patch from Hongzhi.Song .
>
> There are following compile errors on Linux 32bit system with -Werror
> for gcc.
>
> red-c
ping
>
> Unused.
> Also the devices should be able to release themselves.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/char-device.h | 3 +--
> server/reds.c| 2 +-
> server/spicevmc.c| 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/server/char-devi
ping
>
> cursor_cache_items and palette_cache_items where only written
> but never used.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cache-item.tmpl.c | 3 ---
> server/cursor-channel-client.c | 1 -
> server/dcc-private.h | 1 -
> 3 files changed, 5 deletions(-)
>
> dif
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cache-item.tmpl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/server/cache-item.tmpl.c b/server/cache-item.tmpl.c
> index 6968d20db..f9418f990 100644
> --- a/server/cache-item.tmpl.c
> +++ b/server/cache-item.tmpl.c
> @@ -24
ping
>
> In some configuration _GNU_SOURCE is defined by the compiler
> and defining again cause a warning.
> Do not define again to avoid the warning.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/server/red-worker.c
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> server/inputs-channel-client.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/server/inputs-channel-client.h b/server/inputs-channel-client.h
> index c22288980..1afc22bd4 100644
> --- a/server/inputs-channel-client.h
> +++ b/server/in
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/red-channel.h b/server/red-channel.h
> index 4bfd81ee1..eb16bd4b8 100644
> --- a/server/red-channel.h
> +++ b/server/red-channel.h
> @@ -47,7 +47,6 @@ typedef str
ping
>
> ping the series
>
> >
> > Make sure we can build distribution.
> > Some small updates also to fix some minor issues.
> >
> > CI results at
> > https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/37744
> >
> > Frediano Ziglio (4):
> > ci: Test we can create a no dirty packag
ping 3
>
> ping
>
> >
> > ping
> >
> > >
> > > This structure is not declares as SPICE_ATTR_PACKED resulting it
> > > as aligned and no packed using GCC (no MingW).
> > > This structure is only packed under MingW or Microsoft compilers.
> > > This structure is not technically a definition for
ping 3
>
> ping
>
> >
> > ping
> >
> > >
> > > Do not declare the structure as aligned.
> > > The start/end-packed.h headers affects only MingW or Microsoft
> > > compilers. To have unaligned structure with GCC compiler you have
> > > to use SPICE_ATTR_PACKED. This way the definition are the
ping
>
> g_object_unref is directly used.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/char-device.c | 6 --
> server/char-device.h | 5 ++---
> 2 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/server/char-device.c b/server/char-device.c
> index 9ee255664..0f6a29d6f
ping
>
> The attributes in this case are not used to apply the mask.
> Doing so avoid sending garbage from the guest which usually
> don't initialise the memory in case the mask is missing.
> Guest should have cleared these bytes by its own however doing so
> on the server fixes the problem too.
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel-client.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/server/red-channel-client.c b/server/red-channel-client.c
> index 3fd51d78b..337733d5d 100644
> --- a/server/red-channel-client.c
> +++ b/server/red-channe
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> server/smartcard-channel-client.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/smartcard-channel-client.c
> b/server/smartcard-channel-client.c
> index e22b39adf..e462401e0 100644
> --- a/server/smartcard-
Make sure the project compile and pass tests without problems
on a 32 bit architecture.
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 22 ++
1 file changed, 22 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 91ee47edc..7ec5ce0f0 100644
--- a/.gitlab-ci
Based on a patch from Hongzhi.Song .
There are following compile errors on Linux 32bit system with -Werror
for gcc.
red-channel.c:207:73: error: format '%x' expects argument of type
'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
|207| red_channel_debug(self, "thread
schedule_frame() only pulls frames out of GStreamer's pipeline once all
previous decoded frames have been displayed. Thus when the video delay
is high a decoded frame may have to wait for several frame intervals
before get_decoded_frame() looks at it and computes its decoding time.
So attach decod
On Tue, 11 Jun 2019, Victor Toso wrote:
[...]
> > Thankfully the frame would usually be the last decoded frame
> > and would thus be displayed anyway.
>
> Have you found while reading the code or some other way? Just
> curious.
I'm working on the client-side stream lag and I occasionally had the
Hi,
On Tue, Jun 11, 2019 at 11:30:30AM +0200, Francois Gouget wrote:
> schedule_frame() was expecting to be called at least 1 ms
> before having to display the frame which is wrong: being called
> 0 ms before is acceptable too.
Indeed
> Thankfully the frame would usually be the last decoded fram
schedule_frame() was expecting to be called at least 1 ms before having
to display the frame which is wrong: being called 0 ms before is
acceptable too. Thankfully the frame would usually be the last decoded
frame and would thus be displayed anyway.
Also reverse the inequality to make it easier to
On 6/10/19 9:00 PM, Frediano Ziglio wrote:
On 6/5/19 6:18 AM, Hongzhi.Song wrote:
There are folowing compile errors on Linux 32bit system with -Werror
for gcc.
red-channel.c:207:73: error: format '%x' expects argument of type
'unsigned int', but argument 7 has type 'long unsigned int'
[-Werror
21 matches
Mail list logo
