Re: [Spice-devel] [spice-gtk 1/5] build: require minimal libusb version 1.0.21

2019-07-17 Thread Victor Toso
On Mon, Jul 15, 2019 at 10:21:54AM -0400, Frediano Ziglio wrote: > > > > > Previous commit ca641a5b92 uses libusb_interrupt_event_handler > > which requires newer version of libusb. > > > > Signed-off-by: Yuri Benditovich > > My fault. And mine, I acked but didn't check that ;) > According t

[Spice-devel] why does X11 SHM backend is not compatible with GTK3?

2019-07-17 Thread 谢 昆明
Why does it not compatible? 发送自 Windows 10 版邮件应用 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] Help needed with installing Spice Gtk and widget

2019-07-17 Thread Sagar cholakala
Hello there, I have been going at it non stop to no avail, for days now. I cant seem to get the spice-gtk installed and I don't know how either. I am fairly new to Linux and to add to that, I am trying all of this on Raspberry pi 4 to make it a thin client (where the raspbian

Re: [Spice-devel] [PATCH v2 spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-17 Thread Frediano Ziglio
> > From: test > > This allows to set plugin key=value properties on run time. > To add encoder plugin property use the following syntax: > -c gst.prop="property=value" -c gst.prop="property2=value2"... > Make sure syntax is accurate and that the property is supported by > the chosen plugin, wro

[Spice-devel] [PATCH v2 spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-17 Thread Snir Sheriber
From: test This allows to set plugin key=value properties on run time. To add encoder plugin property use the following syntax: -c gst.prop="property=value" -c gst.prop="property2=value2"... Make sure syntax is accurate and that the property is supported by the chosen plugin, wrong properties may

Re: [Spice-devel] [PATCH spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-17 Thread Frediano Ziglio
> Hi, > > > On 7/16/19 2:35 PM, Frediano Ziglio wrote: > >> This allows to set plugin key=value properties on run time. > >> To add encoder plugin property use the following syntax: > >> -gst.prop="key=value" > >> Make sure syntax is accurate and that the property is supported by > >> the chosen

[Spice-devel] [PATCH spice-server v3] ci: Workaround an issue with GLib on Fedora 30

2019-07-17 Thread Frediano Ziglio
This remove this error running test-listen test on a Fedora 30 docker image: (/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL **: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed This error is due to some missing configuration on the image. On a full

Re: [Spice-devel] [PATCH spice-server] ci: Workaround an issue with GLib on Fedora 30

2019-07-17 Thread Uri Lublin
On 7/17/19 12:46 PM, Frediano Ziglio wrote: This remove this error running test-listen test on a Fedora 30 docker image: (/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL **: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed This error is due to some

Re: [Spice-devel] [PATCH spice-server] websocket: Include proper type header

2019-07-17 Thread Uri Lublin
On 7/17/19 2:32 PM, Frediano Ziglio wrote: inttypes.h contains macro for format string while stdint.h more specifically contains type definitions (like uint8_t). Signed-off-by: Frediano Ziglio Ack :) --- server/websocket.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Spice-devel] [PATCH spice-server] reds: Fix use-after-free

2019-07-17 Thread Uri Lublin
On 7/17/19 1:41 PM, Frediano Ziglio wrote: video_codecs can be freed so use it before. Signed-off-by: Frediano Ziglio Ack. I had a similar patch, you sent your faster :) Uri. --- server/reds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/s

[Spice-devel] [PATCH spice-server v2] ci: Workaround an issue with GLib on Fedora 30

2019-07-17 Thread Frediano Ziglio
This remove this error running test-listen test on a Fedora 30 docker image: (/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL **: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed This error is due to some missing configuration on the image. On a full

[Spice-devel] [PATCH spice-server] websocket: Include proper type header

2019-07-17 Thread Frediano Ziglio
inttypes.h contains macro for format string while stdint.h more specifically contains type definitions (like uint8_t). Signed-off-by: Frediano Ziglio --- server/websocket.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/websocket.h b/server/websocket.h index ec452038b

[Spice-devel] [PATCH spice-server] reds: Fix use-after-free

2019-07-17 Thread Frediano Ziglio
video_codecs can be freed so use it before. Signed-off-by: Frediano Ziglio --- server/reds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 817fdd423..78bbe5a0f 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3851,6 +3851,10 @@

[Spice-devel] [PATCH spice-server 2/2] test-websocket: Reuse red_socket_set_non_blocking

2019-07-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/tests/test-websocket.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/server/tests/test-websocket.c b/server/tests/test-websocket.c index e74cb5497..432aeee5c 100644 --- a/server/tests/test-websocket.c +++ b/server/te

[Spice-devel] [PATCH spice-server 1/2] test-websocket: Some Windows compatibility

2019-07-17 Thread Frediano Ziglio
Don't call close but socket_close. Signed-off-by: Frediano Ziglio --- server/tests/test-websocket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Currently the executable cannot run on Windows but it does not hurt to make the source more compatible with that system. diff --git a/se

[Spice-devel] [PATCH spice-server] ci: Workaround an issue with GLib on Fedora 30

2019-07-17 Thread Frediano Ziglio
This remove this error running test-listen test on a Fedora 30 docker image: (/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL **: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed This error is due to some missing configuration on the image. On a full

Re: [Spice-devel] [PATCH v3 2/3] drm: plumb attaching dev thru to prime_pin/unpin

2019-07-17 Thread Koenig, Christian
Am 16.07.19 um 23:37 schrieb Rob Clark: > From: Rob Clark > > Needed in the following patch for cache operations. Well have you seen that those callbacks are deprecated? >* Deprecated hook in favour of &drm_gem_object_funcs.pin. >* Deprecated hook in favour of &drm_gem_object_fun

[Spice-devel] [PATCH v3 2/3] drm: plumb attaching dev thru to prime_pin/unpin

2019-07-17 Thread Rob Clark
From: Rob Clark Needed in the following patch for cache operations. Signed-off-by: Rob Clark --- v3: rebased on drm-tip drivers/gpu/drm/drm_gem.c | 8 drivers/gpu/drm/drm_internal.h | 4 ++-- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers

[Spice-devel] [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin

2019-07-17 Thread Rob Clark
From: Rob Clark Needed in the following patch for cache operations. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_gem.c | 10 ++ drivers/gpu/drm/drm_gem_vram_helper.c | 6 -- drivers/gpu/drm/drm_prime.c | 4 ++-- drivers/gpu/drm/etnaviv/

Re: [Spice-devel] [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin

2019-07-17 Thread Chris Wilson
Quoting Rob Clark (2019-07-16 18:43:22) > From: Rob Clark > > Needed in the following patch for cache operations. What's the base for this patch? (I'm missing the ancestor for drm_gem.c) -Chris ___ Spice-devel mailing list Spice-devel@lists.freedesktop

Re: [Spice-devel] [PATCH spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-17 Thread Snir Sheriber
Hi, On 7/16/19 2:35 PM, Frediano Ziglio wrote: This allows to set plugin key=value properties on run time. To add encoder plugin property use the following syntax: -gst.prop="key=value" Make sure syntax is accurate and that the property is supported by the chosen plugin, wrong/invalid propertie