Re: [Spice-devel] [spice-gtk 2/9] usb-redir: device error signal without device object

Hi, On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote: > On Thu, Jul 25, 2019 at 8:46 PM Frediano Ziglio wrote: > > > > > > @@ -1440,6 +1446,10 @@ gchar > > > > > > *spice_usb_device_get_description(SpiceUsbDevice > > > > > > *device, const gchar *for > > > > > > > > > > > > g

Re: [Spice-devel] [PATCH v3 fixup1 x11spice 2/3] Simplify the expression of argument parsing.

> > This fixes a bug with --config=handling. > > Removed old testing code as obsolete instead of updating unused code. > > Signed-off-by: Jeremy White Acked the series Frediano > --- > v2: Simplify even further. > v3: Add a commit message about the removal of unused code, do not group >

Re: [Spice-devel] [spice-gtk 1/9] usb-redir: define interfaces to support emulated devices

> > On Thu, Jul 25, 2019 at 11:57 AM Frediano Ziglio wrote: > > > > > > > > SpiceUsbBackendDevice structure is extended to support > > > additional kind of device that is emulated by Spice-GTK > > > and not present locally (and does not have libusb_device), > > > such device has instead pointer t

Re: [Spice-devel] [spice-gtk 5/9] usb-redir: do not use spice_usb_acl_helper for emulated devices

> On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio wrote: > > > > > > > > Signed-off-by: Yuri Benditovich > > > --- > > > src/channel-usbredir.c | 29 ++--- > > > 1 file changed, 14 insertions(+), 15 deletions(-) > > > > > > diff --git a/src/channel-usbredir.c b/src/chann

Re: [Spice-devel] [spice-gtk 5/9] usb-redir: do not use spice_usb_acl_helper for emulated devices

On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote: > > > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio wrote: > > > > > > > > > > > Signed-off-by: Yuri Benditovich > > > > --- > > > > src/channel-usbredir.c | 29 ++--- > > > > 1 file changed, 14 insertions(+), 15

[Spice-devel] [PATCH spice-gtk v3 0/6] Client-side video stream lag reduction

Just rebased on master. Original comment from the author (Francois Gouget): The series main goal is to reduce the video stream lag. Currently the server sets the client's mmtime offset which is the source of the video stream lag. But as was discussed before this offset is entangled with the avail

[Spice-devel] [PATCH spice-gtk v3 1/6] channel-display: Minimize the stream lag by ignoring the server one

From: Francois Gouget The client is in a better position than the server to pick the minimum lag needed to compensate for frame arrival time jitter and ensure smooth video playback. To do so: - It ignores the lag specified by the server through the mmtime clock adjustments (but this lag is stil

[Spice-devel] [PATCH spice-gtk v3 3/6] channel-display: No need to rechedule on mmtime offset changes

From: Francois Gouget The frame display time is no longer based on the mmtime clock and thus is not impacted by mmtime offset changes. Signed-off-by: Francois Gouget --- src/channel-display-gst.c | 21 - src/channel-display-mjpeg.c | 13 src/channel-display-priv.h | 3

[Spice-devel] [PATCH spice-gtk v3 2/6] playback: Use the audio timestamps for the global mmtime conversion

From: Francois Gouget More data helps improve the accuracy of the estimation of the true clock offset and minimum network latency. Signed-off-by: Francois Gouget --- src/channel-playback.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/channel-playback.c b/

[Spice-devel] [PATCH spice-gtk v3 6/6] mjpeg: Take the decoding time into account to display frames

From: Francois Gouget Signed-off-by: Francois Gouget --- src/channel-display-mjpeg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/channel-display-mjpeg.c b/src/channel-display-mjpeg.c index 20e10d9b..764f0611 100644 --- a/src/channel-display-mjpeg.c +++ b/src/channel-display-mjpeg

[Spice-devel] [PATCH spice-gtk v3 4/6] channel-display: Remove playback_sync_drops_seq_len

From: Francois Gouget display_handle_stream_data() now has its own mechanism to avoid dropping frames which does not depend on the playback latency. Signed-off-by: Francois Gouget --- src/channel-display-priv.h | 2 -- src/channel-display.c | 8 src/channel-playback-priv.h |

[Spice-devel] [PATCH spice-gtk v3 5/6] spice-session: Keep track of the global streams lag

From: Francois Gouget Each video and audio stream has its own lag: for video streams it is the decoding time and for audio ones buffering by the audio subsystem. The only way to keep them all in sync is to synchronize to the most laggy stream. Signed-off-by: Francois Gouget --- src/channel-dis

Re: [Spice-devel] [spice-gtk 5/9] usb-redir: do not use spice_usb_acl_helper for emulated devices

> On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote: > > > > > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio > > > wrote: > > > > > > > > > > > > > > Signed-off-by: Yuri Benditovich > > > > > --- > > > > > src/channel-usbredir.c | 29 ++--- > > > > > 1 file chang

[Spice-devel] [PATCH spice-gtk] usb-device-manager: Remove useless cast

spice_usb_device_new is already returning a SpiceUsbDevice pointer. Signed-off-by: Frediano Ziglio --- src/usb-device-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index a530be9e..544e5687 100644 --- a/src/usb-de

Re: [Spice-devel] [PATCH spice-server 04/13] spicevmc: Remove reds parameter from spicevmc_device_disconnect

ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > Unused. > > > > > > Also the devices should be able to release themselves. > > > > > > > > > > > > Signed-off-by: Frediano Ziglio > > > > > >

Re: [Spice-devel] [PATCH spice-server 12/13] red-channel-client: Reduce indentation of some code

ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > Just a style change, return earlier to avoid some indentation. > > > > > > > > > > Signed-off-by: Frediano Ziglio > > > > > --- > > > > > server/red-channel-client.c | 37 > > > > >

Re: [Spice-devel] [PATCH spice-server 05/13] red-worker: Remove warning

ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > In some configuration _GNU_SOURCE is defined by the compiler > > > > > > and defining again cause a warning. > > > > > > Do not define again to

Re: [Spice-devel] [PATCH spice-server 13/13] red-channel-client: Add some comment on the flush code

ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > Signed-off-by: Frediano Ziglio > > > > > > --- > > > > > > server/red-channel-client.c | 6 ++ > > > > > > 1 file changed, 6 insertions(+

Re: [Spice-devel] [PATCH spice-server v2] char-device: Remove unused red_char_device_destroy function

ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > > > > g_object_unref is directly used. > > > > > > > > > > > > > > Signed-off-by: Frediano Ziglio >

Re: [Spice-devel] [spice-gtk 1/9] usb-redir: define interfaces to support emulated devices

On Fri, Jul 26, 2019 at 11:43 AM Frediano Ziglio wrote: > > > > > On Thu, Jul 25, 2019 at 11:57 AM Frediano Ziglio wrote: > > > > > > > > > > > SpiceUsbBackendDevice structure is extended to support > > > > additional kind of device that is emulated by Spice-GTK > > > > and not present locally (a

Re: [Spice-devel] [spice-gtk 5/9] usb-redir: do not use spice_usb_acl_helper for emulated devices

On Fri, Jul 26, 2019 at 1:02 PM Frediano Ziglio wrote: > > > On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote: > > > > > > > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio > > > > wrote: > > > > > > > > > > > > > > > > > Signed-off-by: Yuri Benditovich > > > > > > --- > > > > > > src/c

Re: [Spice-devel] [spice-gtk 2/9] usb-redir: device error signal without device object

On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote: > > Hi, > > On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote: > > On Thu, Jul 25, 2019 at 8:46 PM Frediano Ziglio wrote: > > > > > > > @@ -1440,6 +1446,10 @@ gchar > > > > > > > *spice_usb_device_get_description(SpiceUsbDevice >

Re: [Spice-devel] [spice-gtk 2/9] usb-redir: device error signal without device object

> > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote: > > > > Hi, > > > > On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote: > > > On Thu, Jul 25, 2019 at 8:46 PM Frediano Ziglio > > > wrote: > > > > > > > > @@ -1440,6 +1446,10 @@ gchar > > > > > > > > *spice_usb_device_get_desc

Re: [Spice-devel] [spice-gtk 9/9] usb-redir: enable redirection of emulated CD drive

> > Register constructor for emulated CD device. Now creation > of CD devices at startup is possible. > > Signed-off-by: Yuri Benditovich > --- > src/meson.build | 6 ++ > src/usb-backend.c | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/src/meson.build b/src/meson.build > ind

Re: [Spice-devel] [spice-gtk 1/9] usb-redir: define interfaces to support emulated devices

> On Fri, Jul 26, 2019 at 11:43 AM Frediano Ziglio wrote: > > > > > > > > On Thu, Jul 25, 2019 at 11:57 AM Frediano Ziglio > > > wrote: > > > > > > > > > > > > > > SpiceUsbBackendDevice structure is extended to support > > > > > additional kind of device that is emulated by Spice-GTK > > > > > an

[Spice-devel] [PATCH 1/2] Removed only written system_config_file field

Signed-off-by: Frediano Ziglio --- src/options.c | 3 +-- src/options.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/options.c b/src/options.c index c7c75a8..a6c7b9e 100644 --- a/src/options.c +++ b/src/options.c @@ -80,7 +80,6 @@ void options_free(options_t *options)

[Spice-devel] [PATCH 2/2] Add a test for options

Signed-off-by: Frediano Ziglio --- .gitignore | 1 + configure.ac | 2 +- src/tests/Makefile.am| 5 +++ src/tests/options_test.c | 93 4 files changed, 100 insertions(+), 1 deletion(-) create mode 100644 src/tests/options_

[Spice-devel] [PATCH spice-gtk 2/2] fixup! usb-redir: define interfaces to support emulated devices

Remove unneeded address field from UsbCreateDeviceParameters --- src/usb-backend.c | 1 - src/usb-backend.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/usb-backend.c b/src/usb-backend.c index 9c2605a0..e47bca35 100644 --- a/src/usb-backend.c +++ b/src/usb-backend.c @@ -914,7 +914,6 @

[Spice-devel] [PATCH spice-gtk 1/2] fixup! usb-redir: define interfaces to support emulated devices

Initialise SpiceUsbBackendDevice fields earlier Allows to use spice_usb_backend_device_unref and read some information directly from the device. --- src/usb-backend.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/usb-backend.c b/src/usb-backend.c index 0b

Re: [Spice-devel] [PATCH 1/2] Removed only written system_config_file field

On 7/26/19 9:28 AM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio For series: Acked-by: Jeremy White --- src/options.c | 3 +-- src/options.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/options.c b/src/options.c index c7c75a8..a6c7b9e 100644 --- a/sr

Re: [Spice-devel] [spice-gtk 9/9] usb-redir: enable redirection of emulated CD drive

On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote: > > > > > Register constructor for emulated CD device. Now creation > > of CD devices at startup is possible. > > > > Signed-off-by: Yuri Benditovich > > --- > > src/meson.build | 6 ++ > > src/usb-backend.c | 1 + > > 2 files changed,

Re: [Spice-devel] [spice-gtk 2/9] usb-redir: device error signal without device object

On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote: > > > > > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote: > > > > > > Hi, > > > > > > On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote: > > > > On Thu, Jul 25, 2019 at 8:46 PM Frediano Ziglio > > > > wrote: > > > > > > >

Re: [Spice-devel] [spice-gtk 9/9] usb-redir: enable redirection of emulated CD drive

> On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote: > > > > > > > > Register constructor for emulated CD device. Now creation > > > of CD devices at startup is possible. > > > > > > Signed-off-by: Yuri Benditovich > > > --- > > > src/meson.build | 6 ++ > > > src/usb-backend.c | 1 + >

Re: [Spice-devel] [spice-gtk 2/9] usb-redir: device error signal without device object

Hi, On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote: > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote: > > > > > > > > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso > > > wrote: > > > > > > > > Hi, > > > > > > > > On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich

Re: [Spice-devel] [spice-gtk 9/9] usb-redir: enable redirection of emulated CD drive

On Fri, Jul 26, 2019 at 6:51 PM Frediano Ziglio wrote: > > > On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote: > > > > > > > > > > > Register constructor for emulated CD device. Now creation > > > > of CD devices at startup is possible. > > > > > > > > Signed-off-by: Yuri Benditovich > > >

Re: [Spice-devel] [spice-gtk 2/9] usb-redir: device error signal without device object

On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote: > > Hi, > > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote: > > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote: > > > > > > > > > > > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso > > > > wrote: > > > > > > > > > > Hi, >