Hi Brendan,
I've been running with this code for a while, and it works nicely. It's
hard to quantify, but with my test case I get cache hit rates in the 90%
range, and it does seem to improve overall performance.
I've got two comments on the patch, inline below:
On 7/16/19 9:16 PM, Brendan
On Mon, Jul 29, 2019 at 6:32 PM Frediano Ziglio wrote:
>
> >
> > On Mon, Jul 29, 2019 at 3:34 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > But this was always possible to print the error.
> > >
> > > No... I don't print the error, is up to the caller.
> >
> > But you're also the caller (in spi
>
> On Mon, Jul 29, 2019 at 3:34 PM Frediano Ziglio wrote:
> >
> > >
> > > But this was always possible to print the error.
> >
> > No... I don't print the error, is up to the caller.
>
> But you're also the caller (in spice-options), aren't you?
> The difference is that what I suggested comes t
Actually I found something I'm a bit unhappy with in this patch.
So one goal is to make sure all streams are in sync. This is why the
mmtime conversion is performed globally: if two frames from different
streams have the same mmtime, the resulting client-side timestamps
should be identical too
Guards currently are quite different in format.
Unify updating to "#pragma once" syntax. This syntax is used
by GTK tools too.
To avoid possible regression public headers are left untouched.
Signed-off-by: Frediano Ziglio
---
src/bio-gio.h | 5 +
src/channel-display-pri
On Mon, Jul 29, 2019 at 3:34 PM Frediano Ziglio wrote:
>
> >
> > But this was always possible to print the error.
>
> No... I don't print the error, is up to the caller.
But you're also the caller (in spice-options), aren't you?
The difference is that what I suggested comes to existing signal set
>
> But this was always possible to print the error.
No... I don't print the error, is up to the caller.
> IMO, the point is to raise it to remote-viewer GUI.
If is a GUI the fprintf will be replaced by a MessageBox
or similar, isn't it?
> And this is simple with fake device and complicated ot
But this was always possible to print the error.
IMO, the point is to raise it to remote-viewer GUI.
And this is simple with fake device and complicated other way.
On Mon, Jul 29, 2019 at 2:14 PM Frediano Ziglio wrote:
>
> > On Mon, Jul 29, 2019 at 12:27 PM Frediano Ziglio wrote:
> > >
> > > > O
> On Mon, Jul 29, 2019 at 12:27 PM Frediano Ziglio wrote:
> >
> > > On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso
> > > > > wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > On Fri, Jul 26, 2019 at 0
On Mon, Jul 29, 2019 at 12:27 PM Frediano Ziglio wrote:
>
> > On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio wrote:
> > >
> > > >
> > > > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso
> > > > wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Bendit
> On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio wrote:
> >
> > >
> > > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > > > > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio
> > >
On Mon, Jul 29, 2019 at 11:03 AM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 26, 2019 at 4:54 PM Frediano Ziglio wrote:
> > >
> > > > On Fri, Jul 26, 2019 at 11:43 AM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > >
> > > > > > On Thu, Jul 25, 2019 at 11:57 AM Frediano Ziglio
> > > > > >
On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > > > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio
> > > > wrote:
> > > > >
> >
>
> On Fri, Jul 26, 2019 at 4:54 PM Frediano Ziglio wrote:
> >
> > > On Fri, Jul 26, 2019 at 11:43 AM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > On Thu, Jul 25, 2019 at 11:57 AM Frediano Ziglio
> > > > > wrote:
> > > > > >
> > > > > > >
> > > > > > > SpiceUsbBackendDevice structur
>
> On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso
> > > > > wrot
15 matches
Mail list logo
