[Spice-devel] [PATCH v2 x11spice 2/2] Provide compatibility for Glamor in Xorg 1.17.

2019-07-31 Thread Jeremy White
In Xorg 1.18, X changed so that GLAMOR_USE_EGL_SCREEN was the only flag required and it implies the behavior previously requested with the GLAMOR_USE_SCREEN and GLAMORE_USE_PICTURE_SCREEN flags. Thus, if we are building against an older Xorg, we need to specify those now deprecated flags.

Re: [Spice-devel] [PATCH x11spice 2/2] Including missing header for inlined clock functions.

2019-07-31 Thread Frediano Ziglio
> > Fixes compilation on RHEL 7.3. > > Signed-off-by: Jeremy White Acked > --- > spice-video-dummy/src/dummy.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h > index af77c177..cb8afc37 100644 > ---

Re: [Spice-devel] [PATCH x11spice 1/2] Provide compatibility for Glamor in Xorg 1.17.

2019-07-31 Thread Frediano Ziglio
> > Signed-off-by: Jeremy White > --- > spice-video-dummy/src/dummy.h | 4 ++-- > spice-video-dummy/src/spicedummy_driver.c | 11 ++- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h > index

[Spice-devel] [PATCH x11spice 1/2] Provide compatibility for Glamor in Xorg 1.17.

2019-07-31 Thread Jeremy White
Signed-off-by: Jeremy White --- spice-video-dummy/src/dummy.h | 4 ++-- spice-video-dummy/src/spicedummy_driver.c | 11 ++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h index a2502902..af77c177

[Spice-devel] [PATCH x11spice 2/2] Including missing header for inlined clock functions.

2019-07-31 Thread Jeremy White
Fixes compilation on RHEL 7.3. Signed-off-by: Jeremy White --- spice-video-dummy/src/dummy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h index af77c177..cb8afc37 100644 --- a/spice-video-dummy/src/dummy.h +++

Re: [Spice-devel] [PATCH spice-server v3] red-parse-qxl: Fix QUIC images from QXL

2019-07-31 Thread Uri Lublin
On 7/31/19 6:13 PM, Frediano Ziglio wrote: The decoding is wrong, the Red and QXL structures are different so code is not doing what is expected. red-parse-qxl translate from QXL to Red structures, red-record-qxl saves Red structure to file, red-replay-qxl is supposed to read from file into QXL

Re: [Spice-devel] [PATCH spice-server v2] red-parse-qxl: Fix QUIC images from QXL

2019-07-31 Thread Uri Lublin
On 7/24/19 2:37 PM, Frediano Ziglio wrote: Hi Frediano, On 7/23/19 11:21 PM, Frediano Ziglio wrote: The decoding is wrong, the Red and QXL structures are different so code is not doing what is expected. red-parse-qxl translate from QXL to Red structures, red-record-qxl saves Red structure to

[Spice-devel] [PATCH spice-server v3] red-parse-qxl: Fix QUIC images from QXL

2019-07-31 Thread Frediano Ziglio
The decoding is wrong, the Red and QXL structures are different so code is not doing what is expected. red-parse-qxl translate from QXL to Red structures, red-record-qxl saves Red structure to file, red-replay-qxl is supposed to read from file into QXL directly. If a Quic image is stored inside

Re: [Spice-devel] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-07-31 Thread Christophe de Dinechin
Kevin Pouget writes: > On Wed, Jul 31, 2019 at 11:59 AM Christophe de Dinechin > wrote: >> >> I don't really like the way option parsing is implemented, because I >> think it leads to somewhat counter-intuitive user behaviors. >> >> For example, if I say: >> >> gst.codec=mjpeg

Re: [Spice-devel] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-07-31 Thread Kevin Pouget
On Wed, Jul 31, 2019 at 11:59 AM Christophe de Dinechin wrote: > > I don't really like the way option parsing is implemented, because I > think it leads to somewhat counter-intuitive user behaviors. > > For example, if I say: > > gst.codec=mjpeg gst.codec=h264 framerate=20 > > I get two

Re: [Spice-devel] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-07-31 Thread Kevin Pouget
On Wed, Jul 31, 2019 at 11:50 AM Frediano Ziglio wrote: > > > > > With this patch, spice-streaming-agent can be launched with multiple > > Gstreamer video codecs enabled: > > > > > spice-streaming-agent -c gst.codec=vp8 -c gst.codec=vp9 ... > > --- > > src/gst-plugin.cpp | 50

Re: [Spice-devel] [spice-list] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-07-31 Thread Christophe de Dinechin
I don't really like the way option parsing is implemented, because I think it leads to somewhat counter-intuitive user behaviors. For example, if I say: gst.codec=mjpeg gst.codec=h264 framerate=20 I get two plugins with framerate=20, but if I have gst.codec=mjpeg framerate=20

Re: [Spice-devel] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-07-31 Thread Frediano Ziglio
> > With this patch, spice-streaming-agent can be launched with multiple > Gstreamer video codecs enabled: > > > spice-streaming-agent -c gst.codec=vp8 -c gst.codec=vp9 ... > --- > src/gst-plugin.cpp | 50 -- > 1 file changed, 31 insertions(+), 19

Re: [Spice-devel] [PATCH spice-gtk] spice-file-xfer-task: unref properties on dispose

2019-07-31 Thread Frediano Ziglio
> > When the construction properties are set, the objects are > referenced by g_value_dup_object(), so they should be unref > once the task is done. > > If the main channel stays referenced, spice session fails > to disconnect and the viewer does not close. > > Signed-off-by: Jakub Janků

Re: [Spice-devel] [spice-list] [RFC spice-streaming-agent 2/2] spice-streaming-agent: fully reset the capture loop on start/stop requests

2019-07-31 Thread Christophe de Dinechin
Kevin Pouget writes: > With this patch, spice-streaming-agent exits the frame-sending loop > when START/STOP requests are received. This allows the recomputation > of the most suitable capture/encoding plugin, that may have been > updated with START/STOP message. > --- >

[Spice-devel] [PATCH spice-gtk] spice-file-xfer-task: unref properties on dispose

2019-07-31 Thread Jakub Janků
When the construction properties are set, the objects are referenced by g_value_dup_object(), so they should be unref once the task is done. If the main channel stays referenced, spice session fails to disconnect and the viewer does not close. Signed-off-by: Jakub Janků --- Hi, it seems a bit

[Spice-devel] [RFC spice-gtk 1/1] spice-widget: make draw-area visible on update_image

2019-07-31 Thread Kevin Pouget
When switching from a Gstreamer video stream (on the gst-area) to an mjpeg stream, the "draw-area" was not set as visible. During the mjpeg->gst switch, the problem does not happen, as the gstreamer overlay is already re-created and made visible. This patch makes the draw-area always visible on

[Spice-devel] [RFC spice-streaming-agent 2/2] spice-streaming-agent: fully reset the capture loop on start/stop requests

2019-07-31 Thread Kevin Pouget
With this patch, spice-streaming-agent exits the frame-sending loop when START/STOP requests are received. This allows the recomputation of the most suitable capture/encoding plugin, that may have been updated with START/STOP message. --- src/spice-streaming-agent.cpp | 9 +++-- 1 file

[Spice-devel] [RFC spice-server 1/1] streaming: Restart guest video streams on video-codec changes

2019-07-31 Thread Kevin Pouget
This patch resets (stream_channel_reset) the guest video streams when the the user changes the preferred video-codecs or when the host admin updates the list of video-codecs allowed. See also patch 4000846c0157a787b786a9bf7f36f0b6a73dfbf8 for the host streaming counter part. --- server/dcc.c

[Spice-devel] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-07-31 Thread Kevin Pouget
With this patch, spice-streaming-agent can be launched with multiple Gstreamer video codecs enabled: > spice-streaming-agent -c gst.codec=vp8 -c gst.codec=vp9 ... --- src/gst-plugin.cpp | 50 -- 1 file changed, 31 insertions(+), 19 deletions(-) diff

[Spice-devel] [RFC] Allow guest-video codec hot-swap

2019-07-31 Thread Kevin Pouget
Hello, this is the first version of the patch series that allows hot-swapping the codec used for guest video streaming. * in spice-server, the behavior is similar to what I did for host-side video streaming: when the user (through the client) or the admin (through the QMP interface) changes

Re: [Spice-devel] [PATCH spice-gtk 1/2] build: Remove obsolete comments referring to Autotools

2019-07-31 Thread Christophe de Dinechin
Frediano Ziglio writes: > Autotools support were removed by commit > 9837f974cc32185f3bdb1d4102fd5b65607c3e02 ("Drop autotools"). > > Signed-off-by: Frediano Ziglio > --- > src/meson.build | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/meson.build b/src/meson.build > index

[Spice-devel] [PATCH spice-gtk 2/2] build: Replace "join_paths" with "/" operator

2019-07-31 Thread Frediano Ziglio
Supported by Meson 0.49. New syntax is shorter. Signed-off-by: Frediano Ziglio --- doc/reference/meson.build | 18 +- man/meson.build | 2 +- meson.build | 8 src/meson.build | 10 +- vapi/meson.build | 2 +- 5 files

[Spice-devel] [PATCH spice-gtk 1/2] build: Remove obsolete comments referring to Autotools

2019-07-31 Thread Frediano Ziglio
Autotools support were removed by commit 9837f974cc32185f3bdb1d4102fd5b65607c3e02 ("Drop autotools"). Signed-off-by: Frediano Ziglio --- src/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/meson.build b/src/meson.build index 4bab087d..a0bdbc2a 100644 --- a/src/meson.build