[Spice-devel] [spice-gtk v2 3/8] usb-redir: do not use spice_usb_acl_helper for emulated devices

2019-08-04 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- src/channel-usbredir.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index 8d4cd66..8fd6b41 100644 --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c

[Spice-devel] [spice-gtk v2 6/8] usb-redir: add implementation of emulated CD device

2019-08-04 Thread Yuri Benditovich
This module contains implementation of emulated device interface for shared CD. Signed-off-by: Yuri Benditovich --- src/usb-device-cd.c | 790 src/usb-device-cd.h | 37 +++ 2 files changed, 827 insertions(+) create mode 100644 src/usb-device-cd.c c

[Spice-devel] [spice-gtk v2 7/8] usb-redir: enable redirection of emulated CD drive

2019-08-04 Thread Yuri Benditovich
Add implementation of emulated device to build. Now it is possible to create emulated CD devices. Signed-off-by: Yuri Benditovich --- src/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/meson.build b/src/meson.build index fe19c16..3837a9d 100644 --- a/src/meson.build +

[Spice-devel] [spice-gtk v2 1/8] usb-redir: define interfaces to support emulated devices

2019-08-04 Thread Yuri Benditovich
SpiceUsbBackendDevice structure is extended to support additional kind of device that is emulated by Spice-GTK and not present locally (and does not have libusb_device), such device has instead pointer to SpiceUsbEmulatedDevice abstract structure. Specific implementation of such device depends on i

[Spice-devel] [spice-gtk v2 4/8] usb-redir: extend USB backend to support emulated devices

2019-08-04 Thread Yuri Benditovich
Redirection of emulated devices requires special approach, as usbredirhost can't be used for that (it works only with libusb devices). For emulated devices we create instance of usbredirparser that implements USB redirection protocol. In order to work with the same set of protocol capabilities that

[Spice-devel] [spice-gtk v2 2/8] usb-redir: move implementation of device description to USB backend

2019-08-04 Thread Yuri Benditovich
For local USB device the USB backend returns the same device description as spice-usb-manager did, for emulated devices it uses the description provided by device's implementation. Signed-off-by: Yuri Benditovich --- src/usb-backend.c| 41 src/usb

[Spice-devel] [spice-gtk v2 0/8] added feature of sharing CD image

2019-08-04 Thread Yuri Benditovich
This series of patches adds feature of sharing CD image via redirection of emulated CD device. Currently the trigger to create the device is command-line option: '--spice-share-cd Changes from v1: fixes resulted by reviews (mainly based on fixups of Frediano Ziglio) Yuri Benditovich (8): usb-r

[Spice-devel] [spice-gtk v2 8/8] usb-redir: command-line option to create emulated CD drive

2019-08-04 Thread Yuri Benditovich
Added command-line option for sharing emulated CD devices. It uses property interface of usb-device-manager to create CD, this is a temporary solution until public API of usb-device-manager defined for shared CD management from both GUI and command line. Signed-off-by: Yuri Benditovich --- src/s

Re: [Spice-devel] [RFC spice-streaming-agent 1/2] gst-plugin: allow the instantiation of multiple GST encoder plugins

2019-08-04 Thread Snir Sheriber
HI, On 8/1/19 6:27 PM, Kevin Pouget wrote: Hello Snir, On Thu, Aug 1, 2019 at 5:02 PM Snir Sheriber wrote: Hi, On 8/1/19 3:43 PM, Kevin Pouget wrote: On Wed, Jul 31, 2019 at 12:09 PM Kevin Pouget wrote: On Wed, Jul 31, 2019 at 11:50 AM Frediano Ziglio wrote: With this patch, spice-stre

Re: [Spice-devel] [PATCH spice-streaming-agent 4/4] gst-plugin: reduce number of templates being used

2019-08-04 Thread Snir Sheriber
On 8/1/19 7:17 PM, Frediano Ziglio wrote: --- This patch is not really necessary, just a suggestion, it's a bit hacky but would save some code. Other options would be to use explicit template specialization or to leave it as is. Sure, what I don't like is that is surely not type safe, you can

Re: [Spice-devel] [PATCH spice-streaming-agent 1/4] gst-plugin: Allow ANY memory type to pass from convertor to encoder

2019-08-04 Thread Snir Sheriber
On 8/1/19 6:30 PM, Frediano Ziglio wrote: Looks fine. But what are the difference? For instance what additional memory types we want to feed to the pipeline? For example VASurface for vaapi based plugins Snir --- src/gst-plugin.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Spice-devel] [PATCH spice-streaming-agent 3/4] gst-plugin: Free input buffer and XImage as soon as possible

2019-08-04 Thread Snir Sheriber
Hi, On 8/1/19 6:39 PM, Frediano Ziglio wrote: --- src/gst-plugin.cpp | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp index 0a1d041..c7412c5 100644 --- a/src/gst-plugin.cpp +++ b/src/gst-plugin.cpp @