The 'display->fullscreen' SHM segment was previously being used for both
x11spice's internal change scanning and as the spice primary surface.
I don't think spice wants anything else writing to the primary surface,
and this caused sporadic test failures and graphical corruption.
Create a separate
Signed-off-by: Kevin Pouget
---
src/gst-plugin.cpp | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 5469647..657b62d 100644
--- a/src/gst-plugin.cpp
+++ b/src/gst-plugin.cpp
@@ -102,7 +102,8 @@ class
With this patch, spice-streaming-agent can be launched with multiple
Gstreamer video codecs enabled:
> spice-streaming-agent -c gst.codec=vp8 -c gst.codec=vp9 ...
Signed-off-by: Kevin Pouget
---
src/gst-plugin.cpp | 50 --
1 file changed, 31
The transfer between the codecs array and the message payload cannot
be done with memcpy because the data-type lengths are different
(gint/uint8_t).
Signed-off-by: Kevin Pouget
---
src/channel-display.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
With this patch, spice-streaming-agent exits the frame-sending loop
when START/STOP requests are received. This allows the recomputation
of the most suitable capture/encoding plugin, that may have been
updated with START/STOP message.
Signed-off-by: Kevin Pouget
---
This patch computes and sends the list of the video codecs preferred
by all the clients when requesting to start or reset a video stream.
It used to be the list of the supported codecs.
The MJPEG codec is used as a fallback if there is no codec preferred
by all the clients.
Note: at the moment,
This is a new version of the patch series on guest video codec hot
swapping.
A few TODO remain open/to be discussed, in particular:
- in the client, what is the proper way to fix the visible area issue
- allowing the host admin to control which codec can be used for guest
streaming
- in the
When switching from a Gstreamer video stream (on the gst-area) to an
mjpeg stream, the "draw-area" was not set as visible. During the
mjpeg->gst switch, the problem does not happen, as the gstreamer
overlay is already re-created and made visible.
This patch makes the draw-area always visible on
This patch resets the host and guest video streams when the client
changes the preferred video-codecs or when the host admin updates the
list of video-codecs allowed.
TODO: restart only the streams of the client that changed codecs
Signed-off-by: Kevin Pouget
---
server/main-dispatcher.c |
This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE
capability for the stream-channel.
video_stream_parse_preferred_codecs: new function for parsing the
SPICE protocol message. This code used to be inside
dcc_handle_preferred_video_codec_type.
struct
This patch gives more priority to the requested video codecs when
selecting the FrameCapture plugin, instead of its hard-coded rank.
The client_codecs storage structure is changed from 'set' to 'vector',
as the codec order is not preserved by the set structure..
Signed-off-by: Kevin Pouget
---
Allow to modify/cancel timers/watches without having to retrieve
the code interface.
This will make sure that you are not using the wrong interface.
Simplify code to deal with timers/watches.
Remove the requirement to have the core interface available
for removing timers/watches.
Signed-off-by:
Put more event loop code in event-loop.c.
This is a preparation patch for the next one.
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 58 +
server/red-common.h | 1 +
server/reds.c | 54 -
3
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/qxl/qxl_drv.h| 4 +---
drivers/gpu/drm/qxl/qxl_object.h | 5 -
drivers/gpu/drm/qxl/qxl_drv.c| 2 +-
drivers/gpu/drm/qxl/qxl_dumb.c | 17 -
drivers/gpu/drm/qxl/qxl_ioctl.c | 5 +++--
drivers/gpu/drm/qxl/Kconfig
On 8/5/19 4:52 PM, Frediano Ziglio wrote:
ping
ping the series
Ack for both patches.
Uri.
Don't call close but socket_close.
Signed-off-by: Frediano Ziglio
---
server/tests/test-websocket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Currently the executable cannot
>
> Set GST_DEBUG_DUMP_DOT_DIR to specify where to place the generated
> .dot file
Acked.
Why not the signed-off ?
> ---
> src/gst-plugin.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
> index e9d9364..0a1d041 100644
> ---
Minor: typo in subject "convertor" -> "converter".
Otherwise,
Acked.
It would be even better to state that this allow for example VASurface type.
Frediano
>
> ---
> src/gst-plugin.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gst-plugin.cpp
On Mon, Aug 05, 2019 at 09:51:06AM -0400, Frediano Ziglio wrote:
> ping
Acked-by: Victor Toso
>
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/usb-device-manager.c | 14 ++
> > 1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > Changes since v1:
> > - conver a debug
On 8/6/19 12:39 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
Ack.
---
spice.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice.html b/spice.html
index 177cfc2..fc1adf6 100644
--- a/spice.html
+++ b/spice.html
@@ -176,7 +176,7 @@
Acked
>
> ping
>
>
> On 2/27/19 1:26 PM, Snir Sheriber wrote:
> > This Makefile script is invoked by copr to build source rpm
> > See: https://docs.pagure.org/copr.copr/user_documentation.html#make-srpm
> > ---
> >
> > Changes from v1 are script improvements and description
> >
> > ---
> >
Signed-off-by: Frediano Ziglio
---
spice.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice.html b/spice.html
index 177cfc2..fc1adf6 100644
--- a/spice.html
+++ b/spice.html
@@ -176,7 +176,7 @@
Host:
Port:
Password:
-
>
> This is effectively v2 of 'Adjust the presentation of two byte scan codes.'
>
> It breaks out a part of the patch separately. In reviewing this,
> I caught a number of other issues. One warranted a patch (included).
> For the rest, I chose to 'fix' it by updating the documentation,
> which
On Tue, Jul 23, 2019 at 06:40:00PM +0800, Chuhong Yuan wrote:
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan
Queued for drm-misc-next (the bochs patch too).
thanks,
Gerd
Hi,
On 8/5/19 7:11 PM, Frediano Ziglio wrote:
Hi Snir,
there were some notes at
https://patchwork.freedesktop.org/patch/288568/?series=57199=1
and
https://patchwork.freedesktop.org/patch/288569/?series=57199=1
This patch [2/3] is not needed we pushed another one which
extracts the deps
ping
On 2/27/19 1:26 PM, Snir Sheriber wrote:
This Makefile script is invoked by copr to build source rpm
See: https://docs.pagure.org/copr.copr/user_documentation.html#make-srpm
---
Changes from v1 are script improvements and description
---
.copr/Makefile | 21 +
1
25 matches
Mail list logo
