[Spice-devel] [PATCH x11spice] Fix compliation on gcc 4.X.

2019-09-17 Thread Jeremy White
gcc 4.x warns if you use a { 0 } initialization construct for a structure with an initial member that is also a struct. The { } construct is simpler and appears to work on a wider range of gcc versions. This is a correction to fdfdf1107be100b983de1bff4beee8e6360f670b Signed-off-by: Jeremy White

Re: [Spice-devel] [PATCH spice-server v2 1/2] char-device: Don't use RedClient API

2019-09-17 Thread Victor Toso
On Sun, Jun 02, 2019 at 08:32:25PM +0100, Frediano Ziglio wrote: > RedClient was an opaque structure for RedCharDevice. > It started to be used when RedsState started to contain all > the global state. > Make it opaque again using a new RedCharDeviceClientOpaque. > The RedCharDeviceClientOpaque

Re: [Spice-devel] [PATCH spice-server 1/2] reds: Inline reds_mig_switch function

2019-09-17 Thread Victor Toso
On Wed, Sep 11, 2019 at 08:55:46AM +0100, Frediano Ziglio wrote: > No much reason for not inlining it, it's quite small and do > not reduce readability. > Note that spice_server_migrate_switch is deprecated and not > used by Qemu since commit 67be6726b6459472103ee87ceaf2e8e97c154965 > (cfr "spice: