>
> Hi,
>
> On Mon, Oct 07, 2019 at 11:38:58AM +0100, Frediano Ziglio wrote:
> > Currently the demarshaler code is not used by spice-server.
> > Demarshal all the fields of the header message, not only the header.
> > Using generated code allows to easily check data and support
> > big endian mac
Hi,
On Mon, Oct 07, 2019 at 11:38:58AM +0100, Frediano Ziglio wrote:
> Currently the demarshaler code is not used by spice-server.
> Demarshal all the fields of the header message, not only the header.
> Using generated code allows to easily check data and support
> big endian machines. Generated
From: Victor Toso
We are only interested in the running state of qmp (or VCPUS) here
which is what we check. Moving this check to the try branch allows
removing some extra checks.
Signed-off-by: Victor Toso
---
tests/migrate.py | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
From: Victor Toso
Make one argument per line;
Add space after and before '=';
Indent with arguments;
Signed-off-by: Victor Toso
---
tests/migrate.py | 43 ---
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/tests/migrate.py b/tests/migrat
From: Victor Toso
This function can be tweak quite a bit due all possibilities around
QEMU configuration. This patch removes incoming_args and extra_args
and move their values to the right place in the function.
I'm also applying a more extensive coding style for parameters, so
when we need to d
From: Victor Toso
Now we always add seamless-migration option to qemu command line and
disabled (off) by default although seamless migration is supported for
over 7 years already!
Signed-off-by: Victor Toso
---
tests/migrate.py | 14 +++---
1 file changed, 11 insertions(+), 3 deletions
From: Victor Toso
Preparatory patch for adding support to change hostname.
Signed-off-by: Victor Toso
---
tests/migrate.py | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tests/migrate.py b/tests/migrate.py
index 3ae9e053..742c9fab 100755
--- a/tests/migrate.py
From: Victor Toso
Currently, when we run migrate.py with --client option we get stuck
waiting for SPICE_CONNECTED event on target qmp (while receiving only
QMP). Problem is, only after event SPICE_INITIALIZED in the source qmp
is that the client will be able to do migration (to properly exchange
From: Victor Toso
This is used in the migrate message and being able to tweak it allows
clients from different machines to test this local migration test.
Example of usage:
./migrate.py --hostname 192.168.122.1 --wait-user-connect
In a VM with access to 192.168.122.1:
remote-viewer spic
From: Victor Toso
As this is not some index but a counter. The first print happens after
first migration was done, meaning 1 instead of 0
Signed-off-by: Victor Toso
---
tests/migrate.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/migrate.py b/tests/migrate.py
inde
red_channel_client_handle_message is called after parsing the
message so it's not necessary to check it again or parse manually.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-channel-client.c b/server
The generated code handle possible endianess mismatch and check
for message format.
The copy back to "write_buf" allows to use that buffer to send
data back to device.
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 7 +++
server/smartcard.c| 1 +
2 fil
Message is checked by generated message parser.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 4
1 file changed, 4 deletions(-)
diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 35eafa7a..832b4175 100644
--- a/server/red-channel-client.c
+++ b/
This brings in the following changes:
Frediano Ziglio (1):
proto: Demarshal Smartcard data field
Kevin Pouget (1):
common/recorder.h: do not complain on unused (dummy) recorders
This is in preparation to use the generated code for Smartcard
(currently not used so won't create regress
Allows to reuse code for emulating a character device.
It will be used for Smardcard test.
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 2 +
server/tests/meson.build | 2 +
server/tests/test-stream-device.c | 224 +-
server/tests
"name" parameter of smartcard_channel_client_add_reader it's not
used.
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/server/smartcard-channel-client.c
b/server/smartcard-channel-client.c
index 0b8644
Create Smardcard device.
Connect to it and test some messages are parsed and processed
as expected.
Signed-off-by: Frediano Ziglio
---
server/tests/.gitignore | 1 +
server/tests/Makefile.am | 4 +
server/tests/meson.build | 4 +
server/tests/test-smartcard.c | 211
Currently the demarshaler code is not used by spice-server.
Demarshal all the fields of the header message, not only the header.
Using generated code allows to easily check data and support
big endian machines. Generated code will be used by spice-server.
The resulting change is.
diff -ru gen/
As base messages require parsing better channels should always use
the generated parser.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 13 ++---
server/red-channel.c | 1 +
server/tests/test-stream-device.c | 3 +++
3 files changed, 6 insertions(+)
Hi,
On Sun, Oct 06, 2019 at 10:49:13AM +0300, Uri Lublin wrote:
> On 10/4/19 11:37 AM, Victor Toso > On Thu, Oct 03, 2019 at 05:13:46PM +0300,
> Uri Lublin wrote:>> On 10/3/19 1:14 PM, Victor Toso wrote:>>> From: Victor
> Toso >> Useful to test different clients running
> different tools (gdb,
20 matches
Mail list logo
