Re: [Spice-devel] [PATCH spice-gtk] gstreamer: Fallback to S/W decoder if H/W one is not working (v2)

2023-11-04 Thread Kasireddy, Vivek
Acked-by: Vivek Kasireddy > > In case the H/W decoder is not able to decode the stream (like too high > profile) try the S/W version. > This is done detecting the failure and trying to recreate the pipeline > in case: > - we are using a H/W pipeline; > - we didn't decode any frame (otherwise it

Re: [Spice-devel] [PATCH spice-gtk] gstreamer: Fix leak using GstBus watch (v2)

2023-11-04 Thread Kasireddy, Vivek
Acked-by: Vivek Kasireddy > > This patch fixes a leak due to not freeing GstBus watch. > The watch is attached (as GSource) to the main loop and retains > a pointer to the bus so we need to remove it to release the bus > when we release the pipeline. > This was detected forcibly creating and

Re: [Spice-devel] [PATCH spice-gtk 2/2] gstreamer: Fallback to S/W decoder if H/W one is not working

2023-11-04 Thread Frediano Ziglio
Il giorno sab 4 nov 2023 alle ore 16:19 Kasireddy, Vivek ha scritto: > > Hi Frediano, > > > > > In case the H/W decoder is not able to decode the stream (like too high > > profile) try the S/W version. > > This is done detecting the failure and trying to recreate the pipeline > > in case: > > -

[Spice-devel] [PATCH spice-gtk] gstreamer: Fallback to S/W decoder if H/W one is not working (v2)

2023-11-04 Thread Frediano Ziglio
In case the H/W decoder is not able to decode the stream (like too high profile) try the S/W version. This is done detecting the failure and trying to recreate the pipeline in case: - we are using a H/W pipeline; - we didn't decode any frame (otherwise it means we lost the beginning or it was

[Spice-devel] [PATCH spice-gtk] gstreamer: Fix leak using GstBus watch (v2)

2023-11-04 Thread Frediano Ziglio
This patch fixes a leak due to not freeing GstBus watch. The watch is attached (as GSource) to the main loop and retains a pointer to the bus so we need to remove it to release the bus when we release the pipeline. This was detected forcibly creating and destroying lot of streams. After a while

Re: [Spice-devel] [PATCH spice-gtk 1/2] gstreamer: Fix leak using GstBus watch

2023-11-04 Thread Frediano Ziglio
Il giorno sab 4 nov 2023 alle ore 16:22 Kasireddy, Vivek ha scritto: > > Hi Frediano, > > > > > This patch fixes a leak due to not freeing GstBus watch. > > The watch is attached (as GSource) to the main loop and retains > > a pointer to the bus so we need to remove it to release the bus > > when

Re: [Spice-devel] [PATCH spice-gtk 1/2] gstreamer: Fix leak using GstBus watch

2023-11-04 Thread Kasireddy, Vivek
Hi Frediano, > > This patch fixes a leak due to not freeing GstBus watch. > The watch is attached (as GSource) to the main loop and retains > a pointer to the bus so we need to remove it to release the bus > when we release the pipeline. > This was detected forcibly creating and destroying lot

Re: [Spice-devel] [PATCH spice-gtk 2/2] gstreamer: Fallback to S/W decoder if H/W one is not working

2023-11-04 Thread Kasireddy, Vivek
Hi Frediano, > > In case the H/W decoder is not able to decode the stream (like too high > profile) try the S/W version. > This is done detecting the failure and trying to recreate the pipeline > in case: > - we are using a H/W pipeline; > - we didn't decode any frame (otherwise it means we lost