Re: [PATCH v2] drm/qxl: Pin buffer objects for internal mappings

2024-07-10 Thread Dmitry Osipenko
On 7/8/24 17:21, Thomas Zimmermann wrote: > Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one > step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where > qxl accesses an unpinned buffer object while it is being moved; such > as with the monitor-description BO. An typ

Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

2024-07-10 Thread Dmitry Osipenko
On 7/2/24 17:20, Thomas Zimmermann wrote: > @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map) > if (r) > return r; > > + r = qxl_bo_pin_locked(bo); > + if (r) > + return r; Is qxl_bo_unreserve() missing here? > + > r = q

Re: [PATCH v2] drm/qxl: Pin buffer objects for internal mappings

2024-07-10 Thread Zack Rusin
On Mon, Jul 8, 2024 at 10:22 AM Thomas Zimmermann wrote: > > Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one > step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where > qxl accesses an unpinned buffer object while it is being moved; such > as with the monitor-desc

Re: [PATCH v2] drm/qxl: Pin buffer objects for internal mappings

2024-07-10 Thread Thomas Zimmermann
Merged into drm-misc-next-fixes Am 08.07.24 um 16:21 schrieb Thomas Zimmermann: Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where qxl accesses an unpinned buffer object while it is being moved; such as with t