Re: [Spice-devel] [PATCH spice-common v2] canvas_base: Rework DUMP_JPEG debugging

Acked-by: Christophe Fergeau On Tue, Jun 26, 2018 at 11:02:56AM +0100, Frediano Ziglio wrote: > The DUMP_JPEG compile time flag is used to dump all jpeg images > to files. > The code was saving garbage instead of proper data. > > Signed-off-by: Frediano Ziglio > Reported-

Re: [Spice-devel] [PATCH spice-server] red-record-qxl: Remove potential leak

Acked-by: Christophe Fergeau On Mon, Jun 25, 2018 at 11:46:22AM +0100, Frediano Ziglio wrote: > On some systems you need to call g_spawn_close_pid after > spawning a process to avoid leaks (currently Windows). > > Signed-off-by: Frediano Ziglio > --- > server/red-record-qxl

Re: [Spice-devel] [PATCH spice-server] replay: Use GPid and G_PID_FORMAT for portability

Acked-by: Christophe Fergeau On Mon, Jun 25, 2018 at 11:46:23AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/tests/replay.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/tests/replay.c b/server/test

Re: [Spice-devel] Windows 10 KVM guest very slow in SPICE console

On Mon, Jun 25, 2018 at 01:56:14PM -0500, Carlos González wrote: > Just a bump. Not fully clear whether you installed the qxl-wddm-dod driver as suggested earlier or not. Are you using it in the guest? Christophe > > 2018-06-21 12:47 GMT-05:00 Carlos González : > > > Excuse me, some clue by

Re: [Spice-devel] [PATCH spice-common] canvas_base: Rework DUMP_JPEG debugging

_t n = 0; n < data->num_chunks; ++n) { > +fwrite(data->chunk[n].data, 1, data->chunk[n].len, f); > +} > fclose(f); > } > +#else > +static inline void dump_jpeg(SpiceChunks* data, uint32_t data_size) {} I'd jus trust the compiler to do the right thing here

Re: [Spice-devel] [PATCH spice-server] Add possibly missing headers for pthread.h

Ok, Acked-by: Christophe Fergeau On Wed, Jun 20, 2018 at 02:31:40PM +0100, Frediano Ziglio wrote: > In some environment pthread.h is not defined but its definitions > are used in some headers. > Actually happens using MingW. > > Signed-off-by: Frediano Ziglio > --- >

Re: [Spice-devel] [PATCH spice-server] display-channel: Do not use bzero

Acked-by: Christophe Fergeau On Wed, Jun 20, 2018 at 02:31:41PM +0100, Frediano Ziglio wrote: > Used only in this file. > Not defined in MingW. > > Signed-off-by: Frediano Ziglio > --- > server/display-channel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Spice-devel] [PATCH spice-common] test-quic: Allows to specify multiple images to test

f (argc >= 2) { > GdkPixbuf *source_pixbuf; > > -source_pixbuf = gdk_pixbuf_new_from_file(argv[1], NULL); > -test_pixbuf(source_pixbuf); > -g_object_unref(source_pixbuf); > +for (int i = 1; i < argc; ++i) { Looks like you could

Re: [Spice-devel] libressl fix for spice-gtk

On Wed, Jun 20, 2018 at 09:02:05AM -0400, Frediano Ziglio wrote: > > > > Hi, I maintain the spice-gtk port in FreeBSD and noticed that in > > spice-gtk-0.35, there was a fix for libressl but that fix needs to > > only apply to older versions of libressl. Here is a patch that > > implements this.

Re: [Spice-devel] [PATCH spice-common] test-quic: Add missing header for exit

Acked-by: Christophe Fergeau On Thu, Jun 21, 2018 at 11:52:52AM +0100, Frediano Ziglio wrote: > For some reasons building with Meson "exit" is not declared. > > Signed-off-by: Frediano Ziglio > --- > tests/test-quic.c | 1 + > 1 file changed, 1 insertion(+)

Re: [Spice-devel] [PATCH spice-server] Use PRIxPTR constant for string formatting

On Fri, Jun 22, 2018 at 11:28:50AM +0100, Frediano Ziglio wrote: > These constant are meant to be used in format string for size_t > types. Use them for portability. Alternatively, this could be G_GSIZE_FORMAT Christophe > > Signed-off-by: Frediano Ziglio > --- > server/red-record-qxl.c | 4

Re: [Spice-devel] [ovirt-users] Re: remote-viewer Spice Problem on MacOS

On Mon, Jun 25, 2018 at 06:15:30AM -0400, Frediano Ziglio wrote: > > +Spice devel mailing list. > > > On Thu, Jun 21, 2018, 11:57 PM John Florian < jflor...@doubledog.org > > > wrote: > > > > On 2018-06-21 08:20, Michal Skrivanek wrote: > > > > > > Any connectivity issue should no really be

Re: [Spice-devel] [spice-common] test-logging: Improve debug level tests

On Wed, Jun 20, 2018 at 12:15:49PM -0400, Frediano Ziglio wrote: > Seems fine. Do you have a CI result? https://gitlab.com/teuf/spice-common/commit/49d7e4d4d9425c39e15f4f7ded7ae9675ca0e197/pipelines?ref=master signature.asc Description: PGP signature

Re: [Spice-devel] [spice-common] test-logging: Improve debug level tests

On Wed, Jun 20, 2018 at 12:15:49PM -0400, Frediano Ziglio wrote: > > > > These tests were checking that the expected messages were output, but > > they were not checking that the messages we don't want are not output. > > This commit adds this to make sure our log implementation does not > >

[Spice-devel] [spice-server] ssl: Allow to use ECDH ciphers with OpenSSL 1.0

Without an explicit call to SSL_CTX_set_ecdh_auto(reds->ctx, 1), OpenSSL 1.0 would not use ECDH ciphers (this is now automatic with OpenSSL 1.1.0). This commit adds this missing call. It's based on a suggestion from David Jasa Signed-off-by: Christophe Fergeau https://bugzilla.redhat.

[Spice-devel] [spice-common] test-logging: Improve debug level tests

These tests were checking that the expected messages were output, but they were not checking that the messages we don't want are not output. This commit adds this to make sure our log implementation does not output unwanted debug messages. --- tests/test-logging.c | 17 + 1 file

Re: [Spice-devel] [spice-common 2/2] log: spice_printerr goes through g_message

On Wed, Jun 20, 2018 at 10:16:56AM -0400, Frediano Ziglio wrote: > > > > --- > > common/log.h | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/common/log.h b/common/log.h > > index e0fd34b..4058208 100644 > > --- a/common/log.h > > +++ b/common/log.h > > @@

[Spice-devel] [spice-common 1/2] log: Only install glib log handler if SPICE_DEBUG_LEVEL is set

Calling g_log_set_handler() is problematic as this means applications using spice-server won't be able to use g_log_set_default_handler to manage spice logging output themselves. Since this call is only needed for backwards compatibility (so that calling g_log together with SPICE_DEBUG_LEVEL set

[Spice-devel] [spice-common 2/2] log: spice_printerr goes through g_message

--- common/log.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/common/log.h b/common/log.h index e0fd34b..4058208 100644 --- a/common/log.h +++ b/common/log.h @@ -57,9 +57,7 @@ void spice_log(GLogLevelFlags log_level, spice_log(G_LOG_LEVEL_WARNING, SPICE_STRLOC,

Re: [Spice-devel] [PATCH] Update spice-common submodule url

Ah right, noticed that, iirc it's a bit odd as direct cloning without the .git works though. Acked-by: Christophe Fergeau On Wed, Jun 20, 2018 at 12:28:52PM +0300, Snir Sheriber wrote: > Old git (e.g. on rhel 7.5) is failing to init/update spice-common > submodule if .git is missin

Re: [Spice-devel] [PATCH] spice-common submodule: update url (add .git at the end)

Acked-by: Christophe Fergeau On Wed, Jun 20, 2018 at 12:28:58PM +0300, Uri Lublin wrote: > With the move to gitlab.freedesktop.org the spice-common submodule > url changed, and now ends with .git > > Update .gitmodules to reflect that. > > Without this patch gi

Re: [Spice-devel] [spice-list] Fwd: [ovirt-users] Fwd: VM hanging at boot - [drm] Initialized qxl

On Wed, Jun 20, 2018 at 12:38:00PM +0300, Yaniv Kaul wrote: > On Wed, Jun 20, 2018 at 12:26 PM, Christophe Fergeau > wrote: > > > > -- Forwarded message -- > > > > From: Leo David > > > > Date: Wed, Jun 13, 2018 at 8:24 PM > > >

Re: [Spice-devel] [RFC/POC PATCH spice-protocol 02/16] Create a version 2 of the VDAgentMonitorsConfig message

On Tue, Jun 19, 2018 at 05:30:46PM +0200, Lukáš Hrázký wrote: > I don't know. I've also just noticed today that the depth field > actually seems to be unused, besides being set in the client. The windows agent uses it

Re: [Spice-devel] how to open jpg binary file (/tmp/spice_dump/x.jpg)?

Hey, On Wed, Jun 20, 2018 at 02:14:54AM +, 谢 昆明 wrote: > Hey guys. I have dump some jpg file, but I can’t open it with eog. I don't understand how this relates to spice? Is this some spice code which is calling dump_jpeg? Christophe > > > static int jpeg_id = 0; > static void

Re: [Spice-devel] [spice-list] Fwd: [ovirt-users] Fwd: VM hanging at boot - [drm] Initialized qxl

On Tue, Jun 19, 2018 at 06:36:26AM -0400, David Blechter wrote: > ​re-directing to the correct upstream list. In the future all ovirt/spice > related issue should be address in the spice-de...@freedesktop.org list.​ > > > Thank you, > David Blechter > 978-392-3182 <(978)%20392-3182> > > On Tue,

Re: [Spice-devel] [Q]After install Windows guest tools - spice-guest-tools-latest , Spice Upside down display, how to solve it?

what spice client are you using? I think there were such issues with spice-html5 which were fixed a year ago with https://gitlab.freedesktop.org/spice/spice-html5/commit/bfa85a7117fcf28ff19f2507f61db4620da2e828

[Spice-devel] [spice-protocol] meson: Post-release bump to 0.12.15

This was done for configure.ac earlier, but is missing in meson.build Signed-off-by: Christophe Fergeau --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5ed4177..31531e2 100644 --- a/meson.build +++ b/meson.build @@ -2,7 +2,7

Re: [Spice-devel] [spice-server] build: Remove check for CELT

mon after recent changes there. > > > > Signed-off-by: Christophe Fergeau > > --- > > configure.ac | 10 -- > > 1 file changed, 10 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index 1e569c30a..d71f0989f 100644 > > --- a/confi

[Spice-devel] [spice-server v2] build: Use SPICE_CHECK_CELT051 in configure.ac

in --help output. Signed-off-by: Christophe Fergeau --- configure.ac | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 1e569c30a..27898d2e6 100644 --- a/configure.ac +++ b/configure.ac @@ -181,15 +181,7 @@ AC_SUBST(PIXMAN_CFLAGS

[Spice-devel] [spice-server] build: Remove check for CELT

spice-server does not have any code depending on libcelt, such code is in spice-common. We can thus get rid of that check, especially as its default got out of sync with spice-common after recent changes there. Signed-off-by: Christophe Fergeau --- configure.ac | 10 -- 1 file changed

Re: [Spice-devel] [spice-server 3/4] docs: Add documentation for the streaming device

Ping? Christophe On Fri, Jun 08, 2018 at 04:25:28PM +0200, Christophe Fergeau wrote: > Signed-off-by: Christophe Fergeau > --- > docs/manual/manual.txt | 51 ++ > 1 file changed, 51 insertions(+) > > diff --git a/docs/manual/manual

Re: [Spice-devel] [spice-server 4/4] build: Prepare for 0.14.1 release

On Mon, Jun 18, 2018 at 10:24:11AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, Jun 08, 2018 at 04:25:29PM +0200, Christophe Fergeau wrote: > > > Signed-off-by: Christophe Fergeau > > > --- > > > NEWS | 23 +

Re: [Spice-devel] [PATCH spice-server] red-channel-client: Do not allocate iovec array statically in the class

Acked-by: Christophe Fergeau On Mon, Jun 18, 2018 at 08:35:52AM +0100, Frediano Ziglio wrote: > This array is just used locally in red_channel_client_handle_outgoing > so declare it there. > > Signed-off-by: Frediano Ziglio > --- > server/red-channel-client.c | 9 -

Re: [Spice-devel] [PATCH spice-server] reds: Remove possible alignment warning using Clang

Acked-by: Christophe Fergeau On Mon, Jun 18, 2018 at 10:38:53AM +0100, Frediano Ziglio wrote: > Although capabilities inside link message are handled as arrays > of 4 bytes unsigned integers we don't need capabilities to be > aligned to 4 bytes just to call g_memdup so use

Re: [Spice-devel] [PATCH spice-server v2] Use "base" as pipe item base field name

Acked-by: Christophe Fergeau On Mon, Jun 18, 2018 at 11:29:38AM +0100, Frediano Ziglio wrote: > Most of pipe items use this name for the base field. > This also allows to use SPICE_UPCAST macros instead of a long > SPICE_CONTAINEROF. > > Signed-off-by: Frediano Ziglio >

[Spice-devel] [spice-gtk] main-channel: Fix deprecation annotation

Signed-off-by: Christophe Fergeau --- src/channel-main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-main.h b/src/channel-main.h index 530378db..fd7a3bb3 100644 --- a/src/channel-main.h +++ b/src/channel-main.h @@ -113,7 +113,7 @@ void

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

Hey, On Wed, May 09, 2018 at 01:20:19PM +0200, Lukáš Hrázký wrote: > On Wed, 2018-05-09 at 05:18 -0400, Frediano Ziglio wrote: > > The agent send a single message, but reads/writes to the device are > > not atomic. Note that the current protocol introduce additional > > delays as the frames

Re: [Spice-devel] [spice-gtk 1/2] Update spice-common

Acked-by: Christophe Fergeau You probably need something like this for make distcheck/CI diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a34eb0e7..e2c35ef9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -10,7 +10,7 @@ before_script: makecheck: script: - - ./autogen.sh --enable

Re: [Spice-devel] [spice-gtk v2 2/2] Update NEWS for v0.35 release

nels > +- Fix keycodes on Xwayland (rhbz#1479682) > +- memory leak fixes, new tests Nit: "Memory" rather than "memory", and the already mentioned "New Add" which I believe is fixed already. Acked-by: Christophe Fergeau signature.asc Description: PGP signa

Re: [Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

thentication > - Webdav: Fix some runtime warnings > - Introspection: Fixes for SpicePortChannel, SpiceDisplayChannel, > > I'll send a v2 in a minute. > > Cheers, > toso > > On Mon, Jun 11, 2018 at 02:40:32PM +0200, Christophe Fergeau wrote: > > On Mon, Jun 11, 2018 a

Re: [Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

On Mon, Jun 11, 2018 at 01:32:37PM +0200, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- > NEWS | 24 > 1 file changed, 24 insertions(+) > > diff --git a/NEWS b/NEWS > index e691583..dbfc1a3 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,27

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

Fine with me, hopefully we won't forget to fix this for good :-/ Acked-by: Christophe Fergeau Christophe On Mon, Jun 11, 2018 at 09:11:40AM +0200, Victor Toso wrote: > Hi, > > Could we have this revert for the release and then I'll open a > bug to fix it properly during the

[Spice-devel] [spice-server v2] ci: Pass --enable-celt051 to configure

It's now mandatory to explicitly enable/disable CELT at configure time if celt051-devel is installed. Signed-off-by: Christophe Fergeau --- I botched my testing of the previous version, this one should be more correct ;) Christophe .gitlab-ci.yml | 8 1 file changed, 4 insertions

Re: [Spice-devel] [spice-server 4/4] build: Prepare for 0.14.1 release

On Fri, Jun 08, 2018 at 04:25:29PM +0200, Christophe Fergeau wrote: > diff --git a/spice-common b/spice-common > index a84f868e4..4a7a11b6a 16 > --- a/spice-common > +++ b/spice-common > @@ -1 +1 @@ > -Subproject commit a84f868e48035a9442ffc30a0a52559c9cf3fe54 &g

[Spice-devel] [spice-server] ci: Pass --enable-celt051 to configure

It's now mandatory to explicitly enable/disable CELT at configure time if celt051-devel is installed. --- This patch is also needed in order not to break CI, probably makes sense to squash it with the DISTCHECKFLAGS one, or maybe with the submodule update Christophe .gitlab-ci.yml | 2 +- 1

[Spice-devel] [spice-server 1/4] Update spice-common submodule

This brings in the following changes: Christophe Fergeau (21): quic: Remove configurable RLE_PRED quic: Remove configurable PRED quic: Get rid of QUIC_RGB #define quic: Get rid of RLE_STAT #define quic: Get rid of RLE #define quic: Factor common code quic

[Spice-devel] [spice-server 2/4] build: Explicitly disable celt051 when running make distcheck

. Signed-off-by: Christophe Fergeau --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 9a073a122..cef442914 100644 --- a/Makefile.am +++ b/Makefile.am @@ -10,6 +10,7 @@ pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = spice-server.pc

[Spice-devel] [spice-server 3/4] docs: Add documentation for the streaming device

Signed-off-by: Christophe Fergeau --- docs/manual/manual.txt | 51 ++ 1 file changed, 51 insertions(+) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index 40d080d9f..b54c83cb0 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt

[Spice-devel] [spice-server 4/4] build: Prepare for 0.14.1 release

Signed-off-by: Christophe Fergeau --- NEWS | 23 +++ configure.ac | 2 +- spice-common | 2 +- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 51bb4a2e6..c9e091c5f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,26 @@ +Major Changes

Re: [Spice-devel] [PATCH spice] Remove excessive logging of an area being drawn

On Wed, Jun 06, 2018 at 04:34:10PM +0200, Lukáš Hrázký wrote: > Removes debug messages that are logged on every draw, spamming the log > excessively when debugging. Acked-by: Christophe Fergeau > > Signed-off-by: Lukáš Hrázký > --- > server/display-channel.c | 3 --- &g

Re: [Spice-devel] [PATCH spice-gtk v2] widget: handle smooth-scroll events

press_and_release(display, SPICE_MOUSE_BUTTON_DOWN, button_state); > +break; > +case GDK_SCROLL_SMOOTH: > +d->scroll_delta_y += scroll->delta_y; > +while (ABS(d->scroll_delta_y) > 1) { > +if (d->scroll_delta_y < 0) { > +

[Spice-devel] [spice-common 2/3] build: Remove docs/.gitignore

It was added together with the meson build, but it's currently being managed by git.mk, so it should not be in git --- docs/.gitignore | 1 - 1 file changed, 1 deletion(-) delete mode 100644 docs/.gitignore diff --git a/docs/.gitignore b/docs/.gitignore deleted file mode 100644 index

[Spice-devel] [spice-common 1/3] build: Update git.mk to latest version

https://raw.githubusercontent.com/behdad/git.mk/master/git.mk has a newer version than what we are using now. --- git.mk | 225 ++--- 1 file changed, 199 insertions(+), 26 deletions(-) diff --git a/git.mk b/git.mk index d5bf7b8..90de80f 100644

[Spice-devel] [spice-common 3/3] build: Add __pycache__/*.pyc to DISTCLEANFILES

Python 3 puts its .pyc files in a __pycache__ subdirectory, This commit adds these to DISTCLEANFILES. My main motivation for doing this is so that git.mk can then properly add them to .gitignore. --- python_modules/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Spice-devel] [PATCH spice-gtk] widget: handle smooth-scroll events

Hey, On Thu, Jun 07, 2018 at 07:42:24PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > With touchpads and similar devices, scroll events are not emitted on > Wayland, but only smooth-scroll events. > > There is some discussion about handling smooth-scroll events in

Re: [Spice-devel] [spice-common v2 3/3] meson: Remove '(default: xxx)' from option description

On Wed, Jun 06, 2018 at 07:26:23AM -0400, Frediano Ziglio wrote: > > > > 'meson configure' will show the current value of an option, specifying > > the default value in the option description does not add much to that > > output. > > > > But the current values are not always the default ones. >

[Spice-devel] [spice-common v2 1/3] meson: Support auto/true/false for optional dependencies

At the moment, missing optional dependencies will be silently ignored when the corresponding configuration flag is 'true', and won't be tested for when the flag is 'false'. In the autotools build, this corresponds respectively to --enable-foo=auto and --disable-foo. Having a way to get an error

[Spice-devel] [spice-common v2 2/3] meson: Remove check for vfork

not compiled in on Windows for example), and anyway, I doubt anyone is going to try to compile SPICE code on a platform without fork, so we can remove this check, it's always possible to readd it when we have a clear bug report about what is missing/needed. Signed-off-by: Christophe Fergeau

[Spice-devel] [spice-common v2 3/3] meson: Remove '(default: xxx)' from option description

'meson configure' will show the current value of an option, specifying the default value in the option description does not add much to that output. Signed-off-by: Christophe Fergeau --- Changes since v1: rebased meson_options.txt | 14 +++--- 1 file changed, 7 insertions(+), 7

[Spice-devel] [spice-common] meson: Support auto/true/false for optional dependencies

At the moment, missing optional dependencies will be silently ignored when the corresponding configuration flag is 'true', and won't be tested for when the flag is 'false'. In the autotools build, this corresponds respectively to --enable-foo=auto and --disable-foo. Having a way to get an error

[Spice-devel] [spice-common 1/2] meson: Remove '(default: xxx)' from option description

'meson configure' will show the current value of an option, specifying the default value in the option description does not add much to that output. Signed-off-by: Christophe Fergeau --- meson_options.txt | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Spice-devel] [spice-common 2/2] meson: Remove check for vfork

not compiled in on Windows for example), and anyway, I doubt anyone is going to try to compile SPICE code on a platform without fork, so we can remove this check, it's always possible to readd it when we have a clear bug report about what is missing/needed. Signed-off-by: Christophe Fergeau

Re: [Spice-devel] [PATCH spice-server 1/2] ci: Merge new Valgrind suppression rule from official glib.supp

Acked-by: Christophe Fergeau On Tue, Jun 05, 2018 at 02:06:00PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/tests/valgrind/glib.supp | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/server/tests/valgrind/glib.supp b/ser

Re: [Spice-devel] [PATCH spice-server 2/2] ci: Add some needed Valgrind suppression rule

Acked-by: Christophe Fergeau On Tue, Jun 05, 2018 at 02:06:01PM +0100, Frediano Ziglio wrote: > From Gitlab CI: > > =17955== 16 bytes in 1 blocks are possibly lost in loss record 725 of 2,079 > ==17955==at 0x4C2DBAB: malloc (vg_replace_malloc.c:299) > ==17955==

Re: [Spice-devel] [PATCH spice-common] quic: Use __builtin_clz if available

ok, Acked-by: Christophe Fergeau On Tue, Jun 05, 2018 at 11:54:46AM +0100, Frediano Ziglio wrote: > Different processors has specific instructions to count leading > zero bits. This includes: x86. x64, arm, ppc. > For portability reason the behaviour of __builtin_clz is not

Re: [Spice-devel] [linux-vdagent 0/4] Preparing for 0.18.0 release

ow the gtk+ code behaves in the real world, and then make that decision ;) Series looks fine to me, Acked-by: Christophe Fergeau Christophe > > [0] https://gitlab.freedesktop.org/victortoso/vd_agent/pipelines/630 > > Cheers, > toso > > Victor Toso (4): > build-sys

Re: [Spice-devel] [PATCH spice-server v3] glz-encoder: Avoid double byte swap sending image magic

Ah thanks for expanding the commit log, still Acked-by: Christophe Fergeau On Tue, Jun 05, 2018 at 09:57:25AM +0100, Frediano Ziglio wrote: > encode_32 already deals with endian, don't swap twice. > Tested with a ppc64 server machine and a x64 client. > > This looks the reverse o

[Spice-devel] [spice-common v2 0/7] build: Misc build system cleanups

in patch #1 - fixed 'test xx == xx' occurrences - removed "" from Opus error messages Christophe Christophe Fergeau (7): build: Ensure we link with -lm if needed build: Disable celt 0.5.1 by default build: By default, error out if Opus is missing build: Use AM_COND_IF build: Rem

[Spice-devel] [spice-common v2 7/7] build: Move client sources to libspice_common_client_la_SOURCES

These sources are only used by the client, so they do not belong in libspice_common_la_SOURCES. Signed-off-by: Eduardo Lima (Etrunko) Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- common/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Spice-devel] [spice-common v2 4/7] build: Use AM_COND_IF

AM_COND_IF can be replaced in constructs like: AM_CONDITIONAL([HAVE_OPUS], [test "x$have_opus" = "xyes"]) if test "x$have_opus" = "xyes" ; then AC_DEFINE([HAVE_OPUS], [1], [Define if we have OPUS]) fi which becomes: AM_CONDITIONAL([HAVE_OPUS], [test "x$have_opus" =

[Spice-devel] [spice-common v2 1/7] build: Ensure we link with -lm if needed

lines.c uses hypot(), which is found in libm on some systems. This means we are currently relying on getting -lm indirectly through some other means, as otherwise linking any binary with spice-common would fail. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- m4/spice-deps.m4

[Spice-devel] [spice-common v2 6/7] build: Remove bitops.h

Nothing uses it since the GL backend was removed in 384698a Acked-by: Frediano Ziglio --- common/Makefile.am | 1 - common/bitops.h| 87 -- common/meson.build | 1 - common/quic.c | 1 - configure.ac | 2 +- 5 files changed, 1

[Spice-devel] [spice-common v2 3/7] build: By default, error out if Opus is missing

Following the commit disabling celt by default, it's quite easy to have a build without both celt and opus. After this commit, Opus will have to be installed for a successful build unless one passes --disable-opus. --- m4/spice-deps.m4 | 13 - meson.build | 11 ++-

[Spice-devel] [spice-common v2 2/7] build: Disable celt 0.5.1 by default

are installed, it will error out unless --enable-celt051/--disable-celt051 has been explicitly specified. Signed-off-by: Christophe Fergeau --- m4/spice-deps.m4 | 21 + meson_options.txt | 4 ++-- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/m4/spice-deps.m4 b/m4

[Spice-devel] [spice-common v2 5/7] build: Remove checks for functions which are never called

Grepping for 'pow', 'sqrt' or 'inet_ntoa' returns no results in spice-common code base. inet_ntoa use was removed in 9749e7e 'ssl-verify: Changed IPv4 hostname to IPv6' and pow/sqrt use in 384698a 'Remove GL support' Acked-by: Frediano Ziglio --- m4/spice-deps.m4 | 2 +- meson.build | 3

[Spice-devel] [spice-common 5/7] build: Remove checks for functions which are never called

Grepping for 'pow', 'sqrt' or 'inet_ntoa' returns no results in spice-common code base. inet_ntoa use was removed in 9749e7e 'ssl-verify: Changed IPv4 hostname to IPv6' and pow/sqrt use in 384698a 'Remove GL support' --- m4/spice-deps.m4 | 2 +- meson.build | 3 --- 2 files changed, 1

[Spice-devel] [spice-common 0/7] build: Misc build system cleanups

Hey, This series expands on the Celt 0.5.1/-lm series I sent earlier with some small additional cleanups. The main change is that celt will be disabled by default, and Opus will be enabled by default, with errors when I felt it was appropriate. Christophe Christophe Fergeau (7): build

[Spice-devel] [spice-common 1/7] build: Ensure we link with -lm if needed

lines.c uses hypot(), which is found in libm on some systems. This means we are currently relying on getting -lm indirectly through some other means, as otherwise linking any binary with spice-common would fail. Signed-off-by: Christophe Fergeau --- m4/spice-deps.m4 | 4 meson.build

[Spice-devel] [spice-common 6/7] build: Remove bitops.h

Nothing uses it since the GL backend was removed in 384698a --- common/Makefile.am | 1 - common/bitops.h| 87 -- common/meson.build | 1 - common/quic.c | 1 - configure.ac | 2 +- 5 files changed, 1 insertion(+), 91 deletions(-)

[Spice-devel] [spice-common 7/7] build: Move client sources to libspice_common_client_la_SOURCES

These sources are only used by the client, so they do not belong in libspice_common_la_SOURCES. Signed-off-by: Eduardo Lima (Etrunko) Signed-off-by: Christophe Fergeau --- common/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/Makefile.am b/common

[Spice-devel] [spice-common 3/7] build: By default, error out if Opus is missing

Following the commit disabling celt by default, it's quite easy to have a build without both celt and opus. After this commit, Opus will have to be installed for a successful build unless one passes --disable-opus. --- m4/spice-deps.m4 | 13 - meson.build | 11 ++-

[Spice-devel] [spice-common 4/7] build: Use AM_COND_IF

AM_COND_IF can be replaced in constructs like: AM_CONDITIONAL([HAVE_OPUS], [test "x$have_opus" = "xyes"]) if test "x$have_opus" = "xyes" ; then AC_DEFINE([HAVE_OPUS], [1], [Define if we have OPUS]) fi which become: AM_CONDITIONAL([HAVE_OPUS], [test "x$have_opus" = "xyes"])

[Spice-devel] [spice-common 2/7] build: Disable celt 0.5.1 by default

are installed, it will error out unless --enable-celt051/--disable-celt051 has been explicitly specified. Signed-off-by: Christophe Fergeau --- m4/spice-deps.m4 | 21 + meson_options.txt | 4 ++-- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/m4/spice-deps.m4 b/m4

Re: [Spice-devel] [PATCH spice-common v2 2/2] build: Disable celt 0.5.1 by default

On Mon, Jun 04, 2018 at 03:59:48PM +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > This version of the CELT codec has long been obsolete, and Opus support > has been added nearly 5 years ago. It's time we move on and try to stop > using Celt ;) Given that we are

Re: [Spice-devel] [PATCH spice-streaming-agent] ci: Add required xz package

Acked-by: Christophe Fergeau On Mon, Jun 04, 2018 at 12:35:56PM +0100, Frediano Ziglio wrote: > Make dist requires xz as is the default compression algorithm. > > Signed-off-by: Frediano Ziglio > --- > .gitlab-ci.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Spice-devel] [PATCH spice-common] quic: Fix endianness encoding

Acked-by: Christophe Fergeau On Mon, Jun 04, 2018 at 10:28:47AM +0100, Frediano Ziglio wrote: > The image is going to network and network protocol is little endian > so the numbers has to be little endian. Note that this is already done > during decoding. > Tested on a p

Re: [Spice-devel] [PATCH spice-server] glz-encoder: Avoid double byte swap sending image magic

On Mon, Jun 04, 2018 at 10:30:12AM +0100, Frediano Ziglio wrote: > encode_32 already deals with endian, don't swap twice. > Tested with a ppc64 server machine and a x64 client. > > Signed-off-by: Frediano Ziglio > --- > server/glz-encoder.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Spice-devel] [PATCH spice-gtk 1/3] tests: Remove unused structure declaration

For the series, Acked-by: Christophe Fergeau On Mon, Jun 04, 2018 at 10:41:43AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > tests/file-transfer.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/tests/file-transfer.c b/tests/file-

Re: [Spice-devel] [PATCH spice-common] squash! build: Ensure we link with -lm if needed

Dunno if we should go out of our way for this test, or if we could just unconditionnally link libm. either way is fine with me, and the proposed patch looks fine. I would drop 'func' from it, and use 'hypot' directly. Christophe On Mon, Jun 04, 2018 at 02:03:43PM +0100, Frediano Ziglio wrote: >

Re: [Spice-devel] [spice-common 1/2] build: Ensure we link with -lm if needed

On Mon, Jun 04, 2018 at 05:04:05AM -0400, Frediano Ziglio wrote: > > > > lines.c uses hypot(), which is found in libm on some systems. > > > > Do you remember which systems? FreeBSD ? Linux ;) Just add a call to hypot in spice_logv (or something which is used by one of our tests), ./autogen.sh

[Spice-devel] [spice-common 2/2] build: Disable celt 0.5.1 by defaulto

This version of the CELT codec has long been obsolete, and Opus support has been added nearly 5 years ago. It's time we move on and try to stop using Celt ;) Signed-off-by: Christophe Fergeau --- m4/spice-deps.m4 | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/m4

[Spice-devel] [spice-common 1/2] build: Ensure we link with -lm if needed

lines.c uses hypot(), which is found in libm on some systems. Signed-off-by: Christophe Fergeau --- m4/spice-deps.m4 | 4 1 file changed, 4 insertions(+) diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4 index 7c0cca4..cf0e048 100644 --- a/m4/spice-deps.m4 +++ b/m4/spice-deps.m4 @@ -64,6

Re: [Spice-devel] [PATCH spice-common] build: Move sources to libspice_common_client_la_SOURCES

On Fri, Jun 01, 2018 at 09:43:14AM -0400, Frediano Ziglio wrote: > > > > From: Christophe Fergeau > > > > These sources are only used by the client, so they do not belong in > > libspice_common_la_SOURCES. > > > > Signed-off-by: Eduardo Lima (Etrunko

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

On Wed, Apr 25, 2018 at 04:26:40AM -0400, Frediano Ziglio wrote: > > > > On Fri, Apr 06, 2018 at 09:59:43AM +0200, Victor Toso wrote: > > > > > From: Victor Toso > > > > > > > > > > This reverts commit 291f3e4419e6fb4077ae43a5e09eb1c37b9dd729 > > > > > > > > > > Follow up patch should address

Re: [Spice-devel] [vdagent-win PATCH 09/13] file_xfer: Use shared_ptr to simplify memory management

On Mon, May 28, 2018 at 09:33:11AM -0400, Frediano Ziglio wrote: > > > > On Mon, May 28, 2018 at 09:58:02AM +0100, Frediano Ziglio wrote: > > > Clear automatically tasks items. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > vdagent/file_xfer.cpp | 25

Re: [Spice-devel] [vdagent-win PATCH 12/13] Factor out an utility function to read strings from registry

On Mon, May 28, 2018 at 09:58:11AM -0400, Frediano Ziglio wrote: > > > > On Mon, May 28, 2018 at 09:58:05AM +0100, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > vdagent/display_setting.cpp | 97 + > > > 1 file

Re: [Spice-devel] [vdagent-win PATCH 05/13] msi: Do not generate deps.txt

On Mon, May 28, 2018 at 09:26:47AM -0400, Frediano Ziglio wrote: > > > > On Mon, May 28, 2018 at 09:57:58AM +0100, Frediano Ziglio wrote: > > > There's no reason to tell the package installed on the build system > > > used. > > > > This can be useful to know which version of zlib or libpng are

Re: [Spice-devel] [vdagent-win PATCH 12/13] Factor out an utility function to read strings from registry

On Mon, May 28, 2018 at 09:58:05AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > vdagent/display_setting.cpp | 97 + > 1 file changed, 54 insertions(+), 43 deletions(-) > > diff --git a/vdagent/display_setting.cpp

Re: [Spice-devel] [vdagent-win PATCH 09/13] file_xfer: Use shared_ptr to simplify memory management

On Mon, May 28, 2018 at 09:58:02AM +0100, Frediano Ziglio wrote: > Clear automatically tasks items. > > Signed-off-by: Frediano Ziglio > --- > vdagent/file_xfer.cpp | 25 - > vdagent/file_xfer.h | 3 ++- > 2 files changed, 6 insertions(+), 22

Re: [Spice-devel] [vdagent-win PATCH 08/13] file_xfer: Use destructor for FileXferTask

On Mon, May 28, 2018 at 09:58:01AM +0100, Frediano Ziglio wrote: > Limit too much manual work. > By default delete the file, unless success() is called. > > Signed-off-by: Frediano Ziglio > --- > vdagent/file_xfer.cpp | 23 ++- > vdagent/file_xfer.h |

<    2   3   4   5   6   7   8   9   10   11   >