Re: [Spice-devel] [PATCH spice-protocol v4 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-23 Thread Eduardo Lima (Etrunko)
On 10/23/19 12:06 PM, Frediano Ziglio wrote: .pc files requires MingW version, not system one. I think it would be better if squashed into previous patch? This idea of building the mingw packages from the same source is nice, but it needs some more discussion. Lets keep this patch on hold fo

Re: [Spice-devel] [PATCH spice-protocol v4 3/5] build-sys: Provide spec file during build

2019-10-23 Thread Eduardo Lima (Etrunko)
Summary:Spice protocol header files +Group: Development/Libraries # Main headers are BSD, controller / foreign menu are LGPL License:BSD and LGPLv2+ URL:https://www.spice-space.org Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Softwar

Re: [Spice-devel] [PATCH spice-protocol v4 2/5] build-sys: Update URL in SPEC file

2019-10-23 Thread Eduardo Lima (Etrunko)
BuildArch: noarch %description Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org

Re: [Spice-devel] [PATCH spice-protocol v4 1/5] build-sys: Import spec file from Fedora

2019-10-23 Thread Eduardo Lima (Etrunko)
any more with + recent rpm versions (F13+). + +* Fri Jul 9 2010 Gerd Hoffmann - 0.5.2-1 +- initial package. + Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ Spice-devel mailing

Re: [Spice-devel] [PATCH spice-protocol v2 1/5] build-sys: Import spec file from Fedora

2019-10-22 Thread Eduardo Lima (Etrunko)
On 10/21/19 11:10 AM, Frediano Ziglio wrote: Will be used by next commits. Would you mind to provide a mode detailed commit message explaining the reason why we need the spec file in the repository? Signed-off-by: Frediano Ziglio --- spice-protocol.spec.in | 173

Re: [Spice-devel] [PATCH spice-protocol v2 4/5] build-sys: Update URL in SPEC file

2019-10-22 Thread Eduardo Lima (Etrunko)
On 10/21/19 11:10 AM, Frediano Ziglio wrote: Use https instead of http, web server automatically redirects to secure version. Remove slash at the end, not needed. I think this can be squashed with the first patch in the series. Signed-off-by: Frediano Ziglio --- spice-protocol.spec.in | 4

Re: [Spice-devel] [PATCH spice-protocol 3/5] build-sys: Allows spec file to build MingW packages

2019-10-21 Thread Eduardo Lima (Etrunko)
On 10/11/19 6:56 AM, Frediano Ziglio wrote: Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 It's possible to disable MingW build using $ rpmbuild --without mingw -ta spice-protocol-.tar.bz2 This is base on some work by

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-16 Thread Eduardo Lima (Etrunko)
On 10/14/19 10:18 AM, Frediano Ziglio wrote: Hi, On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: This series is part from a former series. There's an initial import commit to better understand the changes. It contains some work from Eduardo for MingW packaging. Final patches a

Re: [Spice-devel] [spice-gtk v1 5/6] spice-gstaudio: fix GTask leak on query for volume

2019-09-04 Thread Eduardo Lima (Etrunko)
,6 +680,7 @@ static void > spice_gstaudio_get_record_volume_info_async(SpiceAudio *audio, > GTask *task = g_task_new(audio, cancellable, callback, user_data); > > g_task_return_boolean(task, TRUE); > +g_object_unref(task);

Re: [Spice-devel] [PATCH spice-server] meson: Fix compatibility with Meson 0.48

2019-08-30 Thread Eduardo Lima (Etrunko)
c0..35ebf3833 100644 > --- a/meson.build > +++ b/meson.build > @@ -211,7 +211,6 @@ if host_machine.system() == 'windows' > endif > > configure_file(output : 'config.h', > - install : false, > configuration : spice_s

Re: [Spice-devel] [PATCH spice-gtk] build: Fix compatibility with Meson 0.49

2019-08-29 Thread Eduardo Lima (Etrunko)
cfa711..4727c19d 16 > --- a/subprojects/spice-common > +++ b/subprojects/spice-common > @@ -1 +1 @@ > -Subproject commit 5bcfa711d90839c7c4c50310db67f0d5912a3824 > +Subproject commit 4727c19d36b33071928500adaa832ecef6bdd942 > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-server 2/2] meson: Remove a warning in spice-common

2019-08-29 Thread Eduardo Lima (Etrunko)
- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/subprojects/spice-common b/subprojects/spice-common > index ff2e99d89..4727c19d3 16 > --- a/subprojects/spice-common > +++ b/subprojects/spice-common > @@ -1 +1 @@ > -Subproject commit ff2e99d8932db6b30b

Re: [Spice-devel] [PATCH spice-common] meson: Remove "install" argument from configure_file

2019-08-28 Thread Eduardo Lima (Etrunko)
utput : 'config.h', > - install : false, > configuration : spice_common_config_data) > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___

Re: [Spice-devel] [PATCH spice-common] build: Remove unused git-version-gen file

2019-05-29 Thread Eduardo Lima (Etrunko)
ot;$v" | sed 's/-/./;s/\(.*\)-g/\1-/'`; > -else > -v=UNKNOWN > -fi > - > -v=`echo "$v" |sed 's/^v//'` > - > -# Don't declare a version "dirty" merely because a time stamp has changed. > -git update-index --refresh > /

Re: [Spice-devel] [PATCH spice-gtk] build: Do not attempt to distribute not present file

2019-04-24 Thread Eduardo Lima (Etrunko)
po/meson.build \ > build-aux/git-version-gen \ > - build-aux/meson/check-spice-common \ > gtk-doc.make\ > .version \ > $(NULL) > Acked-by: Edu

Re: [Spice-devel] [PATCH] build-sys: Add README.md to the tarball

2019-04-12 Thread Eduardo Lima (Etrunko)
README.md \ > CHANGELOG.md\ > data/70-spice-vdagentd.rules \ > data/spice-vdagent.desktop \ > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat

Re: [Spice-devel] [spice-protocol] build-sys: add README.md and CHANGELOG.md to tarball

2019-04-12 Thread Eduardo Lima (Etrunko)
\ > + README.md \ > + CHANGELOG.md \ > + meson.build > > -include $(top_srcdir)/git.mk > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@re

Re: [Spice-devel] [linux/vd-agent v1 0/2] Prepare for 0.19.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
t; And the formatted changelog at: > > > https://gitlab.freedesktop.org/victortoso/vd_agent/blob/284fb7aab016b436d59b06fbcc3539e8abc149a4/CHANGELOG.md > Looking good. For the series Acked-by: Eduardo Lima (Etrunko) > Cheers, > > Victor Toso (2): > build-sys: ne

Re: [Spice-devel] [spice-protocol v2 6/6] NEWS: prepare for 0.14.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
_TUNNEL_* and SPICE_MSGC_TUNNEL_* > +* Add VDAgentGraphicsDeviceInfo message > +* Add StreamMsgGraphicsDeviceInfo message > +* Add padding to SpiceStat structure > + > Major changes in 0.12.15 > ============ > * Add support for h265 video codec > With that small

Re: [Spice-devel] [spice-protocol v2 5/6] README: Add basic info and .md prefix

2019-04-12 Thread Eduardo Lima (Etrunko)
linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/qxl > +[win32/qxl]: https://gitlab.freedesktop.org/spice/win32/qxl > +[win32/qxl-wddm-dod]: https://gitlab.freedesktop.org/spice/win32/qxl-wddm-dod > +[report bugs]: https://gitlab.freedesktop

Re: [Spice-devel] [spice-protocol v2 3/6] ChangeLog: remove old one

2019-04-12 Thread Eduardo Lima (Etrunko)
--git a/ChangeLog b/ChangeLog > deleted file mode 100644 > index e69de29..000 > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ Spice-devel mailing list

Re: [Spice-devel] [spice-protocol v2 4/6] Rename NEWS to CHANGELOG.md

2019-04-12 Thread Eduardo Lima (Etrunko)
md | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename NEWS => CHANGELOG.md (100%) > > diff --git a/NEWS b/CHANGELOG.md > similarity index 100% > rename from NEWS > rename to CHANGELOG.md > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (

Re: [Spice-devel] [spice-protocol v2 1/6] build-sys: automake: do not require NEWS and ChangeLog

2019-04-12 Thread Eduardo Lima (Etrunko)
ONFIG_MACRO_DIR([m4]) > AM_CONFIG_HEADER([config.h]) > > -AM_INIT_AUTOMAKE([dist-bzip2]) > +AM_INIT_AUTOMAKE([foreign dist-bzip2]) > AM_MAINTAINER_MODE > > m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])]) > Acked-by: Eduardo Lima (Etrunko) -- Edu

Re: [Spice-devel] [spice-protocol v2 0/6] Prepare for 0.14.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
| 27 +++ > configure.ac | 2 +- > 6 files changed, 62 insertions(+), 1 deletion(-) > create mode 100644 .gitlab-ci.yml > rename NEWS => CHANGELOG.md (93%) > delete mode 100644 ChangeLog > delete mode 100644 README > create mode 1

Re: [Spice-devel] [PATCH spice-gtk] spice-common: update submodule

2019-04-04 Thread Eduardo Lima (Etrunko)
Add missing G_GNUC_PRINTF annotations > build: Update verify.h to latest version > test-marshallers: Fix header guard > quic: Fix QUIC_VERSION definition > log: Let gcc know about the logging macros which abort > > Eduardo Lima (Etrunko) (5): >

[Spice-devel] [PATCH spice-common v3 3/3] meson: Make targets list store dictionaries instead of lists

2019-04-04 Thread Eduardo Lima (Etrunko)
Access the items by names instead of indexes. Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/common/meson.build b/common/meson.build index 980a32af..9a2725ff 100644

[Spice-devel] [PATCH spice-common v3 2/3] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
spice-gtk. The issue can be observed doing a "find -name \*generated\*.o" in Meson build directory. Signed-off-by: Frediano Ziglio Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/meson.buil

[Spice-devel] [PATCH spice-common v3 1/3] meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
generated at all. Add dependency to the include header to make Meson generate the proper include flag. Signed-off-by: Frediano Ziglio Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 75 +++--- 1 file changed, 45 insertions(+), 30 deletions

[Spice-devel] [PATCH spice-common v3 0/3] Meson build fixes.

2019-04-04 Thread Eduardo Lima (Etrunko)
Following up on Frediano's patches for meson, I added another one to avoid using nested lists, by changing the list items to dictionaries. This is less error prone but adds the complexity of checking for the contents of output list. Regards, Eduardo. Eduardo Lima (Etrunko) (1): meson:

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 11:50 AM, Frediano Ziglio wrote: >> >> On 4/4/19 5:19 AM, Frediano Ziglio wrote: Hi, On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: > spice-gtk and spice-server will use spice_common_client_dep > and spice_common_server_dep as dependencies. >>

[Spice-devel] [PATCH spice-common] fixup! meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 78 +++--- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/common/meson.build b/common/meson.build index 2b7bef00..e5629af4 100644 --- a/common/meson.build +++ b/common

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 5:19 AM, Frediano Ziglio wrote: >> >> Hi, >> >> On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: >>> spice-gtk and spice-server will use spice_common_client_dep >>> and spice_common_server_dep as dependencies. >>> However they will depend on both spice-common client/server

Re: [Spice-devel] [PATCH spice-common v2 1/2] meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 5:08 AM, Victor Toso wrote: > Hi, > > On Wed, Apr 03, 2019 at 05:20:35PM +0100, Frediano Ziglio wrote: >> All generated file depends on generated_messages.h which is >> generated too. >> So add an explicit dependency from all generated file >> (except generated_messages.h generator) to g

Re: [Spice-devel] [PATCH spice-common] recorder: Update

2019-03-29 Thread Eduardo Lima (Etrunko)
ion(-) > > diff --git a/common/recorder b/common/recorder > index 03eb4b6..10b1787 16 > --- a/common/recorder > +++ b/common/recorder > @@ -1 +1 @@ > -Subproject commit 03eb4b6ef7aa90645a7395ea8bea55ebf33d6632 > +Subproject commit 10b178762e1d66d82bdde754385a6a608a730607 >

Re: [Spice-devel] [PATCH spice-server] build: Clean a generated file

2019-03-26 Thread Eduardo Lima (Etrunko)
> +++ b/docs/Makefile.am > @@ -19,4 +19,4 @@ all-local: spice_style.html spice_threading_model.html > endif > > clean-local: > - rm -f spice_style.html > + rm -f spice_style.html spice_threading_model.html > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barro

Re: [Spice-devel] [PATCH spice-common] meson: Remove some useless checks

2019-03-15 Thread Eduardo Lima (Etrunko)
t; - 'floor', > - 'fork', > - 'memmove', > - 'memset', > 'sigaction', > 'drand48'] > > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunk

[Spice-devel] [PATCH spice-server v2 3/3] meson: switch smartcard option to auto feature

2019-02-13 Thread Eduardo Lima (Etrunko)
Make it compatible with spice-common. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 14 ++ meson_options.txt| 3 +-- subprojects/spice-common | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/meson.build b/meson.build index

[Spice-devel] [PATCH spice-server v2 1/3] meson: Use gnu_symbol_visibility keyword introduced in meson 0.48

2019-02-13 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build| 5 ++--- server/meson.build | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 811099c6..459409f6 100644 --- a/meson.build +++ b/meson.build @@ -4,7 +4,7 @@ project('spice

[Spice-devel] [PATCH spice-server v2 2/3] meson: Bump libcacard requirement to 2.5.1

2019-02-13 Thread Eduardo Lima (Etrunko)
This had already been done for autotools in spice-common commit 924f47a653bd87fbd50229ee34b58d7b9a3f1ec8. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build| 15 ++- server/smartcard.c | 4 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/meson.build

[Spice-devel] [PATCH spice-common v2] meson: Bump requirement to 0.48

2019-02-13 Thread Eduardo Lima (Etrunko)
.html#python3-module-is-deprecated Which gets rid of the following warning message: WARNING: Deprecated features used: * 0.48.0: {'python3 module'} Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mes

Re: [Spice-devel] [PATCH spice-server 7/8] agent-msg-filter: Add some comments to AgentMsgFilter structure

2019-02-11 Thread Eduardo Lima (Etrunko)
o the agent >>> gboolean use_client_monitors_config; >>> +// discard all messages, used for example when device is disable to s/disable/disabled >>> discard >>> +// pending data >>> gboolean discard_all; >>> } AgentMsgFilter; &g

Re: [Spice-devel] [PATCH spice-server 7/8] agent-msg-filter: Add some comments to AgentMsgFilter structure

2019-02-11 Thread Eduardo Lima (Etrunko)
> agent, > +// used for messages from the guest to the agent > gboolean use_client_monitors_config; > +// discard all messages, used for example when device is disable to > discard > +// pending data > gboolean discard_all; > } AgentMsgFilter; > > A

Re: [Spice-devel] [PATCH spice-server 4/8] reds: Fix typo in comment

2019-02-11 Thread Eduardo Lima (Etrunko)
estore agent starts when the agent gets attached */ > spice_debug("saving mig_data"); > spice_assert(agent_dev->priv->plug_generation == 0); > agent_dev->priv->mig_data = g_memdup(mig_data, size); > Squash with the next one? Acked-by: Eduard

Re: [Spice-devel] [PATCH spice-server 5/8] dispatcher: Fix typo in comment

2019-02-11 Thread Eduardo Lima (Etrunko)
> -/* no messsage */ > +/* no message */ > return 0; > } > if (type >= dispatcher->priv->max_message_type) { > I think you can squash it with the previous one. Acked-by: Eduardo Lima (Etrunko) -

Re: [Spice-devel] [PATCH spice-server 1/8] smartcard-channel-client: Update usage of GObject private structures

2019-02-11 Thread Eduardo Lima (Etrunko)
ss); > > -g_type_class_add_private(klass, sizeof(SmartCardChannelClientPrivate)); > - > RedChannelClientClass *client_class = RED_CHANNEL_CLIENT_CLASS(klass); > client_class->alloc_recv_buf = > smartcard_channel_client_alloc_msg_rcv_buf; > client_class->release_recv_

[Spice-devel] [PATCH spice-server v3] Update usage of GObject private structures

2019-02-07 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) Signed-off-by: Frediano Ziglio --- in v2: - Squash with Frediano's patch replacing GET_PRIVATE macros with appropriate _get_instance_private() functions. in v3: - Squash Frediano's patch which splits long lines. --- server/char-device.c

Re: [Spice-devel] [PATCH spice-server] fixup! Update usage of GObject private structures

2019-02-07 Thread Eduardo Lima (Etrunko)
On 2/7/19 2:42 PM, Frediano Ziglio wrote: > Split long lines. Sorry, I forgot to break the lines, my bad. I will squash this one as well... Small tip, next time you could use the --in-reply-to="" option for git-send-email to keep the context, especially, with fixup patches like this one. Thank y

[Spice-devel] [PATCH spice-gtk 2/2] meson: Update python module usage

2019-02-07 Thread Eduardo Lima (Etrunko)
Since version 0.48, the python3 module has been deprecated: https://mesonbuild.com/Release-notes-for-0-48-0.html#python3-module-is-deprecated Signed-off-by: Eduardo Lima (Etrunko) --- src/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/meson.build b/src

[Spice-devel] [PATCH spice-gtk 1/2] meson: Drop unused spice_gtk_has_* variables

2019-02-07 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/meson.build b/meson.build index 8e540c9..1276fb9 100644 --- a/meson.build +++ b/meson.build @@ -299,25 +299,20 @@ if d.found() endif # lz4 -spice_gtk_has_lz4 = false d = dependency

[Spice-devel] [PATCH spice-server v2] Update usage of GObject private structures

2019-02-07 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) Signed-off-by: Frediano Ziglio --- in v2: - Squash with Frediano's patch replacing GET_PRIVATE macros with appropriate _get_instance_private() functions. --- server/char-device.c | 8 ++-- server/common-graphics-channel.c

Re: [Spice-devel] [PATCH spice-server] Remove G_TYPE_INSTANCE_GET_PRIVATE call

2019-02-07 Thread Eduardo Lima (Etrunko)
On 2/7/19 6:50 AM, Frediano Ziglio wrote: > Use TYPE_get_instance_private instead which was introduced in GLib > 2.38. > G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58. > > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 4 +--- > server/common-graphics-c

[Spice-devel] [PATCH spice-server] Use new GObject define macros with private

2019-02-06 Thread Eduardo Lima (Etrunko)
G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits Signed-off-by: Eduardo Lima (Etrunko) --- server/char-device.c | 4 +--- server/common-graphics-channel.c | 23 ++- server

Re: [Spice-devel] [PATCH spice-common] Obsolete Glib cleanup

2019-02-06 Thread Eduardo Lima (Etrunko)
s); > @@ -302,7 +299,6 @@ int main(int argc, char **argv) > g_test_add_func("/spice-common/spice-fatal-return-if-fail", > test_spice_fatal_return_if_fail); > g_test_add_func("/spice-common/spice-non-fatal-greturn-if-fail", > test_spice_non_fatal_g_return_if_fail); >

Re: [Spice-devel] [spice-server v2 1/2] build-sys: Raise glib requirement to 2.38

2019-02-05 Thread Eduardo Lima (Etrunko)
B2_REQUIRED]) > GLIB2_CFLAGS="$GLIB2_CFLAGS > -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION \ >-DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@red

Re: [Spice-devel] [PATCH spice-common 2/4] meson: Bump requirement to 0.48

2019-02-04 Thread Eduardo Lima (Etrunko)
gets rid of the following warning message: >> >> WARNING: Deprecated features used: >> * 0.48.0: {'python3 module'} >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> meson.build | 6 +++--- >> 1 file changed, 3 insertions(+), 3 delet

Re: [Spice-devel] [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

2019-02-04 Thread Eduardo Lima (Etrunko)
On 2/4/19 10:45 AM, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> meson.build | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index 80e4b1c..e26d817

[Spice-devel] [PATCH spice-jhbuild] Build spice modules with meson

2019-02-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- jhbuildrc| 2 ++ modulesets/spice.xml | 35 ++- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/jhbuildrc b/jhbuildrc index 8b15ef6..1fb1c0e 100644 --- a/jhbuildrc +++ b/jhbuildrc @@ -11,6

[Spice-devel] [PATCH spice-server 1/2] meson: Bump libcacard requirement to 2.5.1

2019-02-04 Thread Eduardo Lima (Etrunko)
This had already been done for autotools in spice-common commit 924f47a653bd87fbd50229ee34b58d7b9a3f1ec8. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build| 15 ++- server/smartcard.c | 4 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/meson.build

[Spice-devel] [PATCH spice-common 4/4] meson: switch smartcard option to auto feature

2019-02-04 Thread Eduardo Lima (Etrunko)
In spice-gtk commit dbdf692909f7a2b272b06a674a38a1aeb4303032, the smartcard option has been changed from boolean to feature, which actually broke the option yeld, because the option type is incompatible between superproject and subproject. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build

[Spice-devel] [PATCH spice-server 2/2] meson: switch smartcard option to auto feature

2019-02-04 Thread Eduardo Lima (Etrunko)
Make it compatible with spice-common. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 14 ++ meson_options.txt | 3 +-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/meson.build b/meson.build index f6580fc2..ec1518ec 100644 --- a/meson.build +++ b

[Spice-devel] [PATCH spice-common 3/4] meson: Bump libcacard requirement to 2.5.1

2019-02-04 Thread Eduardo Lima (Etrunko)
Commit 924f47 did this for autotools, do the same for meson. Signed-off-by: Eduardo Lima (Etrunko) --- common/messages.h | 4 meson.build | 6 -- 2 files changed, 10 deletions(-) diff --git a/common/messages.h b/common/messages.h index 2399b08..3e37235 100644 --- a/common

[Spice-devel] [PATCH spice-common 2/4] meson: Bump requirement to 0.48

2019-02-04 Thread Eduardo Lima (Etrunko)
-is-deprecated Which gets rid of the following warning message: WARNING: Deprecated features used: * 0.48.0: {'python3 module'} Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.b

[Spice-devel] [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

2019-02-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 80e4b1c..e26d817 100644 --- a/meson.build +++ b/meson.build @@ -164,8 +164,7 @@ endif # # global C defines # -glib_major_minor

Re: [Spice-devel] [PATCH spice-server 2/3] meson: Use dictionaries addition feature

2019-01-30 Thread Eduardo Lima (Etrunko)
On 1/30/19 11:25 AM, Frediano Ziglio wrote: >> >> Since meson 0.48 it is possible to 'add' to dictionaries as well. Make >> use of this feature in our build. >> >> http://mesonbuild.com/Release-notes-for-0-48-0.html#dictionary-addition &g

[Spice-devel] [PATCH spice-server 1/2] m4: Remove repeated warnings suppression

2019-01-30 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- m4/spice-compile-warnings.m4 | 3 --- 1 file changed, 3 deletions(-) diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4 index 5a601209..2081475e 100644 --- a/m4/spice-compile-warnings.m4 +++ b/m4/spice-compile-warnings.m4 @@ -51,9

[Spice-devel] [PATCH spice-server 2/2] meson: Add option to enable all warnings

2019-01-30 Thread Eduardo Lima (Etrunko)
Currently on the main meson.build file, this could be moved to a subdirectory in a dedicated meson.build file for this sole purpose. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 220 +-- meson_options.txt| 4 + subprojects

[Spice-devel] [PATCH spice-server 1/3] meson: Use underscorify() instead of split()

2019-01-30 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 5f402a5f..811099c6 100644 --- a/meson.build +++ b/meson.build @@ -192,8 +192,7 @@ endif # # global C defines # -glib_major_minor

[Spice-devel] [PATCH spice-server 3/3] meson: Use gnu_symbol_visibility keyword introduced in meson 0.48

2019-01-30 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build| 3 +-- server/meson.build | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 29af6b04..14febb7e 100644 --- a/meson.build +++ b/meson.build @@ -36,8 +36,7 @@ spice_server_so_version

[Spice-devel] [PATCH spice-server 0/3] Meson build improvements

2019-01-30 Thread Eduardo Lima (Etrunko)
implemented. Eduardo Lima (Etrunko) (3): meson: Use underscorify() instead of split() meson: Use dictionaries addition feature meson: Use gnu_symbol_visibility keyword introduced in meson 0.48 meson.build | 8 +++--- server/meson.build | 3 ++- server/tests/meson.build

[Spice-devel] [PATCH spice-server 2/3] meson: Use dictionaries addition feature

2019-01-30 Thread Eduardo Lima (Etrunko)
Since meson 0.48 it is possible to 'add' to dictionaries as well. Make use of this feature in our build. http://mesonbuild.com/Release-notes-for-0-48-0.html#dictionary-addition Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 2 +- server/tests/meson.

Re: [Spice-devel] [PATCH spice-server] ci: Remove dependencies from copr build

2019-01-23 Thread Eduardo Lima (Etrunko)
r1-devel gstreamer1-plugins-base-devel > -y > - - dnf copr enable @spice/nightly -y > - - dnf builddep spice -y > + - git clone ${CI_REPOSITORY_URL/spice.git/spice-protocol.git} > + - (cd spice-protocol && ./autogen.sh --prefix=/usr && make install) > >

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Remove useless return statement

2018-12-03 Thread Eduardo Lima (Etrunko)
On 11/29/18 3:42 PM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > src/spice-widget.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index 312c640a..9bb42211 100644 > --- a/src/spice-widget.c > +++ b/src/spice-widget.c > @@ -

Re: [Spice-devel] [PATCH spice-server 5/5] tests: Add a small test for red_record_ APIs

2018-11-16 Thread Eduardo Lima (Etrunko)
", &version), ==, 1); > + > +int w, t; > +g_assert_nonnull(fgets(line, sizeof(line), f)); > +g_assert_cmpint(sscanf(line, "event %*d %d %d", &w, &t), ==, 2); > +g_assert_cmpint(w, ==, 1); > +g_assert_cmpint(t, ==, 123); > + > +g_assert_null(fgets(line, sizeof(line), f)); > + > +if (!compress) { > +fclose(f); > +} else { > +pclose(f); > +} > + > +// clean test output file > +unlink(fn); > +} > + > +int > +main(void) > +{ > +test_record(false); > +test_record(true); > +return 0; > +} > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-server 2/5] test-leaks: Avoid clashing with test-display-base ports

2018-11-16 Thread Eduardo Lima (Etrunko)
PKI_DIR "server-cert.pem", > PKI_DIR "server-key.pem", > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ Spice-devel

Re: [Spice-devel] [PATCH spice-server 1/5] test-display-base: Fix warning message avoidance

2018-11-16 Thread Eduardo Lima (Etrunko)
LL && > // bind failure > +strstr(message, "reds_init_socket: listen: ") == NULL && // listen > failure > +strstr(message, "Failed to open SPICE sockets") == NULL) { // global > g_print("XXX [%s]\n", message)

Re: [Spice-devel] [PATCH spice-server 1/2] ci: Merge new glib.supp file

2018-11-16 Thread Eduardo Lima (Etrunko)
# some ioctls use that argument as an integer > { > @@ -502,16 +544,6 @@ > fun:g_object_new_valist > } > > -{ > - getaddrinfo > - Memcheck:Leak > - fun:malloc > - ... > - fun:__resolv_conf_allocate > - ... > - fun:getaddrinfo > -} >

Re: [Spice-devel] [PATCH spice-server 2/2] ci: Ignore leak from GnuTLS p11 call

2018-11-16 Thread Eduardo Lima (Etrunko)
+572,13 @@ > ... > fun:gnutls_rnd > } > + > +{ > + gnutls_tls_p11_kit_leak > + Memcheck:Leak > + fun:malloc > + ... > + fun:__tls_get_addr > + ... > + fun:p11_kit_modules_load > +} > Acked-by: Eduardo Lima (Etrunk

Re: [Spice-devel] [spice-common] Remove config.h from header files

2018-10-04 Thread Eduardo Lima (Etrunko)
on/messages.h > +++ b/common/messages.h > @@ -31,10 +31,6 @@ > #ifndef _H_MESSAGES > #define _H_MESSAGES > > -#ifdef HAVE_CONFIG_H > -#include "config.h" > -#endif > - > #include > #include > > Acked-by: Eduardo Lima (Etrunko)

Re: [Spice-devel] [PATCH spice-server] ci: Use release build with Meson

2018-09-28 Thread Eduardo Lima (Etrunko)
ld > + - meson --buildtype=release -Dstatistics=true -Dsasl=false > -Dcelt051=disabled build >- ninja -C build >- (cd build && meson test) || (cat build/meson-logs/testlog.txt && exit 1) > > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barr

[Spice-devel] [PATCH spice-gtk 3/3] m4: Remove duplicate warnings settings

2018-09-27 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- m4/spice-compile-warnings.m4 | 9 - 1 file changed, 9 deletions(-) diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4 index 0ae3bd7..a7a6ff3 100644 --- a/m4/spice-compile-warnings.m4 +++ b/m4/spice-compile-warnings.m4

[Spice-devel] [PATCH spice-gtk 1/3] meson: Use underscorify() instead of split()

2018-09-27 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 48f5f74..4e4bee8 100644 --- a/meson.build +++ b/meson.build @@ -368,14 +368,12 @@ endif # # global C defines # -glib_major_minor

[Spice-devel] [PATCH spice-gtk 2/3] tests: Add missing static statement

2018-09-27 Thread Eduardo Lima (Etrunko)
-prototypes] gboolean cancel_test(gpointer user_data) ^~~ Signed-off-by: Eduardo Lima (Etrunko) --- tests/usb-acl-helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/usb-acl-helper.c b/tests/usb-acl-helper.c index 2b28ade..b24f452 100644 --- a/tests

Re: [Spice-devel] [PATCH spice-gtk 4/5] meson: Add json-glib to the list of mandatory deps

2018-09-27 Thread Eduardo Lima (Etrunko)
On 9/26/18 5:26 AM, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> meson.build | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index 629f109..ebd42e1

[Spice-devel] [PATCH spice-gtk v2] meson: Remove unecessary variable spice_protocol_min_version

2018-09-27 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index eba2c38..76fb0cd 100644 --- a/meson.build +++ b/meson.build @@ -30,7 +30,6 @@ spice_gtk_global_cflags = ['-DHAVE_CONFIG_H'

Re: [Spice-devel] [PATCH spice-gtk 3/5] meson: Remove unecessary variable spice_protocol_min_version

2018-09-27 Thread Eduardo Lima (Etrunko)
On 9/26/18 5:16 AM, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> meson.build | 7 +++ >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index eba2c38..629f109

Re: [Spice-devel] [PATCH spice-server 1/2] Bump meson requirement to 0.47.2

2018-09-26 Thread Eduardo Lima (Etrunko)
On 9/26/18 6:48 AM, Christophe Fergeau wrote: > On Wed, Sep 26, 2018 at 10:50:26AM +0200, Victor Toso wrote: >> Hi, >> >> On Wed, Sep 26, 2018 at 10:25:56AM +0200, Christophe Fergeau wrote: >>> NB: The newer meson we require, the harder it will be to say "ok, from >>> now on, we'll be switching to

[Spice-devel] [PATCH spice-server 1/2] Bump meson requirement to 0.47.2

2018-09-25 Thread Eduardo Lima (Etrunko)
This new version ships the fix for the issue where 'check' keyword could not be used in project definition, so we had to run that command again only to check if it succeeded. https://github.com/mesonbuild/meson/issues/3944 Signed-off-by: Eduardo Lima (Etrunko) --- meson.

[Spice-devel] [PATCH spice-server 2/2] meson: Add spice-protocol as subproject

2018-09-25 Thread Eduardo Lima (Etrunko)
Fixes the cases where either the dependency is not installed or the version installed does not satisfy the requirement. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 4 ++-- subprojects/spice-protocol.wrap | 4 2 files changed, 6 insertions(+), 2 deletions

[Spice-devel] [PATCH spice-gtk 3/5] meson: Remove unecessary variable spice_protocol_min_version

2018-09-25 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index eba2c38..629f109 100644 --- a/meson.build +++ b/meson.build @@ -30,7 +30,6 @@ spice_gtk_global_cflags = ['-DHAVE_CONFIG_H'

[Spice-devel] [PATCH spice-gtk 5/5] meson: Add spice-protocol as subproject

2018-09-25 Thread Eduardo Lima (Etrunko)
Fixes the cases where either the dependency is not installed or the version installed does not satisfy the requirement. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 4 ++-- subprojects/spice-protocol.wrap | 4 2 files changed, 6 insertions(+), 2 deletions

[Spice-devel] [PATCH spice-gtk 4/5] meson: Add json-glib to the list of mandatory deps

2018-09-25 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 629f109..ebd42e1 100644 --- a/meson.build +++ b/meson.build @@ -88,10 +88,9 @@ foreach dep, version : deps spice_gtk_deps

[Spice-devel] [PATCH spice-gtk 1/5] Bump meson requirement to 0.47.2

2018-09-25 Thread Eduardo Lima (Etrunko)
This new version ships the fix for the issue where 'check' keyword could not be used in project definition, so we had to run that command again only to check if it succeeded. https://github.com/mesonbuild/meson/issues/3944 Signed-off-by: Eduardo Lima (Etrunko) --- meson.

[Spice-devel] [PATCH spice-gtk 2/5] meson: Remove unnecessary variable spice_gtk_libs

2018-09-25 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 1 - src/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/meson.build b/meson.build index 85f6e78..eba2c38 100644 --- a/meson.build +++ b/meson.build @@ -32,7 +32,6 @@ compiler = meson.get_compiler(&#

[Spice-devel] [PATCH spice-gtk 0/5] Meson build cleanups

2018-09-25 Thread Eduardo Lima (Etrunko)
a built-in vcs_tag() function in meson that may be used to replace calling the script altogether. Follow the discussion at: https://github.com/mesonbuild/meson/issues/688 Eduardo Lima (Etrunko) (5): Bump meson requirement to 0.47.2 meson: Remove unnecessary variable spice_gtk_libs meson

Re: [Spice-devel] [spice-gtk v1 4/4] channel-usbredir: Chain-up with parent's channel-reset

2018-09-25 Thread Eduardo Lima (Etrunko)
On 9/6/18 11:13 AM, Victor Toso wrote: > From: Victor Toso > > Otherwise spice-channel is left with a broken state. > > This code moves parent's call to channel_reset() into > _channel_reset_finish() - Note that spice-channel's channel_reset() > can be called from GMainContext. > I think it wo

Re: [Spice-devel] [spice-gtk] Fix typo in SPICE_DEBUG

2018-09-25 Thread Eduardo Lima (Etrunko)
gt; Cheers, > > On Tue, Sep 25, 2018 at 12:02:05PM -0300, Eduardo Lima (Etrunko) wrote: >> On 9/25/18 11:56 AM, Victor Toso wrote: >>> From: Christophe de Dinechin >>> >>> --- >>> src/channel-display-gst.c | 2 +- >>> 1 file changed, 1

Re: [Spice-devel] [spice-gtk] Fix typo in SPICE_DEBUG

2018-09-25 Thread Eduardo Lima (Etrunko)
>win_handle == 0) { > sink = gst_element_factory_make("appsink", "sink"); > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-protocol] meson: Add declare_dependency statement

2018-09-25 Thread Eduardo Lima (Etrunko)
This is required in the case another project uses this one as a subproject Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 31531e2..55cef0c 100644 --- a/meson.build +++ b/meson.build @@ -8,6 +8,8

Re: [Spice-devel] [PATCH spice-gtk] gitabl-ci: fix CI build

2018-09-25 Thread Eduardo Lima (Etrunko)
On 9/24/18 6:04 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > I broke gitlab CI in commit f61534d by introducing json-glib > dependency. Instead of depending on dnf builddep, list the build > dependencies explicitly. > > Remove copr usage, that fails from time to time. Ins

Re: [Spice-devel] [PATCH spice-server] syntax-check: Add missing contributors names to AUTHORS

2018-09-19 Thread Eduardo Lima (Etrunko)
lso contributed by > Axel Lin > 소병철 > Cédric Bosdonnat > +Changqing Li > Christian Ruppert > Christophe de Dinechin > Cole Robinson > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (

  1   2   3   4   5   >