Re: [Spice-devel] [PATCH libcacard 1/2] vscclient: Catch write errors

2018-08-09 Thread Jason Andryuk
On Fri, Jul 27, 2018 at 4:07 AM, Frediano Ziglio wrote: >> >> On Wed, Jul 25, 2018 at 5:53 AM, Frediano Ziglio wrote: >> >> >> >> The GIOStatus return value indicates errors, so catch it and check it to >> >> know if we should return an

Re: [Spice-devel] [PATCH libcacard 2/2] vreader: Handle read failure

2018-08-09 Thread Jason Andryuk
On Thu, Aug 9, 2018 at 5:35 AM Christophe Fergeau wrote: > > On Thu, Aug 09, 2018 at 09:26:35AM +0200, Jakub Jelen wrote: > > On Wed, 2018-08-08 at 14:08 -0400, Jason Andryuk wrote: > > > On Wed, Aug 8, 2018 at 11:33 AM Jakub Jelen > > > wrote: > > > >

Re: [Spice-devel] [PATCH libcacard 2/2] vreader: Handle read failure

2018-08-08 Thread Jason Andryuk
On Wed, Aug 8, 2018 at 11:33 AM Jakub Jelen wrote: > > On Wed, 2018-08-08 at 16:51 +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, Jul 24, 2018 at 8:34 PM, Jason Andryuk > > wrote: > > > If a command fails, card_status will not match VCARD_DONE. T

Re: [Spice-devel] [PATCH libcacard 1/2] vscclient: Catch write errors

2018-07-26 Thread Jason Andryuk
On Wed, Jul 25, 2018 at 5:53 AM, Frediano Ziglio wrote: >> >> The GIOStatus return value indicates errors, so catch it and check it to >> know if we should return an error. >> >> Signed-off-by: Jason Andryuk >> --- >> Truth be told, I can't r

[Spice-devel] [PATCH libcacard 2/2] vreader: Handle read failure

2018-07-25 Thread Jason Andryuk
removing the physical smartcard mid-operation. Signed-off-by: Jason Andryuk --- src/vreader.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/vreader.c b/src/vreader.c index 2d8aa9f..148f65b 100644 --- a/src/vreader.c +++ b/src/vreader.c @@ -256,6 +256,7

[Spice-devel] [PATCH libcacard 0/2] Error handling improvements

2018-07-25 Thread Jason Andryuk
These two patches make some improvements to libcacard error handling. They were tested out in passthru mode from QEMU to an physical smartcard. Jason Andryuk (2): vscclient: Catch write errors vreader: Handle read failure src/vreader.c | 12 +++- src/vscclient.c | 11

[Spice-devel] [PATCH libcacard 1/2] vscclient: Catch write errors

2018-07-25 Thread Jason Andryuk
The GIOStatus return value indicates errors, so catch it and check it to know if we should return an error. Signed-off-by: Jason Andryuk --- Truth be told, I can't remember exactly why I had to write this. Could status be G_IO_STATUS_ERROR, but err still be NULL? Since I added debugging o