Hi Michael,
>
> Hi,
>
> Disclaimer I am not a Spice developer. But we are very interested in
> this patch series for our project, so I have tested it extensively.
> For Qemu I used your vfio_dmabuf_2 branch.
>
> First I tested it with intel gvt-g and it works perfectly.
>
>
> In the next test
Hi Frediano,
>
> Hi,
>I spent quite some time this weekend trying to use this new series
> but I'm getting all blank screen for some reasons. Last time I got
> something so the encoder was working on the system.
Which encoder did you try with? x264enc or msdkh264enc?
If it is the latter, I am
Hi Frediano,
> >
> > For clients that cannot accept a dmabuf fd directly (such as those
> > running on a remote system), this patch series provides a way for
> > the Spice server to stream the gl/dmabuf data/buffer instead. This
> > is mostly done by enabling the creation of Gst memory using a dma
Acked-by: Vivek Kasireddy
>
> In case the H/W decoder is not able to decode the stream (like too high
> profile) try the S/W version.
> This is done detecting the failure and trying to recreate the pipeline
> in case:
> - we are using a H/W pipeline;
> - we didn't decode any frame (otherwise it
Acked-by: Vivek Kasireddy
>
> This patch fixes a leak due to not freeing GstBus watch.
> The watch is attached (as GSource) to the main loop and retains
> a pointer to the bus so we need to remove it to release the bus
> when we release the pipeline.
> This was detected forcibly creating and des
Hi Frediano,
>
> This patch fixes a leak due to not freeing GstBus watch.
> The watch is attached (as GSource) to the main loop and retains
> a pointer to the bus so we need to remove it to release the bus
> when we release the pipeline.
> This was detected forcibly creating and destroying lot of
Hi Frediano,
>
> In case the H/W decoder is not able to decode the stream (like too high
> profile) try the S/W version.
> This is done detecting the failure and trying to recreate the pipeline
> in case:
> - we are using a H/W pipeline;
> - we didn't decode any frame (otherwise it means we lost
Hi Frediano,
>
> Although currently after free_pipeline we free the entire structure
> the name and the function suggests that we only free the pipeline.
> Also this is fixing a future possible problem with the series
> from Vivek Kasireddy reusing the SpiceGstDecoder for another
> pipeline if H/
Hi Frediano,
> >
> > >
> > > Hi Vivek,
> > >I finally came up with something better.
> > >
> > > See https://gitlab.freedesktop.org/fziglio/spice-gtk/-
> > > /commits/hw_decoding/,
> > > it contains
> > > - https://gitlab.freedesktop.org/fziglio/spice-gtk/-
> > > /commit/52d8622bf620f2ad47d6f0
Hi Frediano,
>
> Hi Vivek,
>I finally came up with something better.
>
> See https://gitlab.freedesktop.org/fziglio/spice-gtk/-
> /commits/hw_decoding/,
> it contains
> - https://gitlab.freedesktop.org/fziglio/spice-gtk/-
> /commit/52d8622bf620f2ad47d6f001926ed918d50d30cd,
> fix some leaks,
Hi Frediano,
> >
> > > > From: Hazwan Arif Mazlan
> > > >
> > > > Using NV12 as the output format for the videoconvert element would
> > > > allow us to pair a s/w based encoder with a h/w based decoder for
> > > > decoding the stream as most h/w based decoders only accept NV12 as
> > > > the inp
Hi Frediano,
> >
> > It looks like setting the Gst pipeline state to GST_STATE_NULL
> > would cause all the references on most of the objects associated
> > with the pipeline to be dropped; therefore, there is no need
> > to explicitly unref them while freeing the pipeline. This patch
> > prevents
Hi Frediano,
> >
> > Once it is determined that an Intel GPU is available/active (after
> > looking into udev's database), we try to see if there is a h/w
> > based encoder (element) available (in Gstreamer's registry cache)
> > for the user selected video codec. In other words, if we find that
>
Hi Frediano,
> >
> > Adding the string "stream-format=byte-stream" to decoder capabilities
> > (dec_caps) for h264/h265 codecs stops Gstreamer from complaining
> > about missing stream format.
> >
> > Cc: Frediano Ziglio
> > Cc: Dongwon Kim
> > Cc: Jin Chung Teng
> > Cc: Hazwan Arif Mazlan
> >
Hi Frediano,
> >
> > If playbin3 is available (checked in Gstreamer registry), it makes
> > sense to prefer it given the major improvements and features it offers
> > including the capability to handle higher bitrates.
> >
> > Cc: Frediano Ziglio
> > Cc: Dongwon Kim
> > Cc: Hazwan Arif Mazlan
>
Hi Frediano,
> > From: Hazwan Arif Mazlan
> >
> > Using NV12 as the output format for the videoconvert element would
> > allow us to pair a s/w based encoder with a h/w based decoder for
> > decoding the stream as most h/w based decoders only accept NV12 as
> > the input format given its populari
Hi Frediano,
> > Given that libudev is widely available on many distros, we can
> > use the relevant APIs to iterate over all the PCI devices on
> > any given system to identify if a GPU is available by looking
> > at the driver name associated with it.
> >
> > This capability (identifying GPU Ven
Hi Frediano,
> Il giorno ven 31 mar 2023 alle ore 08:52 Kasireddy, Vivek
> ha scritto:
> >
> > Hi Frediano,
> >
> > >
> > > Il giorno lun 27 mar 2023 alle ore 07:53 Kasireddy, Vivek
> > > ha scritto:
> > > >
> > > > Hi
Hi Frediano,
>
> Il giorno lun 27 mar 2023 alle ore 07:53 Kasireddy, Vivek
> ha scritto:
> >
> > Hi Frediano,
> >
> > >I was trying the patch series but the client keeps crashing. I
> > > tried different versions of remote-viewer (from Fedora
Hi Frediano,
>I was trying the patch series but the client keeps crashing. I
> tried different versions of remote-viewer (from Fedora and from
> Ubuntu) and they both crashed.
> On host I installed Intel VA drivers , Gstreamer VAAPIs and forced
> gstreamer:h264 as encoder.
[K
ations.
> >
> > Here is the flow of things from the Spice server side:
> > - The application calls gl_scanout (to update the fd) and gl_draw_async
> > and also sets the flag to indicate whether it is dealing with a local
> > or remote client.
>
> That's weir
l to ensure that gl_draw or other associated
> > messages are only sent to local clients.
> >
>
> It's spice server that knows if the client are local or remote,
> there's no need to have a configuration in Qemu.
[Kasireddy, Vivek] Ok, I can get rid of this parameter. How
Hi Frediano,
>
> Il giorno ven 13 gen 2023 alle ore 04:08 Kasireddy, Vivek
> ha scritto:
> >
> > Hi Frediano,
> >
> > >
> > > Il giorno gio 12 gen 2023 alle ore 07:03 Kasireddy, Vivek
> > > ha scritto:
> > > >
> > > &g
Hi Frediano,
>
> Il giorno ven 13 gen 2023 alle ore 04:08 Kasireddy, Vivek
> ha scritto:
> >
> > Hi Frediano,
> >
> > >
> > > Il giorno gio 12 gen 2023 alle ore 07:03 Kasireddy, Vivek
> > > ha scritto:
> > > >
> > &g
Hi Frediano,
>
> Il giorno gio 12 gen 2023 alle ore 07:03 Kasireddy, Vivek
> ha scritto:
> >
> > Hi Frediano,
> >
> > Thank you for taking a look at this patch series.
> >
> > >
> > > Il giorno mer 11 gen 2023 alle ore 05:42 Vivek Kasire
Hi Frediano,
>
> Il giorno gio 12 gen 2023 alle ore 07:03 Kasireddy, Vivek
> ha scritto:
> >
> > Hi Frediano,
> >
> > >
> > > Il giorno mer 11 gen 2023 alle ore 05:42 Vivek Kasireddy
> > > ha scritto:
> > > >
> > > &g
You are adding a public function which, I suppose, should be called by
> Qemu but you are stating the encoder is calling it.
> Unless Qemu is the encoder it does not make sense.
[Kasireddy, Vivek] Sorry for the poor, misleading description. I originally
had this patch split into two, one for each
(memslot_get_virt(slots, addr,
> sizeof(*qxl), group_id));
> > @@ -1059,6 +1060,13 @@ static bool red_get_native_drawable(QXLInstance
> *qxl_instance, RedMemSlotInfo *s
> > red_get_rect_ptr(&red->surfaces_rects[i], &qxl->surfaces_rects[i]);
> > }
&g
28 matches
Mail list logo
