On Fri, Jan 15, 2021 at 3:18 AM Alex Bennée wrote:
>
> Keiichi Watanabe writes:
>
> > This is the v4 RFC of virtio video device specification.
> > PDF versions are available at [1, 2].
> >
> > Note that this patch depends on a recent patchset "
uffer.
Best regards,
Keiichi
>
> Thanks in advance.
>
> Best regards,
> Dmitry.
>
> On Dienstag, 23. Juni 2020 13:13:24 CEST Keiichi Watanabe wrote:
> >
> > This is the v4 RFC of virtio video device specification.
> > PDF versions are available at [1, 2].
>
/chromiumos/third_party/kernel/+/2164411
Keiichi Watanabe (1):
virtio-video: Add virtio video device specification
.gitignore|1 +
content.tex |1 +
images/video-buffer-lifecycle.dot | 18 +
make-setup-generated.sh |8 +
virtio-vid
The virtio video encoder and decoder devices are virtual devices that
support video encoding and decoding respectively. Despite being different
devices, they use the same protocol.
Signed-off-by: Dmitry Sepp
Signed-off-by: Keiichi Watanabe
Signed-off-by: Alexandre Courbot
---
.gitignore
Hi Dmitry,
On Wed, May 27, 2020 at 9:12 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Montag, 18. Mai 2020 07:17:53 CEST Keiichi Watanabe wrote:
> > > +struct virtio_video_stream_create {
> > > +struct virtio_video_cmd_hdr hdr;
> > &g
Hi,
While I'm writing the next version of this proposal, I came up with
some changes on the protocol. Let me share my ideas in advance. I'd
like to hear your idea if you have another thought.
On Thu, Feb 6, 2020 at 7:21 PM Keiichi Watanabe wrote:
>
> From: Dmitry Sepp
>
Hi Dmitry,
On Tue, Apr 21, 2020 at 5:39 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Montag, 20. April 2020 11:57:52 CEST Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Fri, Apr 17, 2020 at 5:09 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
>
Hi Dmitry,
On Thu, Apr 9, 2020 at 10:23 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Donnerstag, 9. April 2020 12:46:56 CEST Keiichi Watanabe wrote:
> > Hi,
> >
> > On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
> &
Hi Dmitry,
On Fri, Apr 17, 2020 at 5:09 PM Dmitry Sepp wrote:
>
> Hi,
>
> On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi Watanabe wrote:
> > Currently, we have three options of the design of per-stream properties:
> >
> > 1. Have two structs for image format
Hi,
On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp wrote:
>
> Hi,
>
> > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream
> > + (context) within the device.
> > +
> > +\begin{lstlisting}
> > +struct virtio_video_stream_destroy {
> > +struct virtio_video_cmd_hdr hdr;
> > +};
> >
Hi Dmitry,
On Tue, Apr 7, 2020 at 6:21 PM Dmitry Sepp wrote:
>
> Hi Alexandre, Keiichi,
>
> Thanks for the updates,
>
> On Montag, 6. April 2020 13:46:33 CEST Keiichi Watanabe wrote:
> >
> > It seems that you're suggesting a big struct where bitstream params
Hi,
Thanks Alex for sharing your idea.
On Mon, Apr 6, 2020 at 6:32 PM Alexandre Courbot wrote:
>
> On Mon, Mar 30, 2020 at 6:54 PM Dmitry Sepp
> wrote:
> >
> > Hi Keiichi,
> >
> > On Freitag, 27. März 2020 04:35:13 CEST Keiichi Watanabe wrote:
> > > H
Hi Dmitry,
On Wed, Mar 25, 2020 at 6:47 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe wrote:
> > Hi,
> >
> > On Mon, Mar 23, 2020 at 10:28 PM Dmitry Sepp
> >
> > wrote:
> > > Hi Keiichi,
> &
Hi,
On Mon, Mar 23, 2020 at 10:28 PM Dmitry Sepp
wrote:
>
> Hi Keiichi,
>
> On Montag, 23. März 2020 13:07:54 CET Keiichi Watanabe wrote:
> > Hi everyone,
> >
> > I have implemented a virtio-video device following my v3 spec in
> > crosvm, which worked w
Hi everyone,
I have implemented a virtio-video device following my v3 spec in
crosvm, which worked well together with Dmitry's driver [1]. I've
started preparing v4 proposal to address problems found while
implementing the driver and the devices.
Regarding v3 protocol, I'm thinking about how we c
On Tue, Mar 17, 2020 at 6:10 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Dienstag, 17. März 2020 07:53:26 CET Keiichi Watanabe wrote:
> > > > diff --git a/include/uapi/linux/virtio_video.h
> > > > b/include/uapi/linux/virtio_video.h new file mode 100644
>
> > diff --git a/include/uapi/linux/virtio_video.h
> > b/include/uapi/linux/virtio_video.h
> > new file mode 100644
> > index ..0dd98a2237c6
> > --- /dev/null
> > +++ b/include/uapi/linux/virtio_video.h
> > @@ -0,0 +1,469 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> I suspect it
On Fri, Mar 13, 2020 at 7:09 PM Dmitry Sepp wrote:
>
> Hi Nicolas, Keiichi,
>
> On Freitag, 13. März 2020 08:54:13 CET Keiichi Watanabe wrote:
> > Hi Nicolas,
> >
> > On Fri, Mar 13, 2020 at 11:29 AM Nicolas Dufresne
> wrote:
> > > Hi Dimitry,
>
ns are not easy to use without
special devices.
So, we might want to have one more virtio-video device implementation
in QEMU in the long term.
It will be somehow similar to virtio-gpu device that is already
implemented in QEMU:
https://github.com/qemu/qemu/blob/master/hw/display/virtio-gpu.c
Best regards,
Ke
On Thu, Mar 12, 2020 at 6:54 PM Hans Verkuil wrote:
>
> On 3/12/20 10:49 AM, Keiichi Watanabe wrote:
> > Hi Hans,
> >
> > On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote:
> >>
> >> Hi Dmitry,
> >>
> >> On 2/18/20 9:27 PM, Dmitry
Hi Hans,
On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote:
>
> Hi Dmitry,
>
> On 2/18/20 9:27 PM, Dmitry Sepp wrote:
> > Hi all,
> >
> > This is a v4l2 virtio video driver for the virtio-video device
> > specification v3 [1].
> >
> > The first version of the driver was introduced here [2].
> >
nts of protocol.
On Tue, Feb 25, 2020 at 7:00 PM Gerd Hoffmann wrote:
>
> On Thu, Feb 06, 2020 at 07:20:57PM +0900, Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to
> > enco
Hi,
On Tue, Feb 25, 2020 at 7:01 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > +/*
> > + * Followed by either
> > + * - struct virtio_video_mem_entry entries[]
> > + * for VIRTIO_VIDEO_MEM_TYPE_GUEST_PAGES
> > + * - struct virtio_video_object_entry entries[]
>
From: Dmitry Sepp
The virtio video encoder device and decoder device provide functionalities to
encode and decode video stream respectively.
Though video encoder and decoder are provided as different devices, they use a
same protocol.
Signed-off-by: Dmitry Sepp
Signed-off-by: Keiichi Watanabe
* Add more detailed description for each command.
* Address review comments.
* Add a feature for exported objects as a separate patch.
Dmitry Sepp (1):
virtio-video: Add virtio video device specification
Keiichi Watanabe (1):
virtio-video: Define a feature for exported objects from different
Define a new feature in the virtio-video protocol to use objects
exported from different virtio devices as video buffers.
Signed-off-by: Keiichi Watanabe
---
virtio-video.tex | 58 +---
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a
Hi,
On Tue, Jan 21, 2020 at 3:44 PM Gerd Hoffmann wrote:
>
> > > > Can't this problem be solved by adding "offset" field in
> > > > virtio_video_mem_entry?
> > > >
> > > > struct virtio_video_mem_entry {
> > > > le64 addr;
> > > > le32 length;
> > > > le32 offset;
> > > > u8 padding[4];
Hi,
On Mon, Jan 20, 2020 at 7:48 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > Hmm, using (ii) the API, then check whenever your three plane buffers
> > > happen to have the correct layout for (1) hardware looks somewhat
> > > backwards to me.
> >
> > Can't this problem be solved by adding "offset" f
Hi,
On Wed, Jan 15, 2020 at 8:26 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > If you have (1) hardware you simply can't import buffers with arbitrary
> > > plane offsets, so I'd expect software would prefer the single buffer
> > > layout (i) over (ii), even when using another driver + dmabuf
> > > e
Hi,
On Wed, Jan 15, 2020 at 8:00 PM Tomasz Figa wrote:
>
> On Mon, Jan 13, 2020 at 10:27 PM Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > > Well, no. Tomasz Figa had splitted the devices into three groups:
> > > >
> > > > (1) requires single buffer.
> > > > (2) allows any layout (including t
epp
> >
> > wrote:
> > > Hi Keiichi,
> > >
> > > On Freitag, 10. Januar 2020 14:53:01 CET Keiichi Watanabe wrote:
> > > > Hi,
> > > >
> > > > On Fri, Jan 10, 2020 at 7:16 PM Dmitry Sepp
> > > >
> >
Hi,
On Tue, Jan 14, 2020 at 7:35 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> thank you for the update.
>
> On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote:
> > Hi,
> >
> > On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
> > > On
Hi,
On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
>
> On Wed, Jan 8, 2020 at 10:52 PM Keiichi Watanabe
> wrote:
> >
> > Hi Gerd,
> >
> > On Thu, Dec 19, 2019 at 10:12 PM Gerd Hoffmann wrote:
> > >
> > > Hi,
> > >
> >
Hi Dmitry,
On Mon, Jan 6, 2020 at 8:28 PM Dmitry Sepp wrote:
>
> Hi,
>
> On Montag, 6. Januar 2020 11:30:22 CET Keiichi Watanabe wrote:
> > Hi Dmitry, Tomasz,
> >
> > On Fri, Jan 3, 2020 at 10:05 PM Dmitry Sepp
> wrote:
> > > Hi Tomasz, Keiichi,
>
Hi Gerd,
On Thu, Dec 19, 2019 at 10:12 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > However that still doesn't let the driver know which buffers will be
> > > dequeued when. A simple example of this scenario is when the guest is
> > > done displaying a frame and requeues the buffer back to the decod
Hi Dmitry,
On Wed, Dec 18, 2019 at 10:02 PM Keiichi Watanabe wrote:
>
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities to
> encode and decode video stream respectively.
> Though video encoder and decoder are provided as diffe
Hi Dmitry,
On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> thanks for the updates, please see my comments below.
>
> On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Mon, Jan 6, 2020 at 11:
Hi Dmitry,
On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
> wrote:
> > > Hi Keiichi,
> &g
On Wed, Jan 8, 2020 at 10:11 PM Dmitry Sepp wrote:
>
> Hi Tomasz, Keiichi,
>
> On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote:
> > On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe
> wrote:
> > > Hi Dmitry,
> > >
> > > On Wed, Jan 8,
Hi,
On Fri, Jan 10, 2020 at 7:16 PM Dmitry Sepp wrote:
>
> Hi,
>
> On Donnerstag, 9. Januar 2020 15:56:08 CET Dmitry Sepp wrote:
> > Hi,
> >
> > On Dienstag, 7. Januar 2020 11:25:56 CET Keiichi Watanabe wrote:
> > > Hi Dmitry,
> > >
Hi Gerd,
Thank you so much for the review. I'm sorry for not replying earlier.
On Thu, Dec 19, 2019 at 10:02 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > Not clearly defined in the spec: When is the decoder supposed to send
> > > the response for a queue request? When it finished decoding (i.e. fr
On Wed, Jan 8, 2020 at 9:46 PM Tomasz Figa wrote:
>
> On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote:
> >
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
> > wrote:
> > >
> > > Hi Keiichi,
> > >
> &
Hi Dmitry,
On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp wrote:
>
> Hi,
>
> a couple of new comments:
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provi
Hi Dmitry,
On Sat, Jan 4, 2020 at 12:47 AM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> &g
Hi Dmitry, Tomasz,
On Fri, Jan 3, 2020 at 10:05 PM Dmitry Sepp wrote:
>
> Hi Tomasz, Keiichi,
>
> On Samstag, 21. Dezember 2019 07:19:23 CET Tomasz Figa wrote:
> > On Sat, Dec 21, 2019 at 3:18 PM Tomasz Figa wrote:
> > > On Sat, Dec 21, 2019 at 1:36 PM Keiichi Wa
Hi Dmitry,
On Sat, Dec 21, 2019 at 12:59 AM Dmitry Sepp
wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 18. Dezember 2019 14:02:13 CET Keiichi Watanabe wrote:
> > Hi,
> > This is the 2nd version of virtio-video patch. The PDF is available in [1].
> > The first versio
. What's the reason why you didn't add them in
virtio_video_params?
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to encode
y.
> > Though video encoder and decoder are provided as different devices, they use
> > a
> > same protocol.
> >
> > Signed-off-by: Dmitry Sepp
> > Signed-off-by: Keiichi Watanabe
> > ---
> > content.tex | 1 +
> > virtio-video.t
Hi,
This is the 2nd version of virtio-video patch. The PDF is available in [1].
The first version was sent at [2].
Any feedback would be appreciated. Thank you.
Best,
Keiichi
[1]:
https://drive.google.com/drive/folders/1eT5fEckBoor2iHZR4f4GLxYzFMVapOFx?usp=sharing
[2]: https://markmail.org/mess
From: Dmitry Sepp
The virtio video encoder device and decoder device provide functionalities to
encode and decode video stream respectively.
Though video encoder and decoder are provided as different devices, they use a
same protocol.
Signed-off-by: Dmitry Sepp
Signed-off-by: Keiichi Watanabe
50 matches
Mail list logo
