Re: [Spice-devel] [PATCH] Added needed import of function arraybuffer_to_str

2020-05-28 Thread Oliver Gutierrez
This is a patch to fix the SPICE port feature not being working since the change made to use module imports instead of inline loading of scripts. Right now works with only this change. On Thu, May 28, 2020 at 1:31 PM Oliver Gutierrez wrote: > --- > src/port.js | 2 +- > 1 file c

[Spice-devel] [PATCH] Added needed import of function arraybuffer_to_str

2020-05-28 Thread Oliver Gutierrez
--- src/port.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/port.js b/src/port.js index 74523ae..b254131 100644 --- a/src/port.js +++ b/src/port.js @@ -20,7 +20,7 @@ */ import { Constants } from './enums.js'; -import { DEBUG } from './utils.js'; +import { DEBUG,

Re: [Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-10 Thread Oliver Gutierrez
THanks :) No problem. Just were asking :) On Mon, Oct 10, 2016 at 1:55 PM, Pavel Grunt <pgr...@redhat.com> wrote: > On Mon, 2016-10-10 at 13:14 +0200, Oliver Gutierrez wrote: > > This patch has not been pushed yet. Is there any problem? > > Sorry for the delay Oliver &

Re: [Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-10 Thread Oliver Gutierrez
This patch has not been pushed yet. Is there any problem? On Wed, Oct 5, 2016 at 8:06 AM, Pavel Grunt <pgr...@redhat.com> wrote: > Hi Oliver, > > it looks good to me :) > > Acked-by: Pavel Grunt <pgr...@redhat.com> > > Thanks, > Pavel > > On Mon, 2016-10

Re: [Spice-devel] [spice-html5 audio 0/4] Audio tuneup patch set

2016-10-03 Thread Oliver Gutierrez
+++ > > - > > webm.js | 1 + > > 2 files changed, 50 insertions(+), 33 deletions(-) > > > > > _______ > Spice-devel mailing list > Spice-devel@

Re: [Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-03 Thread Oliver Gutierrez
OMG. THe patch attached to same thread. Now is Ok On Mon, Oct 3, 2016 at 2:10 PM, Oliver Gutierrez <ogutier...@redhat.com> wrote: > Forget this one. Missing one file. > > On Mon, Oct 3, 2016 at 2:02 PM, Oliver Gutierrez <ogutier...@redhat.com> > wrote: > >

Re: [Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-03 Thread Oliver Gutierrez
Forget this one. Missing one file. On Mon, Oct 3, 2016 at 2:02 PM, Oliver Gutierrez <ogutier...@redhat.com> wrote: > --- > enums.js| 9 + > main.js | 3 +++ > spice.html | 13 + > spice_auto.html | 13 + &g

[Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-03 Thread Oliver Gutierrez
)); else { if (! ("extra_channels" in this)) diff --git a/port.js b/port.js new file mode 100644 index 000..ee22073 --- /dev/null +++ b/port.js @@ -0,0 +1,85 @@ +"use strict"; +/* + Copyright (C) 2016 by Oliver Gutierre

[Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-03 Thread Oliver Gutierrez
--- enums.js| 9 + main.js | 3 +++ spice.html | 13 + spice_auto.html | 13 + spicemsg.js | 18 ++ utils.js| 7 +++ 6 files changed, 63 insertions(+) diff --git a/enums.js b/enums.js index 301fea0..b6e013c

Re: [Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-10-03 Thread Oliver Gutierrez
-ports/port ... > it could block the browser > > > The code handling the event in the html files could be just an comment > (to server as an example for somebody implementing something on top of > the port channel) > > Thanks for the contribution, > Pavel > > > On Thu,

Re: [Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-09-29 Thread Oliver Gutierrez
> > Reviewed-by: Jeremy White <jwh...@codeweavers.com> > > Cheers, > > Jeremy > > On 09/27/2016 10:29 AM, Oliver Gutierrez wrote: > > --- > > enums.js| 9 ++ > > main.js | 3 ++ > > port.js | 85 +++

[Spice-devel] [PATCH 1/2] Fixed trailing whitespaces in several files

2016-09-27 Thread Oliver Gutierrez
--- README | 4 ++-- TODO| 2 +- cursor.js | 2 +- display.js | 36 ++-- enums.js| 2 +- main.js | 2 +- playback.js | 2 +- simulatecursor.js | 6 +++--- spice.css |

[Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-09-27 Thread Oliver Gutierrez
)); else { if (! ("extra_channels" in this)) diff --git a/port.js b/port.js new file mode 100644 index 000..ee22073 --- /dev/null +++ b/port.js @@ -0,0 +1,85 @@ +"use strict"; +/* + Copyright (C) 2016 by Oliver Gutierre

Re: [Spice-devel] [PATCH] SPICE port basic implementation

2016-09-27 Thread Oliver Gutierrez
var SPICE_PLAYBACK_CAP_LATENCY = 2; > > @@ -264,7 +273,7 @@ var SPICE_MOUSE_BUTTON_MASK_LEFT = (1 << 0), > > SPICE_MOUSE_BUTTON_MASK_MIDDLE = (1 << 1), > > SPICE_MOUSE_BUTTON_MASK_RIGHT = (1 << 2), > > SPICE_MOUSE_BUTTON_MASK_MA

Re: [Spice-devel] [PATCH] SPICE port basic implementation

2016-09-26 Thread Oliver Gutierrez
I finally put all in the same patch with the Textdecoder part removed. Just added an utility function to do that in utils.js On Mon, Sep 26, 2016 at 1:02 PM, Oliver Gutierrez <ogutier...@redhat.com> wrote: > --- > enums.js| 11 +++- > main.js | 5

[Spice-devel] [PATCH] SPICE port basic implementation

2016-09-26 Thread Oliver Gutierrez
00644 index 000..ee22073 --- /dev/null +++ b/port.js @@ -0,0 +1,85 @@ +"use strict"; +/* + Copyright (C) 2016 by Oliver Gutierrez <ogut...@gmail.com> + Miroslav Chodil <mcho...@redhat.com> + + This file is part of spice-html5. + + spice-html5 is fr

[Spice-devel] [PATCH 3/3] Updated example files with SPICE port event listeners

2016-09-20 Thread Oliver Gutierrez
--- spice.html | 10 ++ spice_auto.html | 10 ++ 2 files changed, 20 insertions(+) diff --git a/spice.html b/spice.html index c473678..f9a91c0 100644 --- a/spice.html +++ b/spice.html @@ -42,6 +42,7 @@ + @@

[Spice-devel] [PATCH 1/3] Cleaning of trailing whitespaces

2016-09-20 Thread Oliver Gutierrez
--- enums.js| 2 +- main.js | 2 +- spice.html | 40 spice_auto.html | 2 +- spicemsg.js | 6 +++--- 5 files changed, 26 insertions(+), 26 deletions(-) diff --git a/enums.js b/enums.js index 3ef36dc..301fea0 100644 ---

[Spice-devel] [PATCH 2/3] SPICE port implementation

2016-09-20 Thread Oliver Gutierrez
/port.js b/port.js new file mode 100644 index 000..d61ef7e --- /dev/null +++ b/port.js @@ -0,0 +1,85 @@ +"use strict"; +/* + Copyright (C) 2016 by Oliver Gutierrez <ogut...@gmail.com> + Miroslav Chodil <mcho...@redhat.com> + + This file is part o

[Spice-devel] [PATCH] SPICE port draft implementation

2016-09-12 Thread Oliver Gutierrez
port.js new file mode 100644 index 000..2c96724 --- /dev/null +++ b/port.js @@ -0,0 +1,125 @@ +"use strict"; +/* + Copyright (C) 2016 by Oliver Gutierrez <ogut...@gmail.com> + + This file is part of spice-html5. + + spice-html5 is free software: you can redistribute it and

[Spice-devel] RFC - SPICE port draft implementation

2016-09-12 Thread Oliver Gutierrez
This is a fist draft of the SPICE port feature in spice-html5 There is only support for receiving messages right now. The port-event and port-data callbacks are set just like other javascript event listeners in the window object (Maybe we can move this to the main channel) Also we need to

[Spice-devel] [PATCH] Fixed syntax error in debugger command.

2016-09-08 Thread Oliver Gutierrez
Debugger is not an object or command. It is a reserved word and DEBUG > 0 && syntax does not work with it --- spiceconn.js | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spiceconn.js b/spiceconn.js index 010a446..796f954 100644 --- a/spiceconn.js +++ b/spiceconn.js @@

Re: [Spice-devel] [PATCH] Fixed syntax error. Debugger is not an object or command. It is a reserved word and DEBUG > 0 && syntax does not work with it

2016-09-08 Thread Oliver Gutierrez
Ok. Thanks for the tips :D On Thu, Sep 8, 2016 at 2:26 PM, Pavel Grunt <pgr...@redhat.com> wrote: > Ah, I didn't realized before pushing /o\ > > Please make the summary shorter - you can put the other sentence to > the commit body. > > On Thu, 2016-09-08 at 13:21 +0200

[Spice-devel] [PATCH] Fixed syntax error. Debugger is not an object or command. It is a reserved word and DEBUG > 0 && syntax does not work with it

2016-09-08 Thread Oliver Gutierrez
--- spiceconn.js | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spiceconn.js b/spiceconn.js index 010a446..796f954 100644 --- a/spiceconn.js +++ b/spiceconn.js @@ -189,8 +189,10 @@ SpiceConn.prototype = if (msg.type > 500) { -

Re: [Spice-devel] [PATCH] Added debug filtering to avoid debugger to start when using in production

2016-09-05 Thread Oliver Gutierrez
, 2016 at 10:48 AM, Oliver Gutierrez <ogutier...@redhat.com> wrote: > --- > spiceconn.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/spiceconn.js b/spiceconn.js > index 903f3b0..5123e04 100644 > --- a/spiceconn.js > +++ b

[Spice-devel] [PATCH] Added debug filtering to avoid debugger to start when using in production

2016-09-05 Thread Oliver Gutierrez
--- spiceconn.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spiceconn.js b/spiceconn.js index 903f3b0..5123e04 100644 --- a/spiceconn.js +++ b/spiceconn.js @@ -23,7 +23,7 @@ ** This is the base Javascript class for establishing and ** managing a connection

Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Oliver Gutierrez
/admin/cockpit/fleet-commander-admin/js/spice_debug_bypass.js This are the only modifications I've done On Thu, Jul 28, 2016 at 2:00 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Thu, Jul 28, 2016 at 12:59:05PM +0100, Oliver Gutierrez wrote: > > The problem I was having was

Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Oliver Gutierrez
ffer can be used > before being checked for null, and that this commit moves the check > before the first use of this.source_buffer. > You could also describe what happens when this triggers/how this > triggers (I assume playback stops?) > > On Thu, Jul 28, 2016 at 10:50:05AM +0100, Oli

[Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Oliver Gutierrez
--- playback.js | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/playback.js b/playback.js index 9659381..b5954da 100644 --- a/playback.js +++ b/playback.js @@ -107,21 +107,20 @@ SpicePlaybackConn.prototype.process_channel_message = function(msg) So we