Re: [Spice-devel] [PATCH spice-gtk] usb: channel-new handler to be after default handlers

2015-04-29 Thread Zeeshan Ali (Khattak)
usb-redirection working again in Boxes. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org/friends/ ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org

[Spice-devel] [PATCH] session: Improved docs for spice_session_connect()

2014-11-19 Thread Zeeshan Ali (Khattak)
Make it clear that users of this function must provide additional sockets for individual channels. --- gtk/spice-session.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index 88bcacd..cfc70bf 100644 ---

[Spice-devel] [PATCHv2] session: Improved docs for spice_session_connect()

2014-11-19 Thread Zeeshan Ali (Khattak)
Make it clear that users of this function must provide additional sockets for individual channels. --- gtk/spice-session.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index 88bcacd..59f45bc 100644 ---

Re: [Spice-devel] [spice-gtk] [PATCH] Provide a method to check if a USB device matches a specific class, subclass and protocol

2014-11-11 Thread Zeeshan Ali (Khattak)
://bugzilla.gnome.org/show_bug.cgi?id=698430 Any suggestion to have a shorter short-log is welcome :-) After all that practice with this in Boxes, I'm pretty sure you can do much better if you just try a bit. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-15 Thread Zeeshan Ali (Khattak)
On Mon, Sep 15, 2014 at 8:56 AM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Sep 12, 2014 at 06:52:07PM +0100, Zeeshan Ali (Khattak) wrote: Anyone up for review? It would be nice to get this in and (if possible) even released before GNOME's code freeze break on Wednesday. Won't

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-12 Thread Zeeshan Ali (Khattak)
On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau cferg...@redhat.com wrote: Since commit 9cf9ca434, spice_channel_iterate() will report a SPICE_CHANNEL_ERROR_IO error to library users when SpiceChannel

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-12 Thread Zeeshan Ali (Khattak)
On Fri, Sep 12, 2014 at 7:20 PM, Fabiano FidĂȘncio fabi...@fidencio.org wrote: On Fri, Sep 12, 2014 at 7:52 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Wed, Sep 10, 2014 at 3:35 PM, Christophe

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-10 Thread Zeeshan Ali (Khattak)
when SpiceChannel::has_error is set. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=83692 --- Just wanted to say that I tested this patch and it fixes the bug above. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org

[Spice-devel] [spice-0.8] client: Plug some leaks

2011-08-17 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- client/red_channel.cpp|1 + client/x11/red_window.cpp |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/red_channel.cpp b/client/red_channel.cpp index f4cdf52..ace4a03 100644 --- a/client/red_channel.cpp

Re: [Spice-devel] [spice-0.8] client: Plug some leaks

2011-08-17 Thread Zeeshan Ali (Khattak)
On Wed, Aug 17, 2011 at 7:35 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, Yo, These fixes duplicate fixes that already went into master :-/ See commits d7d0a3a98e and 0d4bd5504. Darn! Looks like you did a better job even. :) -- Regards, Zeeshan Ali (Khattak) FSF member#5124

[Spice-devel] [[PATCH] spice-gtk: ] Minor clean-up

2011-05-24 Thread Zeeshan Ali (Khattak)
Prefer 'if/else' over 'switch' when dealing with only 2 possibilities. --- gtk/spicy.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 82d8de2..0120692 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -239,18 +239,14 @@ static int

[Spice-devel] [PATCH spice-gtk] Get rid of redundant argument

2011-05-24 Thread Zeeshan Ali (Khattak)
--- gtk/spicy.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 262d465..bfa8189 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -184,7 +184,7 @@ static void recent_item_activated_dialog_cb(GtkRecentChooser *chooser, gpointer } #endif

[Spice-devel] [PATCH spice-gtk 1/2] Rename a function

2011-05-24 Thread Zeeshan Ali (Khattak)
This should be squashed into commit 27df918. --- gtk/spicy.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index cc30d54..7b51216 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -152,7 +152,7 @@ static struct { }; #ifndef WIN32 -static

[Spice-devel] [PATCH spice-gtk 2/2] Connect on recent connection item activation

2011-05-24 Thread Zeeshan Ali (Khattak)
Now (commit 27df918) that we already gather connection information when user (single)-clicks a recent connection item, we can safely use the selected recent connection when user activates (double-clicks) it. --- gtk/spicy.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff

[Spice-devel] [PATCH] Prefer malloc() over calloc()

2011-05-18 Thread Zeeshan Ali (Khattak)
When only 1 element needs to be allocated, calloc() only makes the code *slightly* less readable. --- src/console-kit.c |2 +- src/udscs.c |6 +++--- src/vdagent-virtio-port.c |2 +- src/vdagent-x11.c |2 +- src/vdagentd-uinput.c |2 +-

Re: [Spice-devel] [PATCH] Prefer malloc() over calloc()

2011-05-18 Thread Zeeshan Ali (Khattak)
On Wed, May 18, 2011 at 11:38 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: When only 1 element needs to be allocated, calloc() only makes the code *slightly* less readable. Please ignore this patch. I forgot that calloc also zero's out the memory. -- Regards, Zeeshan Ali (Khattak

[Spice-devel] video passthrough ideas

2011-05-12 Thread Zeeshan Ali (Khattak)
are: a. Same as issue 1.a above. b. GDP is unidirectional so we'll need to figure a way to serialize upstream events from the client. Shouldn't be difficult though once we know how to solve the previous issue. c. Same as 1.e above. -- Regards, Zeeshan Ali (Khattak) FSF member#5124

Re: [Spice-devel] video passthrough ideas

2011-05-12 Thread Zeeshan Ali (Khattak)
? :) -- Regards, Zeeshan Ali (Khattak) FSF member#5124 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] video passthrough ideas

2011-05-12 Thread Zeeshan Ali (Khattak)
QuickTime component doing the same conversion Cool, with all these advantages in mind, maybe we should just focus on the practicalities of this approach and only come back to the other options if we hit a snag on this one? -- Regards, Zeeshan Ali (Khattak) FSF member#5124

[Spice-devel] [PATCH] gtk: Remove redundant code

2011-05-10 Thread Zeeshan Ali (Khattak)
No need to keep the code that it disabled since it harms readability. Also remove the '#if 1' for same rationale. --- gtk/channel-display.c|3 +- gtk/channel-main.c |6 gtk/coroutine_gthread.c |4 --- gtk/coroutine_ucontext.c |5 --- gtk/decode-glz.c |4

[Spice-devel] [PATCH] Add vinagre module

2011-05-03 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- modulesets/spice.xml |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/modulesets/spice.xml b/modulesets/spice.xml index 9603438..a640afd 100644 --- a/modulesets/spice.xml +++ b/modulesets/spice.xml @@ -23,6 +23,8