Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-08-03 Thread Christophe Fergeau
I've pushed this after rewording the commit log. Thanks! Christophe On Thu, Jul 28, 2016 at 10:50:05AM +0100, Oliver Gutierrez wrote: > --- > playback.js | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/playback.js b/playback.js > index 9659381..b5954da 100644

Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Oliver Gutierrez
AFAIK My setup is very basic. I'm using a gnome-boxes machine, and modifying the xml for libvirt machine to setup a spice graphics adapter with autoport enabled. Then I run websockify and connect with spice-html5 client. Nothing strange. If you want to look to implementation I do for setting up t

Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Christophe Fergeau
On Thu, Jul 28, 2016 at 12:59:05PM +0100, Oliver Gutierrez wrote: > The problem I was having was the spice-html5 client was throwing exceptions > for trying to access that property in cases where it is not a valid value. > > I got to the error because I'm developing a plugin for cockpit that makes

Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Oliver Gutierrez
The problem I was having was the spice-html5 client was throwing exceptions for trying to access that property in cases where it is not a valid value. I got to the error because I'm developing a plugin for cockpit that makes use of spice-html5 for connecting to VMs, and when spice-html5 starts dis

Re: [Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Christophe Fergeau
Hey, Thanks for the patch! I'd expand a bit in the commit log, that this.source_buffer can be used before being checked for null, and that this commit moves the check before the first use of this.source_buffer. You could also describe what happens when this triggers/how this triggers (I assume pl

[Spice-devel] [PATCH] Fixed error when trying to access undefined source buffer without checking it first

2016-07-28 Thread Oliver Gutierrez
--- playback.js | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/playback.js b/playback.js index 9659381..b5954da 100644 --- a/playback.js +++ b/playback.js @@ -107,21 +107,20 @@ SpicePlaybackConn.prototype.process_channel_message = function(msg) So we do