Re: [Spice-devel] [PATCH] Remove goto within switch statement

2016-06-15 Thread Jonathon Jongsma
On Wed, 2016-06-15 at 08:18 +0200, Pavel Grunt wrote: > Hi Jonathon, > > On Tue, 2016-06-14 at 16:04 -0500, Jonathon Jongsma wrote: > > > > Having a goto label in the middle of a switch/case statement is a bit > > confusing. But the same behavior can be achieved  > it changes the behavior - if LZ

Re: [Spice-devel] [PATCH] Remove goto within switch statement

2016-06-14 Thread Pavel Grunt
Hi Jonathon, On Tue, 2016-06-14 at 16:04 -0500, Jonathon Jongsma wrote: > Having a goto label in the middle of a switch/case statement is a bit > confusing. But the same behavior can be achieved it changes the behavior - if LZ4 compression is selected on server but it is not supported on the cli

[Spice-devel] [PATCH] Remove goto within switch statement

2016-06-14 Thread Jonathon Jongsma
Having a goto label in the middle of a switch/case statement is a bit confusing. But the same behavior can be achieved by simply rearranging the cases so that we fall through to the one that we wanted to jump to. --- This should apply on top of frediano's encapsulation patch series. server/dcc.c