This is very close to the last iteration I sent, except that you moved
the dead code path my patch had to a more appropriate place ;) ACK,
though would be nice to have a reproducer in the commit log.
Christophe
On Wed, Jul 23, 2014 at 12:16:56AM +0300, Uri Lublin wrote:
> During seamless migratio
Hey,
On Wed, Jul 23, 2014 at 12:16:55AM +0300, Uri Lublin wrote:
> This patch fixes an assert in spice-server code on the
> destination side of migration, that happens when
> the MIGRATE_DATA message of the main channel arrives
> before the (qemu-kvm's) virtio-serial-port device state.
> For a mor
This patch fixes an assert in spice-server code on the
destination side of migration, that happens when
the MIGRATE_DATA message of the main channel arrives
before the (qemu-kvm's) virtio-serial-port device state.
For a more detailed information look at the patch
log message.
Some comments/concern
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to the new
qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
SPICE char devices use such MIGRATE_DATA messages to restore their state.
However, t
On Wed, Apr 30, 2014 at 08:11:38PM +0300, Uri Lublin wrote:
> Hi Christophe,
>
> I don't understand what exactly goes wrong and how this
> patch fixes the race.
>
>
> On 04/01/2014 04:58 PM, Christophe Fergeau wrote:
> >During seamless migration, after switching host, if a client was connected
>
On 05/15/2014 05:14 PM, Christophe Fergeau wrote:
Hi,
On Wed, Apr 30, 2014 at 08:11:38PM +0300, Uri Lublin wrote:
On 04/01/2014 04:58 PM, Christophe Fergeau wrote:
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to
Hi,
On Wed, Apr 30, 2014 at 08:11:38PM +0300, Uri Lublin wrote:
> Hi Christophe,
>
> I don't understand what exactly goes wrong and how this
> patch fixes the race.
>
>
> On 04/01/2014 04:58 PM, Christophe Fergeau wrote:
> >During seamless migration, after switching host, if a client was connec
Hi Christophe,
I don't understand what exactly goes wrong and how this
patch fixes the race.
On 04/01/2014 04:58 PM, Christophe Fergeau wrote:
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to the new
qemu/spice-s
Ping?
- Mail original -
> During seamless migration, after switching host, if a client was connected
> during the migration, it will have data to send back to the new
> qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
> SPICE char devices use such MIGRATE_DATA mes
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to the new
qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
SPICE char devices use such MIGRATE_DATA messages to restore their state.
However, t
Hey,
On Tue, Mar 18, 2014 at 01:06:20PM +0200, Uri Lublin wrote:
>
> Hi Christophe,
>
> I'm concerned that reds_agent_state_restore() is called after
> spice_char_device_start()
I think the position for the call to reds_agent_state_restore() was quite
arbitrary and that I should be able to move
On 02/24/2014 07:44 PM, Christophe Fergeau wrote:
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to the new
qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
SPICE char devices use such MIGRA
On 02/24/2014 07:44 PM, Christophe Fergeau wrote:
> During seamless migration, after switching host, if a client was connected
> during the migration, it will have data to send back to the new
> qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
> SPICE char devices use such
On Wed, Mar 12, 2014 at 3:37 PM, Christophe Fergeau wrote:
> Does this address your concerns?
thanks, I would prefer someone else to review this patch, though... Alon?
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.or
Ping ?
Does this address your concerns?
On Tue, Feb 25, 2014 at 04:14:55PM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Mon, Feb 24, 2014 at 08:26:34PM +0100, Marc-André Lureau wrote:
> > On Mon, Feb 24, 2014 at 6:44 PM, Christophe Fergeau
> > wrote:
> > > During seamless migration, after swi
Hey,
On Mon, Feb 24, 2014 at 08:26:34PM +0100, Marc-André Lureau wrote:
> On Mon, Feb 24, 2014 at 6:44 PM, Christophe Fergeau
> wrote:
> > During seamless migration, after switching host, if a client was connected
> > during the migration, it will have data to send back to the new
> > qemu/spice
On Mon, Feb 24, 2014 at 6:44 PM, Christophe Fergeau wrote:
> During seamless migration, after switching host, if a client was connected
> during the migration, it will have data to send back to the new
> qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
> SPICE char device
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to the new
qemu/spice-server instance. This is handled through MIGRATE_DATA messages.
SPICE char devices use such MIGRATE_DATA messages to restore their state.
However, t
18 matches
Mail list logo
