[Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
RHBZ #790083 Signed-off-by: Yonit Halperin --- hw/qxl.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index bc03c1d..a2a3380 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1478,14 +1478,21 @@ static void qxl_vm_change_state_handler(void *

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Gerd Hoffmann
On 02/14/12 09:10, Yonit Halperin wrote: > RHBZ #790083 > > Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b) skip vram when it is unused (in compat mode). I'd love to see (b) done in a different

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 10:35 AM, Gerd Hoffmann wrote: On 02/14/12 09:10, Yonit Halperin wrote: RHBZ #790083 Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b) skip vram when it is unused (in compat mode).

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 11:10 AM, Yonit Halperin wrote: On 02/14/2012 10:35 AM, Gerd Hoffmann wrote: On 02/14/12 09:10, Yonit Halperin wrote: RHBZ #790083 Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b)

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Gerd Hoffmann
Hi, > I can do it, by retrieving the surfaces addresses from the tracked guest > commands. Exactly. > However, if we already do it, it would be even better if we > just dirty only the areas that are actually modified by the update_area > calls. The problem is that (1) spice-server updates surf

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 11:24 AM, Gerd Hoffmann wrote: Hi, I can do it, by retrieving the surfaces addresses from the tracked guest commands. Exactly. However, if we already do it, it would be even better if we just dirty only the areas that are actually modified by the update_area calls. The prob