Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-29 Thread Christophe de Dinechin
> On 29 Mar 2018, at 09:14, Christophe de Dinechin wrote: > > > >> On 28 Mar 2018, at 18:46, Christophe Fergeau wrote: >> >> On Wed, Mar 28, 2018 at 06:06:19PM +0200, Christophe de Dinechin wrote: If my task is to "move version check to the

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-29 Thread Christophe de Dinechin
> On 28 Mar 2018, at 18:46, Christophe Fergeau wrote: > > On Wed, Mar 28, 2018 at 06:06:19PM +0200, Christophe de Dinechin wrote: >>> If my task is to "move version check to the agent", do I _have_ to change >>> the semantics of the version check? No. >> >> Of course you

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-28 Thread Christophe Fergeau
On Wed, Mar 28, 2018 at 06:06:19PM +0200, Christophe de Dinechin wrote: > > If my task is to "move version check to the agent", do I _have_ to change > > the semantics of the version check? No. > > Of course you have to. There is no “PluginVersionIsCompatible” > anymore, etc, so the version

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-28 Thread Christophe de Dinechin
> On 28 Mar 2018, at 17:45, Christophe Fergeau wrote: > > On Wed, Mar 28, 2018 at 10:47:27AM +0200, Christophe de Dinechin wrote: >>> What matters in my opinion is that we decide to break it, once we've >>> made that decision, the number of commits which are going to make

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-28 Thread Christophe Fergeau
On Wed, Mar 28, 2018 at 10:47:27AM +0200, Christophe de Dinechin wrote: > > What matters in my opinion is that we decide to break it, once we've > > made that decision, the number of commits which are going to make ABI > > breaking changes is less important. > > Introducing “subtle” changes such

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-28 Thread Christophe de Dinechin
> On 27 Mar 2018, at 10:56, Christophe Fergeau wrote: > > On Tue, Mar 27, 2018 at 10:28:24AM +0200, Christophe de Dinechin wrote: >> >> >>> On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: >>> >>> With the right patch attached this time.. ;)

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Lukáš Hrázký
FWIW, personal opinions below :) On Tue, 2018-03-27 at 10:56 +0200, Christophe Fergeau wrote: > On Tue, Mar 27, 2018 at 10:28:24AM +0200, Christophe de Dinechin wrote: > > > > > > > On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: > > > > > > With the right patch

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Christophe Fergeau
On Tue, Mar 27, 2018 at 10:28:24AM +0200, Christophe de Dinechin wrote: > > > > On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: > > > > With the right patch attached this time.. ;) I've only compile-tested > > this as this really is just a proof of concept at this

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Christophe de Dinechin
> On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: > > With the right patch attached this time.. ;) I've only compile-tested > this as this really is just a proof of concept at this point. If I understand correctly, you break the ABI twice, and you rely on a “side

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Christophe Fergeau
With the right patch attached this time.. ;) I've only compile-tested this as this really is just a proof of concept at this point. Christophe On Mon, Mar 26, 2018 at 06:47:08PM +0200, Christophe Fergeau wrote: > On Mon, Mar 26, 2018 at 11:27:19AM +0200, Christophe de Dinechin wrote: > > > > >

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-26 Thread Christophe Fergeau
On Mon, Mar 26, 2018 at 11:27:19AM +0200, Christophe de Dinechin wrote: > > > > On 26 Mar 2018, at 11:25, Christophe Fergeau wrote: > > > > Hey, > > > > On Fri, Mar 23, 2018 at 01:05:22PM +0100, Christophe de Dinechin wrote: > >> From: Christophe de Dinechin

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-26 Thread Christophe de Dinechin
> On 26 Mar 2018, at 11:25, Christophe Fergeau wrote: > > Hey, > > On Fri, Mar 23, 2018 at 01:05:22PM +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Ensure that plugin version checking cannot be bypassed. >> Implement

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-26 Thread Christophe Fergeau
Hey, On Fri, Mar 23, 2018 at 01:05:22PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Ensure that plugin version checking cannot be bypassed. > Implement version checking without violating the C++ ODR. > Improve ABI version numbering when

[Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-23 Thread Christophe de Dinechin
From: Christophe de Dinechin Ensure that plugin version checking cannot be bypassed. Implement version checking without violating the C++ ODR. Improve ABI version numbering when incompatibilites are detected post-release. Add macro to make it easier to generate the ABI