Re: [Spice-devel] [PATCH 00/18] red_channel introducing refactoring, part 2, v1

2011-02-08 Thread Alon Levy
On Tue, Feb 08, 2011 at 07:47:23PM +0100, Marc-André Lureau wrote: > Hi Alon, Gerd, > > While reviewing Alon patches, I started to get annoyed by a crash I > didn't see before, although it seems to be an old bug, and comes from > qemu perhaps? > > I am investing that crash before continuing the r

Re: [Spice-devel] [PATCH 00/18] red_channel introducing refactoring, part 2, v1

2011-02-08 Thread Marc-André Lureau
Hi On Tue, Feb 8, 2011 at 7:47 PM, Marc-André Lureau wrote: > Hi Alon, Gerd, > > While reviewing Alon patches, I started to get annoyed by a crash I > didn't see before, although it seems to be an old bug, and comes from > qemu perhaps? > > I am investing that crash before continuing the review,

Re: [Spice-devel] [PATCH 00/18] red_channel introducing refactoring, part 2, v1

2011-02-08 Thread Marc-André Lureau
Hi Alon, Gerd, While reviewing Alon patches, I started to get annoyed by a crash I didn't see before, although it seems to be an old bug, and comes from qemu perhaps? I am investing that crash before continuing the review, as it gets worst when I applied the first 3/4 patches (double free..). Th

[Spice-devel] [PATCH 00/18] red_channel introducing refactoring, part 2, v1

2011-02-07 Thread Alon Levy
This is a part of a much larger series so I don't have a good concise description. Ultimately this all leads to a reuse of RedChannel across most of the channels (sound remains an odd out because of not using a pipe abstraction, but a bitmap of outstanding packets, you can have 0 or one of each typ