Re: [Spice-devel] [PATCH 06/10] RedChannelClient: store pipe items in a GList

2016-09-09 Thread Jonathon Jongsma
On Fri, 2016-09-09 at 10:27 -0400, Frediano Ziglio wrote: > > > > Instead of using a Ring (and having a ring item link in every pipe > > item), store them in a GList. This also necesitated changing > > RedCharDeviceVDIPort->priv->read_bufs to a GList as well. > > At least use a GQueue, a pipe is

Re: [Spice-devel] [PATCH 06/10] RedChannelClient: store pipe items in a GList

2016-09-09 Thread Frediano Ziglio
> Instead of using a Ring (and having a ring item link in every pipe > item), store them in a GList. This also necesitated changing > RedCharDeviceVDIPort->priv->read_bufs to a GList as well. At least use a GQueue, a pipe is a queue. > --- > server/cursor-channel.c | 2 - > server/d

Re: [Spice-devel] [PATCH 06/10] RedChannelClient: store pipe items in a GList

2016-09-09 Thread Christophe Fergeau
On Thu, Sep 08, 2016 at 11:52:56AM -0500, Jonathon Jongsma wrote: > Instead of using a Ring (and having a ring item link in every pipe > item), store them in a GList. This also necesitated changing Forgot to mention 'neces*s*itated' typo. Christophe signature.asc Description: PGP signature

Re: [Spice-devel] [PATCH 06/10] RedChannelClient: store pipe items in a GList

2016-09-09 Thread Christophe Fergeau
On Thu, Sep 08, 2016 at 11:52:56AM -0500, Jonathon Jongsma wrote: > Instead of using a Ring (and having a ring item link in every pipe > item), store them in a GList. This also necesitated changing > RedCharDeviceVDIPort->priv->read_bufs to a GList as well. > --- > server/cursor-channel.c

[Spice-devel] [PATCH 06/10] RedChannelClient: store pipe items in a GList

2016-09-08 Thread Jonathon Jongsma
Instead of using a Ring (and having a ring item link in every pipe item), store them in a GList. This also necesitated changing RedCharDeviceVDIPort->priv->read_bufs to a GList as well. --- server/cursor-channel.c | 2 - server/dcc-send.c | 22 +-- server/dcc