Re: [Spice-devel] [PATCH 07/18] server/red_worker: extract common_release_pipe_item from red_pipe_clear

2011-02-10 Thread Alon Levy
On Tue, Feb 08, 2011 at 10:07:40PM +0100, Marc-André Lureau wrote: Hopefully we can find a more elegant solution to the downcasting introduced in patch 03: CommonChannel *common = SPICE_CONTAINEROF(channel, CommonChannel, base); I would rather modify the function

Re: [Spice-devel] [PATCH 07/18] server/red_worker: extract common_release_pipe_item from red_pipe_clear

2011-02-08 Thread Marc-André Lureau
Hopefully we can find a more elegant solution to the downcasting introduced in patch 03: CommonChannel *common = SPICE_CONTAINEROF(channel, CommonChannel, base); I would rather modify the function common_release_pipe_item(RedChannel *channel, PipeItem *item) to be:

[Spice-devel] [PATCH 07/18] server/red_worker: extract common_release_pipe_item from red_pipe_clear

2011-02-07 Thread Alon Levy
--- server/red_worker.c | 106 +++ 1 files changed, 56 insertions(+), 50 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 76d0ef6..08aeef2 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1354,63 +1354,69 @@