Re: [Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-10-03 Thread Oliver Gutierrez
Hi Pavel, The Uint8Array is an event. i don't know if there are more events than port opened or port closed. The value 0 is sent when the port device file is opened in the VM side and the 1 is sent when in the VM side you close device file, so I left it as is because I don't know if there are

Re: [Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-09-30 Thread Pavel Grunt
Hi Oliver, I tested it (in FF) and it works nicely, I just have minor comments: in the console: SPICE port com.spice.fc.1 event data: Uint8Array { 0=0} SPICE port com.spice.fc.1 message text: CHILI SPICE port com.spice.fc.1 event data: Uint8Array { 0=1} 1) what is the Uint8Array - it has just

Re: [Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-09-29 Thread Oliver Gutierrez
Here is an small guide to test this for the ones that want to check it faster: Add a spiceport to a virtual machine adding this under devices in the XML Boot machine, Connect to it as usual using spice-html5 and as root: echo "CHILI" >

Re: [Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-09-28 Thread Jeremy White
Looks good to me. I don't have the time to test this myself, so I'll leave this open for others to kibitz for now. I don't think it will do harm, so if no one else expresses an opinion after a while, you can probably nudge me into pushing it. Reviewed-by: Jeremy White

[Spice-devel] [PATCH 2/2] SPICE port basic implementation

2016-09-27 Thread Oliver Gutierrez
--- enums.js| 9 ++ main.js | 3 ++ port.js | 85 + spice.html | 10 +++ spice_auto.html | 10 +++ spicemsg.js | 18 utils.js| 7 + 7 files changed, 142 insertions(+)