Re: [Spice-devel] [PATCH 4/7] server/inputs_channel: don't set O_ASYNC option on socket

2012-01-22 Thread Alon Levy
On Thu, Jan 19, 2012 at 02:10:01PM -0600, Dan McGee wrote: > output to send a SIGIO signal to the running program. However, we don't > handle this signal anywhere in the code, so setting the option is > unnecessary. > ACK. I can't find anything explaining why this why done - seems you are right

Re: [Spice-devel] [PATCH 4/7] server/inputs_channel: don't set O_ASYNC option on socket

2012-01-20 Thread Hans de Goede
This looks like a good catch to me, but I would like to see a review by someone who knows this code a bit better then me. Alon ? Yonit? Regards, Hans On 01/19/2012 09:10 PM, Dan McGee wrote: output to send a SIGIO signal to the running program. However, we don't handle this signal anywhere in

[Spice-devel] [PATCH 4/7] server/inputs_channel: don't set O_ASYNC option on socket

2012-01-19 Thread Dan McGee
output to send a SIGIO signal to the running program. However, we don't handle this signal anywhere in the code, so setting the option is unnecessary. Signed-off-by: Dan McGee --- Sorry, botched the sending of this patch it looks like, trying again... If anyone knows more about O_ASYNC than I d

[Spice-devel] [PATCH 4/7] server/inputs_channel: don't set O_ASYNC option on socket

2012-01-19 Thread Dan McGee
output to send a SIGIO signal to the running program. However, we don't handle this signal anywhere in the code, so setting the option is unnecessary. Signed-off-by: Dan McGee --- If anyone knows more about O_ASYNC than I do, please speak up, but doing some reading and research leads me to belie