From: Zongmin Zhou <zhouzong...@kylinos.cn>

[ Upstream commit 0e8b9f258baed25f1c5672613699247c76b007b5 ]

The allocated memory for qdev->dumb_heads should be released
in qxl_destroy_monitors_object before qxl suspend.
otherwise,qxl_create_monitors_object will be called to
reallocate memory for qdev->dumb_heads after qxl resume,
it will cause memory leak.

Signed-off-by: Zongmin Zhou <zhouzong...@kylinos.cn>
Link: https://lore.kernel.org/r/20230801025309.4049813-1-zhouzong...@kylinos.cn
Reviewed-by: Dave Airlie <airl...@redhat.com>
Signed-off-by: Maxime Ripard <mrip...@kernel.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/gpu/drm/qxl/qxl_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c 
b/drivers/gpu/drm/qxl/qxl_display.c
index 6492a70e3c396..404b0483bb7cb 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev)
        if (!qdev->monitors_config_bo)
                return 0;
 
+       kfree(qdev->dumb_heads);
+       qdev->dumb_heads = NULL;
+
        qdev->monitors_config = NULL;
        qdev->ram_header->monitors_config = 0;
 
-- 
2.42.0

Reply via email to