Re: [Spice-devel] [PATCH qxl-wddm-dod v5 2/7] Code Analysis fix

2016-09-27 Thread Christophe Fergeau
On Tue, Sep 27, 2016 at 01:01:22PM +0300, Dmitry Fleytman wrote: > > > On 27 Sep 2016, at 12:35 PM, Christophe Fergeau wrote: > > > > Hey, > > > > A huge part of this patch is adding +__declspec(code_seg("PAGE")) (and > > removing #pragma code_seg()), which are probably

Re: [Spice-devel] [PATCH qxl-wddm-dod v5 2/7] Code Analysis fix

2016-09-27 Thread Dmitry Fleytman
> On 27 Sep 2016, at 12:35 PM, Christophe Fergeau wrote: > > Hey, > > A huge part of this patch is adding +__declspec(code_seg("PAGE")) (and > removing #pragma code_seg()), which are probably related to this macro, > but which are added with no rationale. > The shortlog

Re: [Spice-devel] [PATCH qxl-wddm-dod v5 2/7] Code Analysis fix

2016-09-27 Thread Christophe Fergeau
Hey, A huge part of this patch is adding +__declspec(code_seg("PAGE")) (and removing #pragma code_seg()), which are probably related to this macro, but which are added with no rationale. The shortlog should probably be something different than "code analysis fix", but more somethnig like "Use

Re: [Spice-devel] [PATCH qxl-wddm-dod v5 2/7] Code Analysis fix

2016-09-26 Thread Frediano Ziglio
> > The PAGED_CODE macro ensures that the calling thread is running at an > IRQL that is low enough to permit paging. A call to this macro should > be made at the beginning of every driver routine that either contains > pageable code or accesses pageable code. > > Based on a patch by Sandy

[Spice-devel] [PATCH qxl-wddm-dod v5 2/7] Code Analysis fix

2016-09-26 Thread Sameeh Jubran
The PAGED_CODE macro ensures that the calling thread is running at an IRQL that is low enough to permit paging. A call to this macro should be made at the beginning of every driver routine that either contains pageable code or accesses pageable code. Based on a patch by Sandy Stutsman