Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-11-25 Thread Christophe Fergeau
On Tue, Nov 25, 2014 at 02:49:07PM +0100, Marc-André Lureau wrote: > On Tue, Nov 25, 2014 at 2:11 PM, Christophe Fergeau > wrote: > > Hey, > > > > On Mon, Nov 24, 2014 at 04:56:26PM +0100, Marc-André Lureau wrote: > >> In an effort to reduce the wakeups per second, get rid of the > >> "write_to_d

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-11-25 Thread Marc-André Lureau
On Tue, Nov 25, 2014 at 2:11 PM, Christophe Fergeau wrote: > Hey, > > On Mon, Nov 24, 2014 at 04:56:26PM +0100, Marc-André Lureau wrote: >> In an effort to reduce the wakeups per second, get rid of the >> "write_to_dev" timer when the implementation supports >> SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. >

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-11-25 Thread Christophe Fergeau
Hey, On Mon, Nov 24, 2014 at 04:56:26PM +0100, Marc-André Lureau wrote: > In an effort to reduce the wakeups per second, get rid of the > "write_to_dev" timer when the implementation supports > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. > > When this flag is set, the frontend instance is responsible for

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-11-24 Thread Marc-André Lureau
Hi - Original Message - > Hey, > > On Mon, Nov 24, 2014 at 04:56:26PM +0100, Marc-André Lureau wrote: > > In an effort to reduce the wakeups per second, get rid of the > > "write_to_dev" timer when the implementation supports > > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. > > Do you know what is

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-11-24 Thread Christophe Fergeau
Hey, On Mon, Nov 24, 2014 at 04:56:26PM +0100, Marc-André Lureau wrote: > In an effort to reduce the wakeups per second, get rid of the > "write_to_dev" timer when the implementation supports > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. Do you know what is the status of getting support for this in QEMU?

[Spice-devel] [PATCH spice] chardev: remove write polling

2014-11-24 Thread Marc-André Lureau
In an effort to reduce the wakeups per second, get rid of the "write_to_dev" timer when the implementation supports SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. When this flag is set, the frontend instance is responsible for calling spice_char_device_wakeup() when the device is ready to perform IO. Related

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-27 Thread Marc-André Lureau
- Mail original - > Hi Marc-Andre, > > On 10/24/2014 01:17 PM, Marc-André Lureau wrote: > > In an effort to reduce the wakeups per second, get rid of the > > "write_to_dev" timer when the implementation supports > > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. > > > > When this flag is set, the fr

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-27 Thread Uri Lublin
Hi Marc-Andre, On 10/24/2014 01:17 PM, Marc-André Lureau wrote: In an effort to reduce the wakeups per second, get rid of the "write_to_dev" timer when the implementation supports SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. When this flag is set, the frontend instance is responsible for calling spice_ch

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-27 Thread Marc-André Lureau
On Mon, Oct 27, 2014 at 11:26 AM, Christophe Fergeau wrote: > What impact does this change have on existing users of this function? None, if there is nothing to write. If there is something to write, it will write now instead of waiting for the timer afew ms later. -- Marc-André Lureau _

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-27 Thread Christophe Fergeau
On Fri, Oct 24, 2014 at 12:17:08PM +0200, Marc-André Lureau wrote: > void spice_char_device_wakeup(SpiceCharDeviceState *dev) > { > +spice_char_device_write_to_device(dev); > spice_char_device_read_from_device(dev); What impact does this change have on existing users of this function?

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-27 Thread Christophe Fergeau
For reference, the corresponding QEMU patch is https://lists.nongnu.org/archive/html/qemu-devel/2014-10/msg02939.html (which depends on 1/2 which in turn depends on another patch) Christophe On Fri, Oct 24, 2014 at 12:17:08PM +0200, Marc-André Lureau wrote: > In an effort to reduce the wakeups pe

[Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Marc-André Lureau
In an effort to reduce the wakeups per second, get rid of the "write_to_dev" timer when the implementation supports SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. When this flag is set, the frontend instance is responsible for calling spice_char_device_wakeup() when the device is ready to perform IO. Related

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Marc-André Lureau
- Original Message - > On Fri, Oct 24, 2014 at 10:54:24AM +0200, Marc-André Lureau wrote: > > @@ -407,6 +407,10 @@ typedef struct SpiceCharDeviceInterface > > SpiceCharDeviceInterface; > > typedef struct SpiceCharDeviceInstance SpiceCharDeviceInstance; > > typedef struct SpiceCharDevice

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Christophe Fergeau
On Fri, Oct 24, 2014 at 10:54:24AM +0200, Marc-André Lureau wrote: > @@ -407,6 +407,10 @@ typedef struct SpiceCharDeviceInterface > SpiceCharDeviceInterface; > typedef struct SpiceCharDeviceInstance SpiceCharDeviceInstance; > typedef struct SpiceCharDeviceState SpiceCharDeviceState; > > +typed

[Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Marc-André Lureau
In an effort to reduce the wakeups per second, get rid of the "write_to_dev" timer when the implementation supports SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. When this flag is set, the frontend instance is responsible for calling spice_char_device_wakeup() when the device is ready to perform IO. Related