Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Frediano Ziglio
> > Hi > > On Thu, Jan 17, 2019 at 12:35 PM Frediano Ziglio wrote: > > > > > > > > Hi > > > > > > On Thu, Jan 17, 2019 at 12:15 PM Frediano Ziglio > > > wrote: > > > > > > > > > > > > > > From: Marc-André Lureau > > > > > > > > > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Victor Toso
Hi, On Thu, Jan 17, 2019 at 12:33:09PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Jan 17, 2019 at 11:43 AM Victor Toso wrote: > > > > Hi, > > > > On Thu, Jan 17, 2019 at 03:04:32AM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > autofoo build-sys

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Marc-André Lureau
Hi On Thu, Jan 17, 2019 at 12:35 PM Frediano Ziglio wrote: > > > > > Hi > > > > On Thu, Jan 17, 2019 at 12:15 PM Frediano Ziglio wrote: > > > > > > > > > > > From: Marc-André Lureau > > > > > > > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses > > > > it. > > > > > > >

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Frediano Ziglio
> > Hi > > On Thu, Jan 17, 2019 at 12:15 PM Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. > > > > > > Later, I think it would make sense to switch to G_BIG_ENDIAN instead. > > > > > > > This

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Marc-André Lureau
Hi On Thu, Jan 17, 2019 at 11:43 AM Victor Toso wrote: > > Hi, > > On Thu, Jan 17, 2019 at 03:04:32AM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. > > > > Later, I think it would make

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Marc-André Lureau
Hi On Thu, Jan 17, 2019 at 12:15 PM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. > > > > Later, I think it would make sense to switch to G_BIG_ENDIAN instead. > > > > This comment should not be in the

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-17 Thread Frediano Ziglio
> > From: Marc-André Lureau > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. > > Later, I think it would make sense to switch to G_BIG_ENDIAN instead. > This comment should not be in the commit message. IMHO WORDS_BIGENDIAN is fine, is pretty standard and Meson

Re: [Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-16 Thread Victor Toso
Hi, On Thu, Jan 17, 2019 at 03:04:32AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. > > Later, I think it would make sense to switch to G_BIG_ENDIAN instead. Indeed, > Fixes: >

[Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

2019-01-16 Thread marcandre . lureau
From: Marc-André Lureau autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. Later, I think it would make sense to switch to G_BIG_ENDIAN instead. Fixes: https://gitlab.freedesktop.org/spice/spice-common/issues/2 Signed-off-by: Marc-André Lureau --- meson.build | 3 +++