Re: [Spice-devel] [PATCH spice-common 1/9] messages: Remove fields not used by the protocol

2019-03-07 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 07:10:22PM +, Frediano Ziglio wrote: > These fields are not used by the protocol. Maybe make it explicit that 'not used by the protocol' means they are not in spice.proto, nor will be used in the generated (de)marshallers. Apart from this, Acked-by: Christophe Fergeau

[Spice-devel] [PATCH spice-common 1/9] messages: Remove fields not used by the protocol

2019-03-03 Thread Frediano Ziglio
These fields are not used by the protocol. Avoid spice-gtk and spice-server to use them by mistake. This can cause memory errors (data_size is not used or is not set correctly) and useless code (spice-gtk uses the pub_key* fields but these fields are not sent to the server as the protocol does not