Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
> On 19 Oct 2017, at 15:10, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: >>> One reason is that you may use a library dynamically, and you may dlclose() >>> it, and then atexit() will likely crash. >> >> Is that a

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
> On 19 Oct 2017, at 15:10, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: >>> One reason is that you may use a library dynamically, and you may dlclose() >>> it, and then atexit() will likely crash. >> >> Is that a

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote: > > One reason is that you may use a library dynamically, and you may dlclose() > > it, and then atexit() will likely crash. > > Is that a real or theoretical scenario? Who loads this library dynamically > currently?

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Frediano Ziglio
> > On 19 Oct 2017, at 13:49, Marc-André Lureau < marcandre.lur...@redhat.com > > > wrote: > > > - Original Message - > > > > > On 19 Oct 2017, at 13:15, Marc-André Lureau < > > > > marcandre.lur...@redhat.com > > > > > > > > > > > > > > > wrote: > > > > > > > > > > Hi > > > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
> On 19 Oct 2017, at 13:49, Marc-André Lureau > wrote: > > > > - Original Message - >> >>> On 19 Oct 2017, at 13:15, Marc-André Lureau >>> wrote: >>> >>> Hi >>> >>> - Original Message - > > From:

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 08:53:08AM -0400, Frediano Ziglio wrote: > > > > On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > > > even > > > > if they were originally dlopend. If

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Frediano Ziglio
> > On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > > even > > > if they were originally dlopend. If the library has used a pthread local > > > with > > > a destructor function, then

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote: > > > > > > In fact non-trivial shared libraries should generally never be unloaded, > > even > > if they were originally dlopend. If the library has used a pthread local > > with > > a destructor function, then unloading the

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Frediano Ziglio
> > On Thu, Oct 19, 2017 at 07:47:24AM -0400, Frediano Ziglio wrote: > > > > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > > > > > > > > > This is useful for some instrumentation,

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 07:47:24AM -0400, Frediano Ziglio wrote: > > > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > > > > > This is useful for some instrumentation, e.g. the leaks tracer,

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Marc-André Lureau
- Original Message - > > > On 19 Oct 2017, at 13:15, Marc-André Lureau > > wrote: > > > > Hi > > > > - Original Message - > >>> > >>> From: Christophe de Dinechin > >>> > >>> This is useful for some instrumentation, e.g.

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Frediano Ziglio
> > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > This is useful for some instrumentation, e.g. the leaks tracer, > > > > > > that perform some of their operations within gst_deinit. > > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
> On 19 Oct 2017, at 13:19, Frediano Ziglio wrote: > >> >> Hi >> >> - Original Message - From: Christophe de Dinechin This is useful for some instrumentation, e.g. the leaks tracer, that perform some of their

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
> On 19 Oct 2017, at 13:15, Marc-André Lureau > wrote: > > Hi > > - Original Message - >>> >>> From: Christophe de Dinechin >>> >>> This is useful for some instrumentation, e.g. the leaks tracer, >>> that perform some of their

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
> On 19 Oct 2017, at 12:32, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> This is useful for some instrumentation, e.g. the leaks tracer, >> that perform some of their operations within gst_deinit. >> >> Without this patch, if you

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Frediano Ziglio
> > Hi > > - Original Message - > > > > > > From: Christophe de Dinechin > > > > > > This is useful for some instrumentation, e.g. the leaks tracer, > > > that perform some of their operations within gst_deinit. > > > > > > Without this patch, if you run spicy

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Marc-André Lureau
Hi - Original Message - > > > > From: Christophe de Dinechin > > > > This is useful for some instrumentation, e.g. the leaks tracer, > > that perform some of their operations within gst_deinit. > > > > Without this patch, if you run spicy with > >

Re: [Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > This is useful for some instrumentation, e.g. the leaks tracer, > that perform some of their operations within gst_deinit. > > Without this patch, if you run spicy with > GST_DEBUG="GST_TRACER:7" GST_TRACERS="leaks" spicy ... >

[Spice-devel] [PATCH spice-gtk] Add call of gst_deinit at program exit

2017-10-19 Thread Christophe de Dinechin
From: Christophe de Dinechin This is useful for some instrumentation, e.g. the leaks tracer, that perform some of their operations within gst_deinit. Without this patch, if you run spicy with GST_DEBUG="GST_TRACER:7" GST_TRACERS="leaks" spicy ... the leak tracer