Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-04-10 Thread Alon Levy
On Tue, Apr 10, 2012 at 11:40:32AM +0200, Christophe Fergeau wrote: > On Tue, Apr 10, 2012 at 11:28:34AM +0200, Marc-André Lureau wrote: > > On Tue, Apr 10, 2012 at 11:09 AM, Christophe Fergeau > > wrote: > > > For what it's worth, one scenario where it's easier to go wrong than > > > before > >

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-04-10 Thread Christophe Fergeau
On Tue, Apr 10, 2012 at 11:28:34AM +0200, Marc-André Lureau wrote: > On Tue, Apr 10, 2012 at 11:09 AM, Christophe Fergeau > wrote: > > For what it's worth, one scenario where it's easier to go wrong than before > > is when distro patches have to be added to the protocol headers (for > > example en

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-04-10 Thread Marc-André Lureau
On Tue, Apr 10, 2012 at 11:09 AM, Christophe Fergeau wrote: > For what it's worth, one scenario where it's easier to go wrong than before > is when distro patches have to be added to the protocol headers (for > example enum values which are used in messages sent over the wire). This > happens when

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-04-10 Thread Christophe Fergeau
Hey, On Wed, Feb 22, 2012 at 01:15:30PM +0100, Alon Levy wrote: > On Wed, Feb 22, 2012 at 11:59:18AM +0100, Marc-André Lureau wrote: > > On Wed, Feb 22, 2012 at 9:15 AM, Alon Levy wrote: > > > Or do you think it > > > should diverge simply because different packages will have different > > > need

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 11:59:18AM +0100, Marc-André Lureau wrote: > On Wed, Feb 22, 2012 at 9:15 AM, Alon Levy wrote: > > Or do you think it > > should diverge simply because different packages will have different > > needs at the same time? > > I wouldn't say "diverge". It's the same protocol a

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-22 Thread Marc-André Lureau
On Wed, Feb 22, 2012 at 9:15 AM, Alon Levy wrote: > Or do you think it > should diverge simply because different packages will have different > needs at the same time? I wouldn't say "diverge". It's the same protocol after all, just used at build time only. If we break it, we are screwed anyway.

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-22 Thread Alon Levy
On Wed, Feb 22, 2012 at 12:27:07AM +0100, Marc-André Lureau wrote: > On Tue, Feb 21, 2012 at 6:48 PM, Alon Levy wrote: > > We will still need releases for anyone building from tarballs, which > > includes all distribution built packages. > > Not with the submodule & autofoo solution I proposed fo

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 6:48 PM, Alon Levy wrote: > We will still need releases for anyone building from tarballs, which > includes all distribution built packages. Not with the submodule & autofoo solution I proposed for spice-gtk. -- Marc-André Lureau _

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 02:28:06PM +0100, Christophe Fergeau wrote: > On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: > > Spice protocol contains only headers. We would like to be able to use > > a protocol update without having to wait for the release, a git > > submodule works

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 2:28 PM, Christophe Fergeau wrote: > Do we still make spice-protocol releases after that? If not, which package > should distribute the spice-protocol headers? spice-gtk headers still depends on spice-protocol, although we should be able to fix that. I haven't investigated

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Christophe Fergeau
On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: > Spice protocol contains only headers. We would like to be able to use > a protocol update without having to wait for the release, a git > submodule works well for this purpose. Do we still make spice-protocol releases after that?

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2012 at 2:03 PM, Gerd Hoffmann wrote: >> +     url = git://anongit.freedesktop.org/spice/spice-protocol > > IIRC relative paths work there too and 'git submodule init' picks up the > path from the parent then.  So committers automagically get a > "ssh://..." url for the submodu

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Gerd Hoffmann
> diff --git a/.gitmodules b/.gitmodules > new file mode 100644 > index 000..b628a96 > --- /dev/null > +++ b/.gitmodules > @@ -0,0 +1,3 @@ > +[submodule "spice-protocol"] > + path = spice-protocol > + url = git://anongit.freedesktop.org/spice/spice-protocol IIRC relative paths work the

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 12:25 PM, Marc-André Lureau wrote: > -SUBDIRS = common gtk po python_modules doc data > +SUBDIRS = spice-protocol common gtk po python_modules doc data even better is DIST_SUBDIRS = spice-protocol $(SUBDIRS) So it doesn't get installed. (If needed, we can add "all-local"

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: > Spice protocol contains only headers. We would like to be able to use > a protocol update without having to wait for the release, a git > submodule works well for this purpose. Looks good to me. I can revert my attempts to get jh

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 12:22 PM, Marc-André Lureau wrote: > Spice protocol contains only headers. We would like to be able to use > a protocol update without having to wait for the release, a git > submodule works well for this purpose. > --- >  .gitmodules    |    3 +++ >  autogen.sh     |    3

[Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well for this purpose. --- .gitmodules|3 +++ autogen.sh |3 +++ configure.ac | 12 +++- spice-protocol |1 + 4 file