Re: [Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

2019-01-03 Thread Marc-André Lureau
Hi On Thu, Jan 3, 2019 at 7:22 PM Frediano Ziglio wrote: > > > > > On Thu, Jan 03, 2019 at 04:46:29PM +0200, Snir Sheriber wrote: > > > GST_TYPE_PIPELINE is undeclared when gstvideo is disabled > > > > I'd rahter that we keep using the more specific type. Feel free to have > > a > > #ifndef

Re: [Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

2019-01-03 Thread Frediano Ziglio
> > On Thu, Jan 03, 2019 at 04:46:29PM +0200, Snir Sheriber wrote: > > GST_TYPE_PIPELINE is undeclared when gstvideo is disabled > > I'd rahter that we keep using the more specific type. Feel free to have > a > #ifndef HAVE_GST_VIDEO > #define GST_TYPE_PIPELINE G_TYPE_POINTER > #endif It sounds

Re: [Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

2019-01-03 Thread Christophe Fergeau
On Thu, Jan 03, 2019 at 04:46:29PM +0200, Snir Sheriber wrote: > GST_TYPE_PIPELINE is undeclared when gstvideo is disabled I'd rahter that we keep using the more specific type. Feel free to have a #ifndef HAVE_GST_VIDEO #define GST_TYPE_PIPELINE G_TYPE_POINTER #endif but would that code be used

Re: [Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

2019-01-03 Thread Frediano Ziglio
> > GST_TYPE_PIPELINE is undeclared when gstvideo is disabled > > Signed-off-by: Snir Sheriber This fixes current CI which is doing this test. Also removes this warning (I just got it): GISCAN SpiceClientGLib-2.0.gir :: Warning: SpiceClientGLib: (Signal)gst-video-overlay: argument

[Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

2019-01-03 Thread Snir Sheriber
GST_TYPE_PIPELINE is undeclared when gstvideo is disabled Signed-off-by: Snir Sheriber --- src/channel-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-display.c b/src/channel-display.c index 2a1d9d1..b0fe57e 100644 --- a/src/channel-display.c +++