Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events

2014-04-07 Thread Marc-André Lureau
: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events - Original Message - - if the guest display widget is focused and the user presses Caps lock, we will send a keypress message (which will cause the capslock

Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events

2014-04-07 Thread Jonathon Jongsma
-devel@lists.freedesktop.org Sent: Friday, April 4, 2014 12:16:26 PM Subject: Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events - Original Message - - if the guest display widget is focused and the user presses

[Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events

2014-04-04 Thread Marc-André Lureau
The channel state is not synchronous. It may happen that we want to set and unset quickly a modifier, but the guest modifier state hasn't been updated yet, and will still be seen as unset, preventing the last unset change. --- gtk/spice-gtk-session.c | 19 +++ 1 file changed, 11

Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events

2014-04-04 Thread Jonathon Jongsma
On Fri, 2014-04-04 at 12:47 +0200, Marc-André Lureau wrote: The channel state is not synchronous. It may happen that we want to set and unset quickly a modifier, but the guest modifier state hasn't been updated yet, and will still be seen as unset, preventing the last unset change. ---

Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events

2014-04-04 Thread Marc-André Lureau
- Original Message - - if the guest display widget is focused and the user presses Caps lock, we will send a keypress message (which will cause the capslock modifier to toggle on the guest) and then we will immediately send a modifers message. So we'll

Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client events

2014-04-04 Thread Jonathon Jongsma
- Original Message - From: Marc-André Lureau mlur...@redhat.com To: Jonathon Jongsma jjong...@redhat.com Cc: spice-devel@lists.freedesktop.org Sent: Friday, April 4, 2014 12:16:26 PM Subject: Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync modifiers for client