Re: [Spice-devel] [PATCH spice-gtk v2] spice-widget: Fix use after free

2018-04-19 Thread Victor Toso
Hi, On Thu, Apr 19, 2018 at 12:27:02PM +0100, Frediano Ziglio wrote: > Before d567bfe65f010556f12c7ca5e95d0e480b2e4a70 > ("spice-widget: fix leak of boxed type cursor-shape") the cursor was > just leaked. Now is freed however mouse_pixbuf points to cursor > data so when the cursor is freed mouse_p

[Spice-devel] [PATCH spice-gtk v2] spice-widget: Fix use after free

2018-04-19 Thread Frediano Ziglio
Before d567bfe65f010556f12c7ca5e95d0e480b2e4a70 ("spice-widget: fix leak of boxed type cursor-shape") the cursor was just leaked. Now is freed however mouse_pixbuf points to cursor data so when the cursor is freed mouse_pixbuf points to a dangling pointer. Retain the cursor as long as mouse_pixbuf