Re: [Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-21 Thread Snir Sheriber
On 1/21/19 2:04 PM, Frediano Ziglio wrote: On 1/21/19 12:21 PM, Frediano Ziglio wrote: Hi, Just came to me that it may fail if HAVE_LIBVA is not defined && version is >1.14 and so i checked and it seems to work also without the context handling, Is it possible that application's context handli

Re: [Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-21 Thread Frediano Ziglio
> On 1/21/19 12:21 PM, Frediano Ziglio wrote: > >> Hi, > >> > >> Just came to me that it may fail if HAVE_LIBVA is not defined && version > >> is >1.14 and so i checked and > >> it seems to work also without the context handling, Is it possible that > >> application's context handling is > >> not n

Re: [Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-21 Thread Snir Sheriber
On 1/21/19 12:21 PM, Frediano Ziglio wrote: Hi, Just came to me that it may fail if HAVE_LIBVA is not defined && version is >1.14 and so i checked and it seems to work also without the context handling, Is it possible that application's context handling is not needed? I couldn't find any related

Re: [Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-21 Thread Frediano Ziglio
> Hi, > > Just came to me that it may fail if HAVE_LIBVA is not defined && version > is >1.14 and so i checked and > it seems to work also without the context handling, Is it possible that > application's context handling is > not needed? I couldn't find any related vaapisink bug that was closed >

Re: [Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-20 Thread Snir Sheriber
Hi, Just came to me that it may fail if HAVE_LIBVA is not defined && version is >1.14 and so i checked and it seems to work also without the context handling, Is it possible that application's context handling is not needed? I couldn't find any related vaapisink bug that was closed recently.

Re: [Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-15 Thread Snir Sheriber
Hi, On 1/15/19 3:03 PM, Frediano Ziglio wrote: The vaapisink plugin to support overlay requires the application to provide the proper context. If you don't do so the plugin will cause a crash of the application. To avoid possible thread errors from X11 create a new Display connection to pass to

[Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

2019-01-15 Thread Frediano Ziglio
The vaapisink plugin to support overlay requires the application to provide the proper context. If you don't do so the plugin will cause a crash of the application. To avoid possible thread errors from X11 create a new Display connection to pass to vaapisink. Signed-off-by: Frediano Ziglio --- To