Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Pavel Grunt
> Please detail how that would help: to me it is introducing an agent > message subtype, and I don't see the need, you can simply use the > agent message type (which is already a subtype of spice main > messages) > I wanted to use the "type field" to determine the type of information of the tex

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Marc-André Lureau
On Wed, Oct 29, 2014 at 4:31 PM, Pavel Grunt wrote: > What do you think about using the message structure that was suggested in > v1 (with the "type" field specifying what type of information is provided) ? Please detail how that would help: to me it is introducing an agent message subtype, and

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Pavel Grunt
- Original Message - > From: "Marc-André Lureau" > On Wed, Oct 29, 2014 at 3:34 PM, Jonathon Jongsma < > jjong...@redhat.com > wrote: > > I'm not sure that I'm a big fan of a free-form field. It would be > > nice > > > if it had at least *some* structure and you could expert certain >

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Marc-André Lureau
On Wed, Oct 29, 2014 at 3:34 PM, Jonathon Jongsma wrote: > I'm not sure that I'm a big fan of a free-form field. It would be nice > if it had at least *some* structure and you could expert certain > information to be there... > Then I would have a defined structured message in the protocol rathe

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Jonathon Jongsma
On Wed, 2014-10-29 at 09:48 -0400, Marc-André Lureau wrote: > > - Mail original - > > On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote: > > > > > > > > > - Original Message - > > > > Message will be used by client for requesting an information about > > > > a ver

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Marc-André Lureau
- Mail original - > On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote: > > > > > > - Original Message - > > > Message will be used by client for requesting an information about > > > a version of the agent running on the guest side. > > > --- > > > v2: > > > - r

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-29 Thread Christophe Fergeau
On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote: > > > - Original Message - > > Message will be used by client for requesting an information about > > a version of the agent running on the guest side. > > --- > > v2: > > - removed 'type' field from VDAgentInformation >

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-24 Thread Marc-André Lureau
- Original Message - > Message will be used by client for requesting an information about > a version of the agent running on the guest side. > --- > v2: > - removed 'type' field from VDAgentInformation > - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION >VDAgentInformation c

[Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-24 Thread Pavel Grunt
Message will be used by client for requesting an information about a version of the agent running on the guest side. --- v2: - removed 'type' field from VDAgentInformation - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION VDAgentInformation changed to VDAgentGuestVersion - added VD_AGE