Re: [Spice-devel] [PATCH spice-protocol v3] stats: Avoid holes in SpiceStat structure

2019-01-04 Thread Frediano Ziglio
> > On Fri, Jan 04, 2019 at 08:23:15AM +, Frediano Ziglio wrote: > > The SpiceStat structure can be 20 or 24 bytes depending on alignment. > > Being a memory mapped structure potentially used with lockless access, > > it is not good to have it unaligned. > > The current tool that reads this

Re: [Spice-devel] [PATCH spice-protocol v3] stats: Avoid holes in SpiceStat structure

2019-01-04 Thread Christophe Fergeau
On Fri, Jan 04, 2019 at 08:23:15AM +, Frediano Ziglio wrote: > The SpiceStat structure can be 20 or 24 bytes depending on alignment. > Being a memory mapped structure potentially used with lockless access, > it is not good to have it unaligned. > The current tool that reads this memory mapped

[Spice-devel] [PATCH spice-protocol v3] stats: Avoid holes in SpiceStat structure

2019-01-04 Thread Frediano Ziglio
The SpiceStat structure can be 20 or 24 bytes depending on alignment. Being a memory mapped structure potentially used with lockless access, it is not good to have it unaligned. The current tool that reads this memory mapped file (reds_stats) is able to detect if the structure is either 20 or 24