Re: [Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-19 Thread Snir Sheriber
Hi, On 3/18/19 12:54 PM, Frediano Ziglio wrote: On 3/18/19 12:12 PM, Frediano Ziglio wrote: Hi, On 3/15/19 11:27 AM, Frediano Ziglio wrote: To avoid possibly regression check it only if extra checks are enabled. Currently there's already a "channel duplication" warning upon connection but

Re: [Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-18 Thread Frediano Ziglio
> On 3/18/19 12:12 PM, Frediano Ziglio wrote: > >> Hi, > >> > >> On 3/15/19 11:27 AM, Frediano Ziglio wrote: > >>> To avoid possibly regression check it only if extra checks are > >>> enabled. > >> > >> Currently there's already a "channel duplication" warning upon connection > >> but won't hurt

Re: [Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-18 Thread Snir Sheriber
On 3/18/19 12:12 PM, Frediano Ziglio wrote: Hi, On 3/15/19 11:27 AM, Frediano Ziglio wrote: To avoid possibly regression check it only if extra checks are enabled. Currently there's already a "channel duplication" warning upon connection but won't hurt to have this extra check and emit an

Re: [Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-18 Thread Frediano Ziglio
> > Hi, > > On 3/15/19 11:27 AM, Frediano Ziglio wrote: > > To avoid possibly regression check it only if extra checks are > > enabled. > > > Currently there's already a "channel duplication" warning upon connection > but won't hurt to have this extra check and emit an error. > I cannot find

Re: [Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-18 Thread Snir Sheriber
Hi, On 3/15/19 11:27 AM, Frediano Ziglio wrote: To avoid possibly regression check it only if extra checks are enabled. Currently there's already a "channel duplication" warning upon connection but won't hurt to have this extra check and emit an error. This allowed to check previous "Move

[Spice-devel] [PATCH spice-server] reds: Check we don't register a channel twice in reds_register_channel

2019-03-15 Thread Frediano Ziglio
To avoid possibly regression check it only if extra checks are enabled. This allowed to check previous "Move channel registration to constructed vfunc" commit. Signed-off-by: Frediano Ziglio --- server/reds.c | 5 + 1 file changed, 5 insertions(+) diff --git a/server/reds.c b/server/reds.c