Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-21 Thread bigclouds
Yonit Halperin: 1.you mean the patch is for client? 2.where is the code in client side from which i can get channel's status. if it is disconnected, i close client throught client's code. 3.i notice that there is 'session' . for client what does it mean? whether cleaning(close) session means c

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-21 Thread Yonit Halperin
On 05/20/2013 10:39 PM, bigclouds wrote: 1.is there a solution now? server may disconnect some of spice channels, but client does not reconnect , how to do with this? close client or let client reconnect? This patch hasn't been pushed. We concluded that the policy of disconnecting the client

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-20 Thread bigclouds
1.is there a solution now? server may disconnect some of spice channels, but client does not reconnect , how to do with this? close client or let client reconnect? 2. where is the code from which we can get socket signal(error,EPIPE..) when channel disconnected. thanks 在 2013-05-08 23:57:5

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-08 Thread Marc-André Lureau
On Wed, May 8, 2013 at 5:03 PM, Yonit Halperin wrote: > I can live with that. Maybe we should add to spice-gtk a user notification > when a channel gets suddenly disconnected. Since UI don't share same designs, the best place for such dialog is virt-viewer (or Boxes etc). We already have a s

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-08 Thread Yonit Halperin
On 05/08/2013 10:55 AM, Marc-André Lureau wrote: On Wed, May 8, 2013 at 4:55 PM, Yonit Halperin mailto:yhalp...@redhat.com>> wrote: If these channels were already connected, I believe it is better to close the client, than having the user don't understand why suddenly the display is

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-08 Thread Marc-André Lureau
On Wed, May 8, 2013 at 4:55 PM, Yonit Halperin wrote: > If these channels were already connected, I believe it is better to close > the client, than having the user don't understand why suddenly the display > is frozen, or why his keyboard and mouse don't work. > I guess you are talking from ser

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-08 Thread Yonit Halperin
On 05/08/2013 10:46 AM, Marc-André Lureau wrote: What is the motivation for doing that? The client could want to save bandwidth by closing a display channel, or he might want to disable all inputs temporarily. If these channels were already connected, I believe it is better to close the client,

Re: [Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-08 Thread Marc-André Lureau
What is the motivation for doing that? The client could want to save bandwidth by closing a display channel, or he might want to disable all inputs temporarily. And also, similarly, do you think the server should enforce that the client connect to all the mandatory channels? And how? On Wed, May

[Spice-devel] [PATCH spice-server 06/10] reds: disconnect the session when an essential channel is disconnected

2013-05-08 Thread Yonit Halperin
--- server/reds.c | 25 + 1 file changed, 25 insertions(+) diff --git a/server/reds.c b/server/reds.c index f6a1ce9..38923b0 100644 --- a/server/reds.c +++ b/server/reds.c @@ -194,12 +194,37 @@ static void reds_stream_push_channel_event(RedsStream *s, int event) main