Re: [Spice-devel] [PATCH spice-server 1/3] Use class name in comment

2017-02-15 Thread Frediano Ziglio
Yes, changed all, sending a v2 > > On Wed, Feb 15, 2017 at 11:46:21AM -0500, Frediano Ziglio wrote: > > > > > > ACK, maybe rcc: in the short log > > > > > > > I'd use red-channel-client: as consistent with the second... > > or change both to rcc! > > I meant to suggest to change the second on

Re: [Spice-devel] [PATCH spice-server 1/3] Use class name in comment

2017-02-15 Thread Christophe Fergeau
On Wed, Feb 15, 2017 at 11:46:21AM -0500, Frediano Ziglio wrote: > > > > ACK, maybe rcc: in the short log > > > > I'd use red-channel-client: as consistent with the second... > or change both to rcc! I meant to suggest to change the second one to rcc but forgot. Only reason for red-channel-clie

Re: [Spice-devel] [PATCH spice-server 1/3] Use class name in comment

2017-02-15 Thread Frediano Ziglio
> > ACK, maybe rcc: in the short log > I'd use red-channel-client: as consistent with the second... or change both to rcc! Not strong opinions, on the logs there are both versions Frediano > On Wed, Feb 15, 2017 at 12:49:05PM +, Frediano Ziglio wrote: > > red_channel seems a variable name

Re: [Spice-devel] [PATCH spice-server 1/3] Use class name in comment

2017-02-15 Thread Christophe Fergeau
ACK, maybe rcc: in the short log On Wed, Feb 15, 2017 at 12:49:05PM +, Frediano Ziglio wrote: > red_channel seems a variable name. > > Signed-off-by: Frediano Ziglio > --- > server/red-channel-client.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red-chan

[Spice-devel] [PATCH spice-server 1/3] Use class name in comment

2017-02-15 Thread Frediano Ziglio
red_channel seems a variable name. Signed-off-by: Frediano Ziglio --- server/red-channel-client.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-channel-client.h b/server/red-channel-client.h index 4f1d481..75d6cc3 100644 --- a/server/red-channel-client.h +++ b/se