Re: [Spice-devel] [PATCH spice-server 13/28] red_channel: monitor connection latency using MSG_PING

2013-04-15 Thread Yonit Halperin
On 04/14/2013 09:28 AM, Alon Levy wrote: On Tue, Feb 26, 2013 at 01:03:59PM -0500, Yonit Halperin wrote: ACK. just a note: maybe we should not send our time, but an id, to not leak information? Sending the time is not necessary. Just kept it in order to be compatible with the way we used it so

Re: [Spice-devel] [PATCH spice-server 13/28] red_channel: monitor connection latency using MSG_PING

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:59PM -0500, Yonit Halperin wrote: ACK. just a note: maybe we should not send our time, but an id, to not leak information? another note: should we drop the special case main channel ping later? other notes (all nitpick quality) below. > --- > server/inputs_channe

[Spice-devel] [PATCH spice-server 13/28] red_channel: monitor connection latency using MSG_PING

2013-02-26 Thread Yonit Halperin
--- server/inputs_channel.c | 1 + server/main_channel.c | 2 +- server/red_channel.c| 228 server/red_channel.h| 18 server/red_worker.c | 2 +- server/smartcard.c | 1 + server/spicevmc.c | 1 + 7 files cha