[Spice-devel] [PATCH spice-server 18/33] windows: Undefine some conflicting preprocessor macros

2018-12-21 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red-qxl.c | 1 + server/reds.c| 3 +++ 2 files changed, 4 insertions(+) diff --git a/server/red-qxl.c b/server/red-qxl.c index cec3eefb..886bf9f5 100644 --- a/server/red-qxl.c +++ b/server/red-qxl.c @@ -39,6 +39,7 @@ #include "red-qxl.h" +#undef

Re: [Spice-devel] [PATCH spice-server 18/33] windows: Undefine some conflicting preprocessor macros

2018-12-22 Thread Marc-André Lureau
On Fri, Dec 21, 2018 at 4:04 PM Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio I would suggest to wrap with #if _WIN32, otherwise it's really weird to see those undef without context. > --- > server/red-qxl.c | 1 + > server/reds.c| 3 +++ > 2 files changed, 4 insertions(+) > >

Re: [Spice-devel] [PATCH spice-server 18/33] windows: Undefine some conflicting preprocessor macros

2018-12-22 Thread Frediano Ziglio
> On Fri, Dec 21, 2018 at 4:04 PM Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > I would suggest to wrap with #if _WIN32, otherwise it's really weird > to see those undef without context. > Done, also added a comment like @@ -39,7 +39,10 @@ #include "red-qxl.h" +#ifd

Re: [Spice-devel] [PATCH spice-server 18/33] windows: Undefine some conflicting preprocessor macros

2019-01-03 Thread Christophe Fergeau
On Sat, Dec 22, 2018 at 09:27:02AM -0500, Frediano Ziglio wrote: > > > On Fri, Dec 21, 2018 at 4:04 PM Frediano Ziglio wrote: > > > > > > Signed-off-by: Frediano Ziglio > > > > I would suggest to wrap with #if _WIN32, otherwise it's really weird > > to see those undef without context. > > >

Re: [Spice-devel] [PATCH spice-server 18/33] windows: Undefine some conflicting preprocessor macros

2019-01-03 Thread Frediano Ziglio
> On Sat, Dec 22, 2018 at 09:27:02AM -0500, Frediano Ziglio wrote: > > > > > On Fri, Dec 21, 2018 at 4:04 PM Frediano Ziglio > > > wrote: > > > > > > > > Signed-off-by: Frediano Ziglio > > > > > > I would suggest to wrap with #if _WIN32, otherwise it's really weird > > > to see those undef wit

Re: [Spice-devel] [PATCH spice-server 18/33] windows: Undefine some conflicting preprocessor macros

2019-01-03 Thread Christophe Fergeau
On Thu, Jan 03, 2019 at 11:54:15AM -0500, Frediano Ziglio wrote: > > What about: > > "interface" and "MAX_MONITORS" are defined in some Windows system > headers causing garbage code to be fed to the compiler. Yes this is the missing bit. Christophe signature.asc Description: PGP signature ___